Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-09-13 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/
---

(Updated Sept. 13, 2015, 8:34 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8 
  src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
  src/tests/master_maintenance_tests.cpp 
fb8dca3757a9565d5eb5a69eed10aa34602bb15c 

Diff: https://reviews.apache.org/r/37623/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-09-13 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review98808
---

Ship it!



include/mesos/type_utils.hpp (line 326)


Maybe put the IP in parens rather than after a comma? And what if one is 
missing? Do you want to print just the IP with no parens if no hostname and 
just the hostname if no IP?



src/master/master.cpp (line 3755)


s/Down/DOWN/



src/master/master.cpp (line 3760)


Rather than say the machine is "under maintenance", can we just specify 
that it's down? I can see an operator bringing the machine down having nothing 
to do with maintenance and this log message throwing somebody off track (this 
is in fact one of the reasons we decided to just make the 'machine' endpoints 
be independent of 'maintenance' IIRC). Same comment applies below too.



src/master/master.cpp (line 3763)


s/Down/DOWN/



src/master/master.cpp (line 3944)


s/Down/DOWN/



src/tests/master_maintenance_tests.cpp (line 689)


Are you waiting for the same reason as above? I'd add more to the comment 
here as you did above as well.


- Benjamin Hindman


On Sept. 13, 2015, 8:34 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37623/
> ---
> 
> (Updated Sept. 13, 2015, 8:34 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8 
>   src/master/master.cpp c90311fa2152810e7604a0a2dee630bd14929574 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37623/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-09-02 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/
---

(Updated Sept. 2, 2015, 7:33 p.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8 
  src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
  src/tests/master_maintenance_tests.cpp 
fb8dca3757a9565d5eb5a69eed10aa34602bb15c 

Diff: https://reviews.apache.org/r/37623/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-09-02 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review97528
---


Bad patch!

Reviews applied: [37655, 36321, 36571, 37314, 37900, 37325, 37358, 37362, 
37364, 37170, 37172, 37173, 37175, 37176, 37177]

Failed command: ./support/apply-review.sh -n -r 37177

Error:
 2015-09-02 20:39:49 URL:https://reviews.apache.org/r/37177/diff/raw/ 
[36178/36178] -> "37177.patch" [1]
error: patch failed: src/master/allocator/mesos/hierarchical.hpp:175
error: src/master/allocator/mesos/hierarchical.hpp: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Sept. 2, 2015, 7:33 p.m., Joris Van Remoortere wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37623/
> ---
> 
> (Updated Sept. 2, 2015, 7:33 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
> 
> 
> Bugs: MESOS-1474
> https://issues.apache.org/jira/browse/MESOS-1474
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/type_utils.hpp 4fb0037a224cab7ebeb6644b5274227fedb172c8 
>   src/master/master.cpp 56bcbcc08fa0f98416c5048080adb25efc588019 
>   src/tests/master_maintenance_tests.cpp 
> fb8dca3757a9565d5eb5a69eed10aa34602bb15c 
> 
> Diff: https://reviews.apache.org/r/37623/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-08-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review96484
---


Bad patch!

Reviews applied: [37655, 36321, 36571]

Failed command: ./support/apply-review.sh -n -r 36571

Error:
 2015-08-26 02:15:28 URL:https://reviews.apache.org/r/36571/diff/raw/ 
[8196/8196] - 36571.patch [1]
error: patch failed: src/Makefile.am:414
error: src/Makefile.am: patch does not apply
Failed to apply patch

- Mesos ReviewBot


On Aug. 26, 2015, 2:13 a.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37623/
 ---
 
 (Updated Aug. 26, 2015, 2:13 a.m.)
 
 
 Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
 
 
 Bugs: MESOS-1474
 https://issues.apache.org/jira/browse/MESOS-1474
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
   src/tests/master_maintenance_tests.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37623/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Joris Van Remoortere

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-08-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review96294
---

Ship it!


Ship It!

- Guangya Liu


On Aug. 25, 2015, 2:44 a.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37623/
 ---
 
 (Updated Aug. 25, 2015, 2:44 a.m.)
 
 
 Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
 
 
 Bugs: MESOS-1474
 https://issues.apache.org/jira/browse/MESOS-1474
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
   src/tests/master_maintenance_tests.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37623/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Joris Van Remoortere

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-08-24 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/
---

(Updated Aug. 25, 2015, 2:44 a.m.)


Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-1474
https://issues.apache.org/jira/browse/MESOS-1474


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
  src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
  src/tests/master_maintenance_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37623/diff/


Testing
---


Thanks,

Joris Van Remoortere

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-08-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37623/#review96291
---


Patch looks great!

Reviews applied: [36321, 36571, 37314, 37325, 37358, 37362, 37364, 37170, 
37172, 37173, 37175, 37176, 37177, 37582, 37178, 37281, 37282, 37280, 37180, 
37234, 37283, 37284, 37621, 37622, 37623]

All tests passed.

- Mesos ReviewBot


On Aug. 25, 2015, 2:44 a.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/37623/
 ---
 
 (Updated Aug. 25, 2015, 2:44 a.m.)
 
 
 Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Joseph Wu.
 
 
 Bugs: MESOS-1474
 https://issues.apache.org/jira/browse/MESOS-1474
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See summary.
 
 
 Diffs
 -
 
   include/mesos/type_utils.hpp dafe1df0cb5d0b83ca0579068916fe7fda848f02 
   src/master/master.cpp 95207d24db0aa052eb70c4cc7eb75d0611c365cf 
   src/tests/master_maintenance_tests.cpp PRE-CREATION 
 
 Diff: https://reviews.apache.org/r/37623/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Joris Van Remoortere