Re: Review Request 38977: Added reason for declineOffer.

2016-07-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/#review141499
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Nov. 4, 2015, 6:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38977/
> ---
> 
> (Updated Nov. 4, 2015, 6:29 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3041
> https://issues.apache.org/jira/browse/MESOS-3041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The first patch to update API and proto part.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/scheduler/scheduler.proto 
> 417cfe6a9bca418b0ef77cb2268fafeb07867819 
>   include/mesos/v1/scheduler/scheduler.proto 
> 4f6cf5b0da1b89f6cd501c5f917253d428711efa 
>   src/sched/sched.cpp 4ec163315bb5b6a3d6f511d61863fbbff3254546 
> 
> Diff: https://reviews.apache.org/r/38977/diff/
> 
> 
> Testing
> ---
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38977: Added reason for declineOffer.

2015-11-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/#review105044
---


Patch looks great!

Reviews applied: [38977]

All tests passed.

- Mesos ReviewBot


On Nov. 4, 2015, 6:29 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38977/
> ---
> 
> (Updated Nov. 4, 2015, 6:29 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.
> 
> 
> Bugs: MESOS-3041
> https://issues.apache.org/jira/browse/MESOS-3041
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The first patch to update API and proto part.
> 
> 
> Diffs
> -
> 
>   include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
>   include/mesos/scheduler/scheduler.proto 
> 417cfe6a9bca418b0ef77cb2268fafeb07867819 
>   include/mesos/v1/scheduler/scheduler.proto 
> 4f6cf5b0da1b89f6cd501c5f917253d428711efa 
>   src/sched/sched.cpp 4ec163315bb5b6a3d6f511d61863fbbff3254546 
> 
> Diff: https://reviews.apache.org/r/38977/diff/
> 
> 
> Testing
> ---
> 
> Ubuntu 14.04
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 38977: Added reason for declineOffer.

2015-11-03 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38977/
---

(Updated εδΈ€ζœˆ 4, 2015, 6:29 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Joseph Wu, and Vinod Kone.


Summary (updated)
-

Added reason for declineOffer.


Bugs: MESOS-3041
https://issues.apache.org/jira/browse/MESOS-3041


Repository: mesos


Description (updated)
---

The first patch to update API and proto part.


Diffs (updated)
-

  include/mesos/scheduler.hpp f571d42d1508632152473c4f4ade60ae3900fce1 
  include/mesos/scheduler/scheduler.proto 
417cfe6a9bca418b0ef77cb2268fafeb07867819 
  include/mesos/v1/scheduler/scheduler.proto 
4f6cf5b0da1b89f6cd501c5f917253d428711efa 
  src/sched/sched.cpp 4ec163315bb5b6a3d6f511d61863fbbff3254546 

Diff: https://reviews.apache.org/r/38977/diff/


Testing
---

Ubuntu 14.04
make
make check


Thanks,

Guangya Liu