Re: Review Request 39317: Quota: Moved `QuotaInfo` protobuf into a separate package.

2015-11-09 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/
---

(Updated Nov. 9, 2015, 3:23 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Rebased.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am 938b8d403024e7b705b6088384292ad80452d9c6 

Diff: https://reviews.apache.org/r/39317/diff/


Testing
---

make check


Thanks,

Alexander Rukletsov

Re: Review Request 39317: Quota: Moved `QuotaInfo` protobuf into a separate package.

2015-11-08 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/
---

(Updated Nov. 8, 2015, 11 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

+Backticks


Summary (updated)
-

Quota: Moved `QuotaInfo` protobuf into a separate package.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description (updated)
---

See summary.


Diffs
-

  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am f0715386732b93936de6c8524957c6a6726fe9df 

Diff: https://reviews.apache.org/r/39317/diff/


Testing
---

make check


Thanks,

Alexander Rukletsov

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

2015-11-08 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/
---

(Updated Nov. 8, 2015, 10:53 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
and Joseph Wu.


Changes
---

Commets.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

Quota: Moved QuotaInfo protobuf into a separate package.


Diffs (updated)
-

  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  src/CMakeLists.txt cbc25e3ea33c47a787d34a7fa8499af3eb0b2c10 
  src/Makefile.am f0715386732b93936de6c8524957c6a6726fe9df 

Diff: https://reviews.apache.org/r/39317/diff/


Testing
---

make check


Thanks,

Alexander Rukletsov

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

2015-11-06 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/#review105420
---

Ship it!


Ship It!

- Klaus Ma


On Nov. 6, 2015, 3:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39317/
> ---
> 
> (Updated Nov. 6, 2015, 3:28 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Moved QuotaInfo protobuf into a separate package.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
> 
> Diff: https://reviews.apache.org/r/39317/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

2015-11-04 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/#review105165
---

Ship it!



include/mesos/master/quota.proto (lines 27 - 32)


It's nice that within this review you made an explicit decision not to copy 
this to V1. You also have some great argument for that. Can you please capture 
these as a comment in the code here so that users and future developers will 
see the path forward?


- Joris Van Remoortere


On Oct. 23, 2015, 4:38 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39317/
> ---
> 
> (Updated Oct. 23, 2015, 4:38 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Moved QuotaInfo protobuf into a separate package.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
> 
> Diff: https://reviews.apache.org/r/39317/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

2015-10-25 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/#review103944
---

Ship it!


Ship It!

- Qian Zhang


On Oct. 24, 2015, 12:38 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39317/
> ---
> 
> (Updated Oct. 24, 2015, 12:38 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3164
> https://issues.apache.org/jira/browse/MESOS-3164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Quota: Moved QuotaInfo protobuf into a separate package.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
>   include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
>   src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
>   src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 
> 
> Diff: https://reviews.apache.org/r/39317/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 39317: Quota: Moved QuotaInfo protobuf into a separate package.

2015-10-23 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39317/
---

(Updated Oct. 23, 2015, 4:38 p.m.)


Review request for mesos, Bernd Mathiske, Joerg Schad, and Joris Van Remoortere.


Bugs: MESOS-3164
https://issues.apache.org/jira/browse/MESOS-3164


Repository: mesos


Description
---

Quota: Moved QuotaInfo protobuf into a separate package.


Diffs
-

  include/mesos/master/quota.hpp 5f7822f40af6fb23cdafdd0c205bcdc67e596935 
  include/mesos/master/quota.proto d2e3a45735e4ebcf257682556aff5075e6e3bf79 
  src/CMakeLists.txt e6169a0e3ad34dd0e4c3430a6532bd48c4bd04fd 
  src/Makefile.am 98cbafc134ec388a176d50172912fbfdf9f5bfa3 

Diff: https://reviews.apache.org/r/39317/diff/


Testing
---

make check


Thanks,

Alexander Rukletsov