Re: Review Request 39498: SSLTest refactor: Change SSLTest to inherit from TemporaryDirectoryTest.

2015-10-26 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39498/#review104081
---

Ship it!



3rdparty/libprocess/include/process/ssl/gtest.hpp (line 136)


indentation
snake_case?



3rdparty/libprocess/include/process/ssl/gtest.hpp (line 143)


I prefer irrecoverably :-)



3rdparty/libprocess/include/process/ssl/gtest.hpp (line 232)


`so as not to abort` ?


- Joris Van Remoortere


On Oct. 22, 2015, 12:04 a.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39498/
> ---
> 
> (Updated Oct. 22, 2015, 12:04 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
> 
> 
> Bugs: MESOS-3762
> https://issues.apache.org/jira/browse/MESOS-3762
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This simplifies some of the cleanup logic, since temporary directories are
> cleaned up by the super class, or by the OS.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 91991f509e480a94de00c6bf20ff0abf083dda8a 
> 
> Diff: https://reviews.apache.org/r/39498/diff/
> 
> 
> Testing
> ---
> 
> Tests run in next review.
> 
> Tests are slightly slower, by a few dozen ms per test, since SetUp happens on 
> a per-test, rather than per-test-class basis.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Re: Review Request 39498: SSLTest refactor: Change SSLTest to inherit from TemporaryDirectoryTest.

2015-10-26 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39498/
---

(Updated Oct. 26, 2015, 3:33 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Changes
---

Address comments :)


Bugs: MESOS-3762
https://issues.apache.org/jira/browse/MESOS-3762


Repository: mesos


Description
---

This simplifies some of the cleanup logic, since temporary directories are
cleaned up by the super class, or by the OS.


Diffs (updated)
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
91991f509e480a94de00c6bf20ff0abf083dda8a 

Diff: https://reviews.apache.org/r/39498/diff/


Testing
---

Tests run in next review.

Tests are slightly slower, by a few dozen ms per test, since SetUp happens on a 
per-test, rather than per-test-class basis.


Thanks,

Joseph Wu

Re: Review Request 39498: SSLTest refactor: Change SSLTest to inherit from TemporaryDirectoryTest.

2015-10-21 Thread Joseph Wu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39498/
---

(Updated Oct. 21, 2015, 5:04 p.m.)


Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.


Summary (updated)
-

SSLTest refactor: Change SSLTest to inherit from TemporaryDirectoryTest.


Bugs: MESOS-3762
https://issues.apache.org/jira/browse/MESOS-3762


Repository: mesos


Description
---

This simplifies some of the cleanup logic, since temporary directories are
cleaned up by the super class, or by the OS.


Diffs
-

  3rdparty/libprocess/include/process/ssl/gtest.hpp 
91991f509e480a94de00c6bf20ff0abf083dda8a 

Diff: https://reviews.apache.org/r/39498/diff/


Testing
---

Tests run in next review.

Tests are slightly slower, by a few dozen ms per test, since SetUp happens on a 
per-test, rather than per-test-class basis.


Thanks,

Joseph Wu