Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105527
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 389)


I moved this inside of the if(streaming) block since we only need it when 
streaming is enabled.


- Timothy Chen


On Nov. 6, 2015, 7:39 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> ---
> 
> (Updated Nov. 6, 2015, 7:39 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 29d4d4d6d60ec634efb21b951cf20ff90f6ffed6 
> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 6, 2015, 6:56 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

safer version of saveblob


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
29d4d4d6d60ec634efb21b951cf20ff90f6ffed6 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese 


> On Nov. 6, 2015, 6:05 p.m., Timothy Chen wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp, line 
> > 394
> > 
> >
> > We used Shared<> instead of std::shared_ptr in our code base.

dropping based on our discussion


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105451
---


On Nov. 6, 2015, 6:56 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> ---
> 
> (Updated Nov. 6, 2015, 6:56 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> 29d4d4d6d60ec634efb21b951cf20ff90f6ffed6 
> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 6, 2015, 3:50 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 6, 2015, 5:17 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105451
---



src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp (line 392)


We used Shared<> instead of std::shared_ptr in our code base.


- Timothy Chen


On Nov. 6, 2015, 5:17 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> ---
> 
> (Updated Nov. 6, 2015, 5:17 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-06 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 6, 2015, 7:39 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

made saveBlob same as ```internal::_write ```


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
29d4d4d6d60ec634efb21b951cf20ff90f6ffed6 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 5, 2015, 4:02 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 5, 2015, 11:59 p.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese 


> On Nov. 5, 2015, 8:38 p.m., Timothy Chen wrote:
> > I don't see why we need this commit from the previos one. Can we merge this 
> > with the last one?

The reason being that the changes here are significant. We can merge the two if 
you think.


- Jojy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105303
---


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> ---
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 6, 2015, 12:38 a.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

rebased.


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/#review105303
---


I don't see why we need this commit from the previos one. Can we merge this 
with the last one?

- Timothy Chen


On Nov. 5, 2015, 4:02 p.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39840/
> ---
> 
> (Updated Nov. 5, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Made reading the stream from the PIPE common.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
> e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 
> 
> Diff: https://reviews.apache.org/r/39840/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 6, 2015, 7:43 a.m.)


Review request for mesos, Ben Mahler and Timothy Chen.


Changes
---

removed mutable lambda from streaming read


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-04 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 4, 2015, 11:24 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

rebased.


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Re: Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-01 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

(Updated Nov. 1, 2015, 3:52 p.m.)


Review request for mesos and Ben Mahler.


Changes
---

removed overloaded methd.


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Review Request 39840: RegistryClient refactor: pulled up streaming read

2015-11-01 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39840/
---

Review request for mesos and Ben Mahler.


Repository: mesos


Description
---

Made reading the stream from the PIPE common.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 
e4d2c22cf6627c1c76ebafeeb84b2bbf6b8c238c 

Diff: https://reviews.apache.org/r/39840/diff/


Testing
---

make check.


Thanks,

Jojy Varghese