Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-23 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/
---

(Updated Nov. 23, 2015, 11:44 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Removed unused "using" statement from test code.


Diffs (updated)
-

  src/tests/containerizer/external_containerizer_test.cpp 
c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
  src/tests/containerizer/isolator_tests.cpp 
01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
  src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
  src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
  src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 

Diff: https://reviews.apache.org/r/40246/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-20 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/
---

(Updated Nov. 20, 2015, 10:32 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Rebase.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Removed unused "using" statement from test code.


Diffs (updated)
-

  src/tests/containerizer/external_containerizer_test.cpp 
c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
  src/tests/containerizer/isolator_tests.cpp 
01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
  src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
  src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
  src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 

Diff: https://reviews.apache.org/r/40246/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-18 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/
---

(Updated Nov. 18, 2015, 11:27 a.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address mpark's comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Removed unused "using" statement from test code.


Diffs (updated)
-

  src/tests/containerizer/external_containerizer_test.cpp 
c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
  src/tests/containerizer/isolator_tests.cpp 
01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
  src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
  src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
  src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 

Diff: https://reviews.apache.org/r/40246/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-18 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/#review107120
---

Ship it!


Ship It!

- Guangya Liu


On 十一月 18, 2015, 11:27 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40246/
> ---
> 
> (Updated 十一月 18, 2015, 11:27 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused "using" statement from test code.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/external_containerizer_test.cpp 
> c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
>   src/tests/containerizer/isolator_tests.cpp 
> 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
>   src/tests/reservation_endpoints_tests.cpp 
> 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
>   src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
>   src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
>   src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 
> 
> Diff: https://reviews.apache.org/r/40246/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-18 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/#review107099
---

Ship it!


Ship It!

- Greg Mann


On Nov. 18, 2015, 11:27 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40246/
> ---
> 
> (Updated Nov. 18, 2015, 11:27 a.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused "using" statement from test code.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/external_containerizer_test.cpp 
> c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
>   src/tests/containerizer/isolator_tests.cpp 
> 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
>   src/tests/reservation_endpoints_tests.cpp 
> 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
>   src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
>   src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
>   src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 
> 
> Diff: https://reviews.apache.org/r/40246/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-17 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/#review106965
---

Ship it!


Ship It!

- Michael Park


On Nov. 13, 2015, 12:43 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40246/
> ---
> 
> (Updated Nov. 13, 2015, 12:43 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused "using" statement from test code.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/external_containerizer_test.cpp 
> c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
>   src/tests/containerizer/isolator_tests.cpp 
> 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
>   src/tests/reservation_endpoints_tests.cpp 
> 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
>   src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
>   src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
>   src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 
> 
> Diff: https://reviews.apache.org/r/40246/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-13 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/
---

(Updated Nov. 13, 2015, 12:43 p.m.)


Review request for mesos, Greg Mann and Michael Park.


Changes
---

Address comments.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Removed unused "using" statement from test code.


Diffs (updated)
-

  src/tests/containerizer/external_containerizer_test.cpp 
c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
  src/tests/containerizer/isolator_tests.cpp 
01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
  src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
  src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
  src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 

Diff: https://reviews.apache.org/r/40246/diff/


Testing
---


Thanks,

Neil Conway

Re: Review Request 40246: Removed unused "using" statement from test code.

2015-11-12 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/#review106371
---



src/tests/containerizer/isolator_tests.cpp (lines 104 - 105)


remove?



src/tests/reservation_endpoints_tests.cpp (line 62)


is this can be removed?



src/tests/reservation_endpoints_tests.cpp (line 63)


remove this?



src/tests/reservation_tests.cpp (line 67)


remove this?



src/tests/teardown_tests.cpp (line 55)


remove this?



src/tests/teardown_tests.cpp (line 56)


remove?


- Guangya Liu


On 十一月 12, 2015, 6 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40246/
> ---
> 
> (Updated 十一月 12, 2015, 6 p.m.)
> 
> 
> Review request for mesos, Greg Mann and Michael Park.
> 
> 
> Bugs: MESOS-2455
> https://issues.apache.org/jira/browse/MESOS-2455
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused "using" statement from test code.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/external_containerizer_test.cpp 
> c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
>   src/tests/containerizer/isolator_tests.cpp 
> 01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
>   src/tests/reservation_endpoints_tests.cpp 
> 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
>   src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
>   src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 
> 
> Diff: https://reviews.apache.org/r/40246/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Review Request 40246: Removed unused "using" statement from test code.

2015-11-12 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40246/
---

Review request for mesos, Greg Mann and Michael Park.


Bugs: MESOS-2455
https://issues.apache.org/jira/browse/MESOS-2455


Repository: mesos


Description
---

Removed unused "using" statement from test code.


Diffs
-

  src/tests/containerizer/external_containerizer_test.cpp 
c6993bab736bbe300c5d84ca6ca281a4f23bdef8 
  src/tests/containerizer/isolator_tests.cpp 
01d22b46a681f40dfa923f0a5c9b9b9b084d9bcd 
  src/tests/reservation_endpoints_tests.cpp 
1552e4537c4f4d79bfa4bc17ccab2df630bc32a4 
  src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3 
  src/tests/teardown_tests.cpp 96e98bd0d134b2cf093285f37bec4c89c8f3553e 

Diff: https://reviews.apache.org/r/40246/diff/


Testing
---


Thanks,

Neil Conway