> On Nov. 19, 2015, 9:59 a.m., Joseph Wu wrote:
> > Overall notes:
> > * Looks like everything is in place (to my knowledge) for this change :)
> > * (Mentioned in the last working group sync) We **may** want to rename the
> > feature to something else, like "oversubscription for reservations".
>
> Guangya Liu wrote:
> Agree, I will update the name to "oversubscription for reservations"
Sorry! I should have been more explicit that I didn't want you to rename the
variable. (At least, not until the working group has nailed down the
public-facing name for this feature.)
You should probably stick with the original variable name in the meantime.
- Joseph
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40339/#review107206
---
On Nov. 20, 2015, 4:59 a.m., Guangya Liu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40339/
> ---
>
> (Updated Nov. 20, 2015, 4:59 a.m.)
>
>
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Klaus
> Ma.
>
>
> Bugs: MESOS-3887
> https://issues.apache.org/jira/browse/MESOS-3887
>
>
> Repository: mesos
>
>
> Description
> ---
>
> Added a flag to master to enable optimistic offers.
>
>
> Diffs
> -
>
> include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3
> src/master/allocator/mesos/allocator.hpp
> d2d32af227d66c4030becd4cd64b907a70d25f49
> src/master/allocator/mesos/hierarchical.hpp
> 64ccf4164197e59d93d739fa2afbdee2cc2a1d23
> src/master/allocator/mesos/hierarchical.cpp
> f2e3b639f210eb06c70584ee7294609d9fd978ad
> src/master/flags.hpp 5fd5d502697b2edc22ae98a5a8e361bf62bf8bb6
> src/master/flags.cpp 806e2da6ad37a6acf76818d4c6b3c462175fd09d
> src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28
> src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34
> src/tests/hierarchical_allocator_tests.cpp
> 740cfa801ee90417c038308192d1f4f2416f8315
> src/tests/master_allocator_tests.cpp
> 646cacd3e16b9e0b72c0b259eecf2760cfb530db
> src/tests/reservation_endpoints_tests.cpp
> 1552e4537c4f4d79bfa4bc17ccab2df630bc32a4
> src/tests/reservation_tests.cpp ac664ebb49e74aa28551f427ea8f39ac9ce0cfb3
> src/tests/resource_offers_tests.cpp
> bf2fe3ac7b982e31d289a703ae637d8e2b3a2d8a
> src/tests/slave_recovery_tests.cpp 2cc7132deb9b8c324aa9dbab0b81643d07377a89
>
> Diff: https://reviews.apache.org/r/40339/diff/
>
>
> Testing
> ---
>
> Ubuntu 14.04
> make
> make check
>
>
> Thanks,
>
> Guangya Liu
>
>