Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-20 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40367/#review107459
---

Ship it!


Ship It!

- Timothy Chen


On Nov. 16, 2015, 9:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40367/
> ---
> 
> (Updated Nov. 16, 2015, 9:31 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3786
> https://issues.apache.org/jira/browse/MESOS-3786
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added backtick usage in comments to the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/40367/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos Website Container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-20 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40367/#review107423
---

Ship it!


Ship It!

- Joerg Schad


On Nov. 16, 2015, 9:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40367/
> ---
> 
> (Updated Nov. 16, 2015, 9:31 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3786
> https://issues.apache.org/jira/browse/MESOS-3786
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added backtick usage in comments to the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/40367/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos Website Container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40367/#review106779
---

Ship it!


Ship It!

- Guangya Liu


On 十一月 16, 2015, 9:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40367/
> ---
> 
> (Updated 十一月 16, 2015, 9:31 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3786
> https://issues.apache.org/jira/browse/MESOS-3786
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added backtick usage in comments to the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/40367/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos Website Container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40367/#review106755
---


Patch looks great!

Reviews applied: [40367]

All tests passed.

- Mesos ReviewBot


On Nov. 16, 2015, 9:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40367/
> ---
> 
> (Updated Nov. 16, 2015, 9:31 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3786
> https://issues.apache.org/jira/browse/MESOS-3786
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added backtick usage in comments to the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/40367/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos Website Container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Re: Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40367/#review106747
---

Ship it!


Ship It!

- Alexander Rukletsov


On Nov. 16, 2015, 9:31 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40367/
> ---
> 
> (Updated Nov. 16, 2015, 9:31 p.m.)
> 
> 
> Review request for mesos, Michael Park and Neil Conway.
> 
> 
> Bugs: MESOS-3786
> https://issues.apache.org/jira/browse/MESOS-3786
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added backtick usage in comments to the C++ style guide.
> 
> 
> Diffs
> -
> 
>   docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 
> 
> Diff: https://reviews.apache.org/r/40367/diff/
> 
> 
> Testing
> ---
> 
> Viewed with the Mesos Website Container 
> (https://github.com/mesosphere/mesos-website-container).
> 
> 
> Thanks,
> 
> Greg Mann
> 
>



Review Request 40367: Added backtick usage in comments to the C++ style guide.

2015-11-16 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40367/
---

Review request for mesos, Michael Park and Neil Conway.


Bugs: MESOS-3786
https://issues.apache.org/jira/browse/MESOS-3786


Repository: mesos


Description
---

Added backtick usage in comments to the C++ style guide.


Diffs
-

  docs/c++-style-guide.md 0b6189174a4f0f1815625f68fb1a743b04a9cdad 

Diff: https://reviews.apache.org/r/40367/diff/


Testing
---

Viewed with the Mesos Website Container 
(https://github.com/mesosphere/mesos-website-container).


Thanks,

Greg Mann