subject:"Review Request 40553\: Enable mesos tests installation"

Re: Review Request 40553: Enable mesos tests installation.

2016-02-08 Thread Till Toenshoff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review118233
---


Fix it, then Ship it!




Thanks a bunch James, this looks great considering the complexity ;). Just some 
(debatable) nits I will fix while landing this.


Makefile.am (lines 98 - 100)


Backslash alignment.



src/Makefile.am (lines 1883 - 1884)


Let's make the backslashes align.



src/Makefile.am (lines 1986 - 1994)


Backslash alignment.



src/tests/containerizer/memory_test_helper.cpp 


This should remain.



src/tests/utils.hpp (line 65)


For consistency, let's add a short comment here as well.


- Till Toenshoff


On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Feb. 4, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93 
>   src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fd6f063bc5dc3761368742851e6853547c602e3b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-02-08 Thread Till Toenshoff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review118249
---




src/tests/script.cpp (line 112)


Whoops, this one was not supposed to get removed.


- Till Toenshoff


On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Feb. 4, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93 
>   src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fd6f063bc5dc3761368742851e6853547c602e3b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-02-04 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review117871
---



Patch looks great!

Reviews applied: [39780, 39781, 39782, 40553]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 6:14 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Feb. 4, 2016, 6:14 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93 
>   src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fd6f063bc5dc3761368742851e6853547c602e3b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-02-04 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Feb. 4, 2016, 6:14 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Rebase onto master.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs (updated)
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac cb39c7f7681eb7f5e3c379dc9a096eca1ffcca93 
  src/Makefile.am a851862a476f8fec03e90d37ec5741f080c047e7 
  src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
fd6f063bc5dc3761368742851e6853547c602e3b 
  src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
  src/tests/mesos.cpp 8f1f8d69b299620891364c82a89a08e16706589e 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/tests/module_tests.cpp 7b3e98bfcc3d119edd642a010bea92f47f9fe7c5 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp c857c2bd5135d0e30edfe6f5e856fe6641b8dcfb 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp b2b1fd4be933512c3dffa8c1c579b59782a37d77 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier



> On Jan. 27, 2016, 8:44 p.m., Benjamin Bannier wrote:
> > Looks mostly good to me. A few things were unclear to me:
> > 
> > * Would it make sense to add an `installcheck` target? My expectation for 
> > that would be for it to invoke the installed tests and adding the 
> > (in)correct `builddir` magic to make sure only stuff from `$PREFIX` is used.
> > * Why don't we install stout or libprocess tests? I would have thought that 
> > especially the libprocess tests could be useful to diagnose low-level 
> > incompatibilites.
> 
> James Peach wrote:
> I added an ``installcheck`` target.
> 
> I didn't try to deal with stout or libprocess at the same time as this. 
> Maybe it makes sense to also install them, but the Mesos suite is going to 
> give the most benefit. If we want to go down that path, I'd like to do that 
> as separate Jira tickets.

Nice. I've filed MESOS-4538 to activate `--enable-tests-install` for CI 
distcheck so these tests don't rot away. I've also filed MESOS-4537 for 
installing stout and libprocess tests.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116610
---


On Jan. 27, 2016, 10:03 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 27, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 182fe9217a5da9af603d6f9c203a1689eff4ca1b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116652
---


Fix it, then Ship it!





src/Makefile.am (line 1999)


Sorry for being unclear, of course `s/installcheck/installcheck-local`.


- Benjamin Bannier


On Jan. 27, 2016, 10:03 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 27, 2016, 10:03 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 182fe9217a5da9af603d6f9c203a1689eff4ca1b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 28, 2016, 12:49 a.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Switch to installcheck-local.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs (updated)
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
182fe9217a5da9af603d6f9c203a1689eff4ca1b 
  src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
  src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116714
---



Patch looks great!

Reviews applied: [39780, 39781, 39782, 40553]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 28, 2016, 12:49 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 28, 2016, 12:49 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 182fe9217a5da9af603d6f9c203a1689eff4ca1b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 27, 2016, 5:54 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Rebased onto master and added support for new tests.

All tests are passing except the python and Java example frameworks and 
ZooKeeper tests, since those tests intrinsically depend on artifacts that are 
only found in the source tree.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description (updated)
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs (updated)
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
182fe9217a5da9af603d6f9c203a1689eff4ca1b 
  src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
  src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116608
---



Patch looks great!

Reviews applied: [39780, 39781, 39782, 40553]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 27, 2016, 5:54 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 27, 2016, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 182fe9217a5da9af603d6f9c203a1689eff4ca1b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116610
---



Looks mostly good to me. A few things were unclear to me:

* Would it make sense to add an `installcheck` target? My expectation for that 
would be for it to invoke the installed tests and adding the (in)correct 
`builddir` magic to make sure only stuff from `$PREFIX` is used.
* Why don't we install stout or libprocess tests? I would have thought that 
especially the libprocess tests could be useful to diagnose low-level 
incompatibilites.


src/Makefile.am (lines 1684 - 1688)


Does the reasoning here need an update?



src/Makefile.am (lines 1693 - 1694)


nit-pick: remove spaces before tabs here.



src/Makefile.am (line 1719)


This seems to be fixed now, right? If yes, probably a good idea to revisit 
(and close?) MESOS-1940.



src/Makefile.am (line 1962)


nit-pick: remove space before tabs here.


- Benjamin Bannier


On Jan. 27, 2016, 6:54 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 27, 2016, 6:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 182fe9217a5da9af603d6f9c203a1689eff4ca1b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 27, 2016, 9:03 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Updated to address review comments.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs (updated)
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
  src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
  src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
182fe9217a5da9af603d6f9c203a1689eff4ca1b 
  src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
  src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
  src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation.

2016-01-27 Thread James Peach



> On Jan. 27, 2016, 7:44 p.m., Benjamin Bannier wrote:
> > Looks mostly good to me. A few things were unclear to me:
> > 
> > * Would it make sense to add an `installcheck` target? My expectation for 
> > that would be for it to invoke the installed tests and adding the 
> > (in)correct `builddir` magic to make sure only stuff from `$PREFIX` is used.
> > * Why don't we install stout or libprocess tests? I would have thought that 
> > especially the libprocess tests could be useful to diagnose low-level 
> > incompatibilites.

I added an ``installcheck`` target.

I didn't try to deal with stout or libprocess at the same time as this. Maybe 
it makes sense to also install them, but the Mesos suite is going to give the 
most benefit. If we want to go down that path, I'd like to do that as separate 
Jira tickets.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116610
---


On Jan. 27, 2016, 5:54 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 27, 2016, 5:54 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 8657a869f931aa7482fbb09f2c6df95b6a8c50c6 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> a45ed1b2175b7dc16d621a44fbccfb8f957ae2b5 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 182fe9217a5da9af603d6f9c203a1689eff4ca1b 
>   src/tests/environment.cpp e112270b68d402bb9b01445af552500fb3929e52 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 65e8fe25ed7feb1080ad833ba98e6b462bd3152c 
>   src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8 
>   src/tests/module.cpp 246f3a402d4fe3b273c459f6e02c009f3de65f3e 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-01-26 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review116385
---



Could you please rebase? This doesn't apply for me with `9e0528e`.

- Benjamin Bannier


On Jan. 22, 2016, 11:12 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 22, 2016, 11:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
> --build_dir=/none \
> --source_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fab16f697f90abc11d681222f10f518d70da908b 
>   src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
>   src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-01-22 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 22, 2016, 10:12 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Summary (updated)
-

Enable mesos tests installation.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
--build_dir=/none \
--source_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
  src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
  src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
fab16f697f90abc11d681222f10f518d70da908b 
  src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation

2016-01-22 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 22, 2016, 10:03 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Updated to get ExampleFramework tests working. Verified on Fedora 23. All 
non-root tests pass both when you install and when you run from the build 
directory. When running as root, I got 2 failures because I have swap enabled, 
and 1 because the network isolator doesn't expect the net_prio cgroup.

```
[jpeach@jpeach build-install-tests]$ /opt/mesos/libexec/mesos/tests/mesos-tests 
 --build_dir=/none --source_dir=/none
...
[==] 896 tests from 119 test cases ran. (181364 ms total)
[  PASSED  ] 896 tests.
```


Summary (updated)
-

Enable mesos tests installation


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description (updated)
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
--build_dir=/none \
--source_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs (updated)
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
  src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
  src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
fab16f697f90abc11d681222f10f518d70da908b 
  src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 6f43103e81303015fb614653e3bfece55009d1bf 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation.

2016-01-22 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review115974
---



Patch looks great!

Reviews applied: [39780, 39781, 39782, 40553]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 22, 2016, 10:12 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 22, 2016, 10:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests \
> --build_dir=/none \
> --source_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 70d16871d5888ac1d9d5fb0ba0b453799b00f320 
>   src/Makefile.am 19bf3a7c2e43ca04ed6e6d506e052de5537f7c2f 
>   src/examples/test_framework.cpp ff7b00543eea1a7cbf52c7abfba81600868bfbab 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fab16f697f90abc11d681222f10f518d70da908b 
>   src/tests/environment.cpp 4de46bc48b245a4c5e89b0343578b0d31883a0ac 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
>   src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 6f43103e81303015fb614653e3bfece55009d1bf 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e943ab99baf3d74679a5da89a89f6a4b7ead 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation

2016-01-16 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review114851
---


Bad patch!

Reviews applied: [39780, 39781, 39782, 40553]

Failed command: ./support/apply-review.sh -n -r 40553

Error:
 2016-01-16 08:40:21 URL:https://reviews.apache.org/r/40553/diff/raw/ 
[46635/46635] -> "40553.patch" [1]
Total errors found: 0
Checking 16 files
Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 16, 2016, 5:53 a.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 16, 2016, 5:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> 
> Diffs
> -
> 
>   Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
>   configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
>   src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
>   src/tests/balloon_framework_test.sh 
> 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> fab16f697f90abc11d681222f10f518d70da908b 
>   src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
>   src/tests/event_call_framework_test.sh 
> 9d1211552734afbf15b376f8c4629bae8a2065af 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
>   src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/no_executor_framework_test.sh 
> aebdc8c380abb2d041d6fc74dfac5a111c15267e 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
>   src/tests/persistent_volume_framework_test.sh 
> 84f02847a8d89400512d8a5714d33fb29cf5b03a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa 
>   src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

2016-01-16 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 16, 2016, 5:41 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Update summary with a period.


Summary (updated)
-

Enable mesos tests installation.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
fab16f697f90abc11d681222f10f518d70da908b 
  src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation.

2016-01-15 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 15, 2016, 6:44 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Updated with changes to make various test scripts work. Current status:

$ sudo /opt/mesos/libexec/mesos/tests/mesos-tests --build_dir=/none
...
[--] Global test environment tear-down
/opt/home/src/mesos.git/src/tests/environment.cpp:565: Failure
Failed
Tests completed with child processes remaining:
-+- 5916 /opt/mesos/libexec/mesos/tests/mesos-tests --build_dir=/none
\--- 8246 /opt/mesos/libexec/mesos/tests/mesos-tests --build_dir=/none
[==] 961 tests from 142 test cases ran. (317343 ms total)
[  PASSED  ] 950 tests.
[  FAILED  ] 11 tests, listed below:
[  FAILED  ] ExamplesTest.TestFramework
[  FAILED  ] ExamplesTest.EventCallFramework
[  FAILED  ] 
MesosContainerizerSlaveRecoveryTest.CGROUPS_ROOT_PerfRollForward
[  FAILED  ] PerfEventIsolatorTest.ROOT_CGROUPS_Sample
[  FAILED  ] UserCgroupIsolatorTest/2.ROOT_CGROUPS_UserCgroup, where 
TypeParam = mesos::internal::slave::CgroupsPerfEventIsolatorProcess
[  FAILED  ] CgroupsAnyHierarchyWithCpuMemoryTest.ROOT_CGROUPS_Listen
[  FAILED  ] CgroupsAnyHierarchyWithPerfEventTest.ROOT_CGROUPS_Perf
[  FAILED  ] CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreaseRSS
[  FAILED  ] 
CgroupsAnyHierarchyMemoryPressureTest.ROOT_IncreasePageCache
[  FAILED  ] MemoryPressureMesosTest.CGROUPS_ROOT_Statistics
[  FAILED  ] MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery

11 FAILED TESTS
YOU HAVE 9 DISABLED TESTS


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources

Current test status:

  [==] 784 tests from 106 test cases ran. (135304 ms total)
  [  PASSED  ] 780 tests.
  [  FAILED  ] 4 tests, listed below:
  [  FAILED  ] ExamplesTest.TestFramework
  [  FAILED  ] ExamplesTest.NoExecutorFramework
  [  FAILED  ] ExamplesTest.EventCallFramework
  [  FAILED  ] ExamplesTest.PersistentVolumeFramework


Diffs (updated)
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
  src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
95b493c6f479eef52ee0c9a44ac40254ed76ebae 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
e3aea53468fa00374320a8b89bdbb64f38e44b01 
  src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation.

2016-01-15 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 15, 2016, 8:17 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Updated.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources

Current test status:

  [==] 784 tests from 106 test cases ran. (135304 ms total)
  [  PASSED  ] 780 tests.
  [  FAILED  ] 4 tests, listed below:
  [  FAILED  ] ExamplesTest.TestFramework
  [  FAILED  ] ExamplesTest.NoExecutorFramework
  [  FAILED  ] ExamplesTest.EventCallFramework
  [  FAILED  ] ExamplesTest.PersistentVolumeFramework


Diffs (updated)
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
  src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
95b493c6f479eef52ee0c9a44ac40254ed76ebae 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
e3aea53468fa00374320a8b89bdbb64f38e44b01 
  src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation

2016-01-15 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 16, 2016, 5:53 a.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Rebase and build fix.


Summary (updated)
-

Enable mesos tests installation


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description (updated)
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources


Diffs (updated)
-

  Makefile.am fbd4e5a6356e90c867ba47c48c86fc9161ddd98e 
  configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
  src/Makefile.am d23e35001078a86775bd9b76baa207ecb9dab7e1 
  src/tests/balloon_framework_test.sh 25a19cfde87a3fd2d7d3e780700d342d08bd0a91 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
677fcc1c654f83ad3e60e0f6172a1a1e4a1045b1 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
fab16f697f90abc11d681222f10f518d70da908b 
  src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
  src/tests/event_call_framework_test.sh 
9d1211552734afbf15b376f8c4629bae8a2065af 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 3606ce46bfa283ad0d5239fc25e02c5a9f8d1a53 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/no_executor_framework_test.sh 
aebdc8c380abb2d041d6fc74dfac5a111c15267e 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/persistent_volume_framework_test.sh 
84f02847a8d89400512d8a5714d33fb29cf5b03a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp 076660daf025d6fd5065cd0c1930f17ecc5ca5aa 
  src/tests/test_framework_test.sh 409e80994f63448115ea8ac34b4fd5c6cf88aa22 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 22bf3a85da5261fcfcc8b6aa9626aacdc8391ad4 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation.

2016-01-12 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 13, 2016, 4:06 a.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Summary (updated)
-

Enable mesos tests installation.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources

Current test status:

  [==] 784 tests from 106 test cases ran. (135304 ms total)
  [  PASSED  ] 780 tests.
  [  FAILED  ] 4 tests, listed below:
  [  FAILED  ] ExamplesTest.TestFramework
  [  FAILED  ] ExamplesTest.NoExecutorFramework
  [  FAILED  ] ExamplesTest.EventCallFramework
  [  FAILED  ] ExamplesTest.PersistentVolumeFramework


Diffs
-

  configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
  src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
95b493c6f479eef52ee0c9a44ac40254ed76ebae 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
e3aea53468fa00374320a8b89bdbb64f38e44b01 
  src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation

2016-01-12 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review114144
---


Bad patch!

Reviews applied: [39780, 39781, 39782, 40553]

Failed command: ./support/apply-review.sh -n -r 40553

Error:
 2016-01-13 04:01:31 URL:https://reviews.apache.org/r/40553/diff/raw/ 
[39100/39100] -> "40553.patch" [1]
Total errors found: 0
Checking 16 files
Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 12, 2016, 10:50 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Jan. 12, 2016, 10:50 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> Current test status:
> 
>   [==] 784 tests from 106 test cases ran. (135304 ms total)
>   [  PASSED  ] 780 tests.
>   [  FAILED  ] 4 tests, listed below:
>   [  FAILED  ] ExamplesTest.TestFramework
>   [  FAILED  ] ExamplesTest.NoExecutorFramework
>   [  FAILED  ] ExamplesTest.EventCallFramework
>   [  FAILED  ] ExamplesTest.PersistentVolumeFramework
> 
> 
> Diffs
> -
> 
>   configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
>   src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> 95b493c6f479eef52ee0c9a44ac40254ed76ebae 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> e3aea53468fa00374320a8b89bdbb64f38e44b01 
>   src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67 
>   src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
>   src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation

2016-01-12 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Jan. 12, 2016, 10:50 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Rebase onto master, fixing new test module additions.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources

Current test status:

  [==] 784 tests from 106 test cases ran. (135304 ms total)
  [  PASSED  ] 780 tests.
  [  FAILED  ] 4 tests, listed below:
  [  FAILED  ] ExamplesTest.TestFramework
  [  FAILED  ] ExamplesTest.NoExecutorFramework
  [  FAILED  ] ExamplesTest.EventCallFramework
  [  FAILED  ] ExamplesTest.PersistentVolumeFramework


Diffs (updated)
-

  configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
  src/Makefile.am 8cbfb1ba5fa49f2d3cc26ea325838a1c68a79660 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
95b493c6f479eef52ee0c9a44ac40254ed76ebae 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
e3aea53468fa00374320a8b89bdbb64f38e44b01 
  src/tests/environment.cpp 20218a086baefcefb310eb45ed9024e5425ce787 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 26d05e7f7db9306c8b9164e2e7f843793c909e67 
  src/tests/mesos.cpp 365ebe8335c37bfdb983a5424d4c995fa9b76a22 
  src/tests/module.cpp f0e64f7c462cf833839558665fdb60d9f2cbc475 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp e4fb490a1d877547fe883c22dbc47bb4969ecef6 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation

2015-12-17 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Dec. 17, 2015, 5:43 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Rebased onto master.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources

Current test status:

  [==] 784 tests from 106 test cases ran. (135304 ms total)
  [  PASSED  ] 780 tests.
  [  FAILED  ] 4 tests, listed below:
  [  FAILED  ] ExamplesTest.TestFramework
  [  FAILED  ] ExamplesTest.NoExecutorFramework
  [  FAILED  ] ExamplesTest.EventCallFramework
  [  FAILED  ] ExamplesTest.PersistentVolumeFramework


Diffs (updated)
-

  configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
  src/Makefile.am e6d48dc16135b5d147d036e851422686eff7d5ef 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
fe679354d04d68b68e168cd8c4eab23898f6532f 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 
  src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566 
  src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
  src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/oversubscription_tests.cpp 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp f19199344b8b542ebad1e59f4b97d8ca661aeb06 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation

2015-12-17 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review111076
---


Patch looks great!

Reviews applied: [39780, 39781, 39782, 40553]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 17, 2015, 5:43 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Dec. 17, 2015, 5:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> Current test status:
> 
>   [==] 784 tests from 106 test cases ran. (135304 ms total)
>   [  PASSED  ] 780 tests.
>   [  FAILED  ] 4 tests, listed below:
>   [  FAILED  ] ExamplesTest.TestFramework
>   [  FAILED  ] ExamplesTest.NoExecutorFramework
>   [  FAILED  ] ExamplesTest.EventCallFramework
>   [  FAILED  ] ExamplesTest.PersistentVolumeFramework
> 
> 
> Diffs
> -
> 
>   configure.ac 40d60a63cdba41d06305f09141f4d14d6e229d95 
>   src/Makefile.am e6d48dc16135b5d147d036e851422686eff7d5ef 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> fe679354d04d68b68e168cd8c4eab23898f6532f 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 
>   src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
>   src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
>   src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566 
>   src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
>   src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828 
>   src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
>   src/tests/oversubscription_tests.cpp 
> 7a75fb38e0177e33cf0e7cb82b4b9ebf8f05fe0a 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp f19199344b8b542ebad1e59f4b97d8ca661aeb06 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread James Peach



> On Dec. 10, 2015, 3:30 p.m., Till Toenshoff wrote:
> > src/tests/utils.cpp, lines 71-77
> > 
> >
> > I still don't understand why the oversubscription tests need to have 
> > this installed in the LIBDIR and not in MODULE_DIR folder. We need to find 
> > some proper reasoning here before making so much extra fuzz for this, I 
> > feel.

I made ``PKGMODULEDIR`` a first class installation directory and installed 
``lib_fixed_resource_estimator`` there (with compatibility symlinks). This let 
me clean up and remove ``getModuleDir``.


> On Dec. 10, 2015, 3:30 p.m., Till Toenshoff wrote:
> > configure.ac, line 330
> > 
> >
> > Could you please explain the [1] for the negative case?

The ```[1]``` is the argument to ```AC_DEFINE``` not to the ```AS_IF```. I'll 
split the line to make it clearer.


> On Dec. 10, 2015, 3:30 p.m., Till Toenshoff wrote:
> > src/tests/containerizer/memory_test_helper.cpp, line 187
> > 
> >
> > Can you explain briefly what you mean here by "too many dependencies" - 
> > seemed to me we only "drag" in "stout/json.hpp"?!

I took another look and I just need to link against 
``$(mesos_tests_DEPENDENCIES)``.


> On Dec. 10, 2015, 3:30 p.m., Till Toenshoff wrote:
> > src/tests/module_tests.cpp, lines 60-68
> > 
> >
> > Seems this could be covered by `getModulePath`, no?

Yeh I can use ``getModulePath`` here. I think I was trying to minimize the 
changes :)


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review107994
---


On Nov. 30, 2015, 6:43 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Nov. 30, 2015, 6:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> Current test status:
> 
>   [==] 784 tests from 106 test cases ran. (135304 ms total)
>   [  PASSED  ] 780 tests.
>   [  FAILED  ] 4 tests, listed below:
>   [  FAILED  ] ExamplesTest.TestFramework
>   [  FAILED  ] ExamplesTest.NoExecutorFramework
>   [  FAILED  ] ExamplesTest.EventCallFramework
>   [  FAILED  ] ExamplesTest.PersistentVolumeFramework
> 
> 
> Diffs
> -
> 
>   configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a 
>   src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> fe679354d04d68b68e168cd8c4eab23898f6532f 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 
>   src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
>   src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 
>   src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd 
>   src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828 
>   src/tests/module_tests.cpp b5cfbcd4885a4f2c20b19e00958fedda81afa6e0 
>   src/tests/oversubscription_tests.cpp 
> 0333281c247dd182860a49f39be791c00679bf6b 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
>

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Dec. 10, 2015, 9:28 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Changes
---

Rebased onto master (+ other review branches). Addressed review comments.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources

Current test status:

  [==] 784 tests from 106 test cases ran. (135304 ms total)
  [  PASSED  ] 780 tests.
  [  FAILED  ] 4 tests, listed below:
  [  FAILED  ] ExamplesTest.TestFramework
  [  FAILED  ] ExamplesTest.NoExecutorFramework
  [  FAILED  ] ExamplesTest.EventCallFramework
  [  FAILED  ] ExamplesTest.PersistentVolumeFramework


Diffs (updated)
-

  configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a 
  src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
fe679354d04d68b68e168cd8c4eab23898f6532f 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 
  src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
  src/tests/fetcher_tests.cpp 1831d896ca8a52bec4adf87a67b6af845079796c 
  src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566 
  src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 
  src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828 
  src/tests/module_tests.cpp a3271a3267647e0964dd3decb3ca8384417dd559 
  src/tests/oversubscription_tests.cpp 0333281c247dd182860a49f39be791c00679bf6b 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread Benjamin Bannier



> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/containerizer/memory_test_helper.cpp, line 197
> > 
> >
> > Should probably be passed as an arg (`bool` or even better an `enum` 
> > value). You can always pick a default.
> 
> James Peach wrote:
> I am not sure that I follow what you mean here. Are you suggesting that 
> the caller should specify where to search, based on the 
> ```MESOS_INSTALL_TESTS``` define? If so, I don't think the callers should 
> need to know that. The default needs to be consistent across a test run, 
> which implies that specific tests should not be toggling this in an ad-hoc 
> fashion.

Agreed, let's not open up the possibility of callers making this even more 
complicated.


> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/utils.hpp, line 38
> > 
> >
> > These functions cannot promise to return *valid* paths; they should 
> > probably all return `Try` instead. Please also check their impls.
> 
> James Peach wrote:
> Well they may return a valid path to something that doesn't exist, which 
> is fine and will cause the test to fail. It might be reasonable to return a 
> ```Try``` and change the callers to do ```findX().get()```, which would 
> ```ABORT``` at the call-site rather than some way into the test.

Looking at the call sites I agree that just `string`s might be good enough.


> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/utils.cpp, line 56
> > 
> >
> > All the `findX` functions here (but maybe `findModuleDir`) seem very 
> > easy to use incorrectly. We might e.g., depending on what is in our build 
> > directory or in the install prefix load a mix of different versions.
> > 
> > I would much prefer if we'd either load from one place or the other.
> > 
> > Going down that path would probably also lead us to remove a lot of the 
> > duplication here, by e.g., calling once into `findModuleDir` and building 
> > up the more specialized functions from there.
> 
> James Peach wrote:
> Yes, forcing a blanket policy is exactly why I needed the ```findX``` 
> family. There are only 2 scenarios that can cause inconsistent paths to tbe 
> used: (1) if you run the tests from an installation and do not specify 
> --build_dir=/none you could run tests from installed version A with helpers 
> from built version B, and (2) if you nuke some parts of the build directory 
> before running the tests.
> 
> I avoided forcing either one path or the other because it seemed 
> reasonable to run "make check" before installing. It would be simpler to 
> always force the tests to be installed before running in the 
> ```--enable-tests-install``` case if we could agree that "make check" would 
> fail in that case.
> 
> In general, I don't see these functions as easily composable. Some of 
> them happen to produce the same path string, but there's no real relationship 
> between the launcher directory and the test helper directory, for example.

Yes, I see.


> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/utils.cpp, line 64
> > 
> >
> > Here and in the following: I have the feeling explicitly passing in a 
> > flag (e.g., `bool searchInstallationDirectory`, or even clearer with an 
> > `enum` value) would make this easier to digest. All of these could have a 
> > default.
> 
> James Peach wrote:
> How would a test know whether to specify 
> ```searchInstallationDirectory```? A global command-line flag?

One could set the value of a static const bool variable in this TU depending on 
whether `MESOS_INSTALL_TESTS` was defined. The benefit would be that no matter 
whether it was there or not, any compile would check all branches in these 
functions (but very likely optimize away the dead branch).


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review107988
---


On Nov. 30, 2015, 6:43 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Nov. 30, 2015, 6:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to

Re: Review Request 40553: Enable mesos tests installation

2015-12-10 Thread Till Toenshoff


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review107994
---


Great work James, much appreciated.

And yes, it is tedious and hence the results appear unclean at the first glance 
here and there. I did play around a bit with the introduced helpers / getters, 
trying to streamline them but in the end could not come with something that had 
more beauty than your drafted solution.

There are a few  style nits in here, but I refrained from commenting on those 
in this early stage.


src/tests/utils.cpp (lines 71 - 77)


I still don't understand why the oversubscription tests need to have this 
installed in the LIBDIR and not in MODULE_DIR folder. We need to find some 
proper reasoning here before making so much extra fuzz for this, I feel.



configure.ac (line 330)


Could you please explain the [1] for the negative case?



src/tests/containerizer/memory_test_helper.cpp (line 187)


Can you explain briefly what you mean here by "too many dependencies" - 
seemed to me we only "drag" in "stout/json.hpp"?!



src/tests/containerizer/memory_test_helper.cpp (line 188)


`getTestHelper` ?



src/tests/module_tests.cpp (lines 60 - 68)


Seems this could be covered by `getModulePath`, no?


- Till Toenshoff


On Nov. 30, 2015, 6:43 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Nov. 30, 2015, 6:43 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> Current test status:
> 
>   [==] 784 tests from 106 test cases ran. (135304 ms total)
>   [  PASSED  ] 780 tests.
>   [  FAILED  ] 4 tests, listed below:
>   [  FAILED  ] ExamplesTest.TestFramework
>   [  FAILED  ] ExamplesTest.NoExecutorFramework
>   [  FAILED  ] ExamplesTest.EventCallFramework
>   [  FAILED  ] ExamplesTest.PersistentVolumeFramework
> 
> 
> Diffs
> -
> 
>   configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a 
>   src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 
>   src/tests/containerizer/launch_tests.cpp 
> c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
>   src/tests/containerizer/memory_test_helper.cpp 
> 4a3de2e3c887aa6afc604588850e1386f92d8c11 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> fe679354d04d68b68e168cd8c4eab23898f6532f 
>   src/tests/containerizer/ns_tests.cpp 
> 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 
>   src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
>   src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
>   src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 
>   src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd 
>   src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828 
>   src/tests/module_tests.cpp b5cfbcd4885a4f2c20b19e00958fedda81afa6e0 
>   src/tests/oversubscription_tests.cpp 
> 0333281c247dd182860a49f39be791c00679bf6b 
>   src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
>   src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
>   src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
>   src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation

2015-11-30 Thread James Peach

> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/Makefile.am, line 1753
> > 
> >
> > This would be a perfect opportunity to add a config header, and not 
> > pass any more strings as command line flags. Are we sure really we liked 
> > the approach taken previously with`SOURCE_DIR` and `BUILD_DIR`? OK if you 
> > disagree, not an issue.

I'd be happy to do that as a separate Jira, but I think that this change is 
intrusive enough already.

> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/utils.cpp, line 71
> > 
> >
> > Should this be a JIRA issue?

I don't know whether there is even supposed to be a module directory. I removed 
the XXX because this seems to be intentional.

> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/utils.hpp, line 38
> > 
> >
> > These functions cannot promise to return *valid* paths; they should 
> > probably all return `Try` instead. Please also check their impls.

Well they may return a valid path to something that doesn't exist, which is 
fine and will cause the test to fail. It might be reasonable to return a 
```Try``` and change the callers to do ```findX().get()```, which would 
```ABORT``` at the call-site rather than some way into the test.

> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/utils.hpp, line 37
> > 
> >
> > I think `getX` would be more in line with other places in the code base.

Agreed.

> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/containerizer/memory_test_helper.cpp, line 197
> > 
> >
> > Should probably be passed as an arg (`bool` or even better an `enum` 
> > value). You can always pick a default.

I am not sure that I follow what you mean here. Are you suggesting that the 
caller should specify where to search, based on the ```MESOS_INSTALL_TESTS``` 
define? If so, I don't think the callers should need to know that. The default 
needs to be consistent across a test run, which implies that specific tests 
should not be toggling this in an ad-hoc fashion.

> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/utils.cpp, line 56
> > 
> >
> > All the `findX` functions here (but maybe `findModuleDir`) seem very 
> > easy to use incorrectly. We might e.g., depending on what is in our build 
> > directory or in the install prefix load a mix of different versions.
> > 
> > I would much prefer if we'd either load from one place or the other.
> > 
> > Going down that path would probably also lead us to remove a lot of the 
> > duplication here, by e.g., calling once into `findModuleDir` and building 
> > up the more specialized functions from there.

Yes, forcing a blanket policy is exactly why I needed the ```findX``` family. 
There are only 2 scenarios that can cause inconsistent paths to tbe used: (1) 
if you run the tests from an installation and do not specify --build_dir=/none 
you could run tests from installed version A with helpers from built version B, 
and (2) if you nuke some parts of the build directory before running the tests.

I avoided forcing either one path or the other because it seemed reasonable to 
run "make check" before installing. It would be simpler to always force the 
tests to be installed before running in the ```--enable-tests-install``` case 
if we could agree that "make check" would fail in that case.

In general, I don't see these functions as easily composable. Some of them 
happen to produce the same path string, but there's no real relationship 
between the launcher directory and the test helper directory, for example.

> On Nov. 25, 2015, 2:36 p.m., Benjamin Bannier wrote:
> > src/tests/utils.cpp, line 64
> > 
> >
> > Here and in the following: I have the feeling explicitly passing in a 
> > flag (e.g., `bool searchInstallationDirectory`, or even clearer with an 
> > `enum` value) would make this easier to digest. All of these could have a 
> > default.

How would a test know whether to specify ```searchInstallationDirectory```? A 
global command-line flag?

- James

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review107988
---

On Nov. 25, 2015, 2:09 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated

Re: Review Request 40553: Enable mesos tests installation

2015-11-30 Thread James Peach


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/
---

(Updated Nov. 30, 2015, 6:43 p.m.)


Review request for mesos, Benjamin Bannier and Till Toenshoff.


Bugs: MESOS-3608
https://issues.apache.org/jira/browse/MESOS-3608


Repository: mesos


Description
---

This patch enables the installation mesos-tests and its dependencies
and helper tool. The goal is to allow operators to build a separate
test package that can be run at deployment time to verify that Mesos
works in the deployment environment.

Since the build directory is searched first, to run it on a host
that has a build tree, you need to specify a non-existent tree:

~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none

- Add --enable-tests-install
- Fix mesos-tests gmock dependencies
- Optionally install tests, helpers and test modules
- Add utility helpers to find various test resources

Current test status:

  [==] 784 tests from 106 test cases ran. (135304 ms total)
  [  PASSED  ] 780 tests.
  [  FAILED  ] 4 tests, listed below:
  [  FAILED  ] ExamplesTest.TestFramework
  [  FAILED  ] ExamplesTest.NoExecutorFramework
  [  FAILED  ] ExamplesTest.EventCallFramework
  [  FAILED  ] ExamplesTest.PersistentVolumeFramework


Diffs (updated)
-

  configure.ac b30a8d30076f3068fd7d5fc8ccea1982639e998a 
  src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04 
  src/tests/containerizer/launch_tests.cpp 
c7ebe2606e4ff99ced90342dd16e0b4bf02bc504 
  src/tests/containerizer/memory_test_helper.cpp 
4a3de2e3c887aa6afc604588850e1386f92d8c11 
  src/tests/containerizer/mesos_containerizer_tests.cpp 
fe679354d04d68b68e168cd8c4eab23898f6532f 
  src/tests/containerizer/ns_tests.cpp 603e54b7303c5aa15e2c5715dc7a2f7e7d39541b 
  src/tests/containerizer/port_mapping_tests.cpp 
9bcf05ec071b44156b57d8515f47ee6a8bbfdfa0 
  src/tests/environment.cpp 36f0ad0b739559e5c883d72585731944da4283cf 
  src/tests/fetcher_tests.cpp 99c494a2167ea9ec94e63d92980df17a4089f95a 
  src/tests/health_check_tests.cpp b1454b085b36bb7c4d8ef012c764cd8466b4fb02 
  src/tests/mesos.cpp a75182ec7f6d0c6063bbb36a6ccf4e8a4a81c8dd 
  src/tests/module.cpp e272bf0eccb61ae54440ec79adac8efad804c828 
  src/tests/module_tests.cpp b5cfbcd4885a4f2c20b19e00958fedda81afa6e0 
  src/tests/oversubscription_tests.cpp 0333281c247dd182860a49f39be791c00679bf6b 
  src/tests/script.cpp ee44fef29fb40e414d7507168091ee5cd0d15736 
  src/tests/slave_tests.cpp 4975bea8a7a701e0414426760692720f73dea7f5 
  src/tests/utils.hpp a6cca472f4dfab12cd6eccab6972206d842177aa 
  src/tests/utils.cpp 877139e97249761658dce3b1058cdc2e2a52367b 

Diff: https://reviews.apache.org/r/40553/diff/


Testing
---


Thanks,

James Peach

Re: Review Request 40553: Enable mesos tests installation

2015-11-25 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review107988
---

configure.ac (line 245)

Please use spaces for indention.

configure.ac (line 247)

Please set a default here. With that it e.g., becomes clearer what setting 
is actually used, e.g., from `./configure --help`.

src/Makefile.am (line 1744)

This would be a perfect opportunity to add a config header, and not pass 
any more strings as command line flags. Are we sure really we liked the 
approach taken previously with`SOURCE_DIR` and `BUILD_DIR`? OK if you disagree, 
not an issue.

src/tests/containerizer/memory_test_helper.cpp (line 197)

Should probably be passed as an arg (`bool` or even better an `enum` 
value). You can always pick a default.

src/tests/utils.hpp (line 37)

I think `getX` would be more in line with other places in the code base.

src/tests/utils.hpp (line 38)

These functions cannot promise to return *valid* paths; they should 
probably all return `Try` instead. Please also check their impls.

src/tests/utils.cpp (line 56)

All the `findX` functions here (but maybe `findModuleDir`) seem very easy 
to use incorrectly. We might e.g., depending on what is in our build directory 
or in the install prefix load a mix of different versions.

I would much prefer if we'd either load from one place or the other.

Going down that path would probably also lead us to remove a lot of the 
duplication here, by e.g., calling once into `findModuleDir` and building up 
the more specialized functions from there.

src/tests/utils.cpp (line 64)

Here and in the following: I have the feeling explicitly passing in a flag 
(e.g., `bool searchInstallationDirectory`, or even clearer with an `enum` 
value) would make this easier to digest. All of these could have a default.

src/tests/utils.cpp (line 71)

Should this be a JIRA issue?

src/tests/utils.cpp (line 91)

dito.

src/tests/utils.cpp (line 108)

dito.

src/tests/utils.cpp (line 125)

dito.

src/tests/utils.cpp (line 141)

dito.

- Benjamin Bannier

On Nov. 25, 2015, 2:09 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Nov. 25, 2015, 2:09 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> Current test status:
> 
>   [==] 784 tests from 106 test cases ran. (135304 ms total)
>   [  PASSED  ] 780 tests.
>   [  FAILED  ] 4 tests, listed below:
>   [  FAILED  ] ExamplesTest.TestFramework
>   [  FAILED  ] ExamplesTest.NoExecutorFramework
>   [  FAILED  ] ExamplesTest.EventCallFramework
>   [  FAILED  ] ExamplesTest.PersistentVolumeFramework
> 
> 
> Diffs
> -
> 
>   configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/tests/containerizer/launch_tests.cpp 
> bf6b7561bf9b5c06fd5d1101e2b2511776a12010 
>   src/tests/containerizer/memory_test_helper.cpp 
> 6abd29ba6f0d208a5f10f645977fec309334af0a 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> d1ff139b0674ea266a4d554de112094045add509 
>   src/tests/containerizer/ns_tests.cpp 
> ac3c9ff1767bd34d3257bb39effce789fae47252 
>

Re: Review Request 40553: Enable mesos tests installation

2015-11-20 Thread Mesos ReviewBot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40553/#review107429
---


Patch looks great!

Reviews applied: [39780, 39781, 39782, 40553]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Nov. 20, 2015, 6:53 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40553/
> ---
> 
> (Updated Nov. 20, 2015, 6:53 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-3608
> https://issues.apache.org/jira/browse/MESOS-3608
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch enables the installation mesos-tests and its dependencies
> and helper tool. The goal is to allow operators to build a separate
> test package that can be run at deployment time to verify that Mesos
> works in the deployment environment.
> 
> Since the build directory is searched first, to run it on a host
> that has a build tree, you need to specify a non-existent tree:
> 
> ~ $ $PREFIX/libexec/mesos/tests/mesos-tests --build_dir=/none
> 
> - Add --enable-tests-install
> - Fix mesos-tests gmock dependencies
> - Optionally install tests, helpers and test modules
> - Add utility helpers to find various test resources
> 
> Current test status:
> 
>   [==] 784 tests from 106 test cases ran. (135304 ms total)
>   [  PASSED  ] 780 tests.
>   [  FAILED  ] 4 tests, listed below:
>   [  FAILED  ] ExamplesTest.TestFramework
>   [  FAILED  ] ExamplesTest.NoExecutorFramework
>   [  FAILED  ] ExamplesTest.EventCallFramework
>   [  FAILED  ] ExamplesTest.PersistentVolumeFramework
> 
> 
> Diffs
> -
> 
>   configure.ac 8b28ac78eeb3e3b5905b411b4bc0db3ccf0f543f 
>   src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 
>   src/tests/containerizer/launch_tests.cpp 
> bf6b7561bf9b5c06fd5d1101e2b2511776a12010 
>   src/tests/containerizer/memory_test_helper.cpp 
> 6abd29ba6f0d208a5f10f645977fec309334af0a 
>   src/tests/containerizer/mesos_containerizer_tests.cpp 
> d1ff139b0674ea266a4d554de112094045add509 
>   src/tests/containerizer/ns_tests.cpp 
> ac3c9ff1767bd34d3257bb39effce789fae47252 
>   src/tests/containerizer/port_mapping_tests.cpp 
> 91953389f793755770ff957b675936521b0e338a 
>   src/tests/environment.cpp c07d9f037f81bce315df7c818131efcb0b186595 
>   src/tests/fetcher_tests.cpp 04079964b3539f555351d1444f3635c64700a1a8 
>   src/tests/health_check_tests.cpp ff6275b19206b49eacb6761f3aeb58dd87651ade 
>   src/tests/mesos.cpp 766a51cddc8801d5e79188f80e9ce0828598c8b9 
>   src/tests/module.cpp edab0b37dcf0bd8e15d439726354039c1bbcd51f 
>   src/tests/module_tests.cpp 28c71b0c1960bad4933f86d35fe8a0248fef326e 
>   src/tests/oversubscription_tests.cpp 
> 0d0bf7e0b9a4028ed116e00b56d59b670510c5ce 
>   src/tests/script.cpp c9b04e67ce8176798412c0c17e436bbc01a94d70 
>   src/tests/slave_tests.cpp 7c9dcc6186a8cccb0eb30ff59914a41961e47293 
>   src/tests/utils.hpp 1497013f43428269aa1e3c63e166c303af00483e 
>   src/tests/utils.cpp 0578e63bc46ea79b0508e656d0793710484b21ef 
> 
> Diff: https://reviews.apache.org/r/40553/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation.

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

Re: Review Request 40553: Enable mesos tests installation

35 matches

Site Navigation

Mail list logo

Footer information