Re: Review Request 40559: Added a wait() function to Subprocess.
> On Dec. 3, 2015, 10:34 p.m., Vinod Kone wrote: > > Ship It! There's some controversy regarding this patch. I'll move this logic to hdfs.cpp as a helper. Discard this patch for now. Will send a new one shortly. - Jie --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/#review108898 --- On Nov. 20, 2015, 9:06 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40559/ > --- > > (Updated Nov. 20, 2015, 9:06 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3035 > https://issues.apache.org/jira/browse/MESOS-3035 > > > Repository: mesos > > > Description > --- > > Added a wait() function to Subprocess. This is similar to > `Popen.communicate(None)` in python. See the example code below: > > ``` > Try s = subprocess(...); > if (s.isError()) { > ... > } > > return s.get().wait() > .then([](const Subprocess::Result& result) { > if (result.status.isNone()) { ... } > if (result.status.get() != 0) { ... } > > handle(result.out.get()); > handle(result.err.get()); > }); > ``` > > Relevant review: https://reviews.apache.org/r/37336/ > > > Diffs > - > > 3rdparty/libprocess/include/process/subprocess.hpp > f17816e813d5efce1d3bb1ff1e850eeda3ba > 3rdparty/libprocess/src/subprocess.cpp > e51f024e89594d84f1dfb7ee6f2e1d8fb33b4a08 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > ac600a551fb1a7782ff33cce204b7819497ef54a > > Diff: https://reviews.apache.org/r/40559/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 40559: Added a wait() function to Subprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/#review108898 --- Ship it! Ship It! - Vinod Kone On Nov. 20, 2015, 9:06 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40559/ > --- > > (Updated Nov. 20, 2015, 9:06 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3035 > https://issues.apache.org/jira/browse/MESOS-3035 > > > Repository: mesos > > > Description > --- > > Added a wait() function to Subprocess. This is similar to > `Popen.communicate(None)` in python. See the example code below: > > ``` > Try s = subprocess(...); > if (s.isError()) { > ... > } > > return s.get().wait() > .then([](const Subprocess::Result& result) { > if (result.status.isNone()) { ... } > if (result.status.get() != 0) { ... } > > handle(result.out.get()); > handle(result.err.get()); > }); > ``` > > Relevant review: https://reviews.apache.org/r/37336/ > > > Diffs > - > > 3rdparty/libprocess/include/process/subprocess.hpp > f17816e813d5efce1d3bb1ff1e850eeda3ba > 3rdparty/libprocess/src/subprocess.cpp > e51f024e89594d84f1dfb7ee6f2e1d8fb33b4a08 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > ac600a551fb1a7782ff33cce204b7819497ef54a > > Diff: https://reviews.apache.org/r/40559/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 40559: Added a wait() function to Subprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/#review107475 --- Patch looks great! Reviews applied: [40250, 40251, 40252, 40274, 40253, 40305, 40403, 40418, 40556, 40461, 40462, 40463, 40464, 40498, 40559] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Nov. 20, 2015, 9:06 p.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40559/ > --- > > (Updated Nov. 20, 2015, 9:06 p.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3035 > https://issues.apache.org/jira/browse/MESOS-3035 > > > Repository: mesos > > > Description > --- > > Added a wait() function to Subprocess. This is similar to > `Popen.communicate(None)` in python. See the example code below: > > ``` > Try s = subprocess(...); > if (s.isError()) { > ... > } > > return s.get().wait() > .then([](const Subprocess::Result& result) { > if (result.status.isNone()) { ... } > if (result.status.get() != 0) { ... } > > handle(result.out.get()); > handle(result.err.get()); > }); > ``` > > Relevant review: https://reviews.apache.org/r/37336/ > > > Diffs > - > > 3rdparty/libprocess/include/process/subprocess.hpp > f17816e813d5efce1d3bb1ff1e850eeda3ba > 3rdparty/libprocess/src/subprocess.cpp > e51f024e89594d84f1dfb7ee6f2e1d8fb33b4a08 > 3rdparty/libprocess/src/tests/subprocess_tests.cpp > ac600a551fb1a7782ff33cce204b7819497ef54a > > Diff: https://reviews.apache.org/r/40559/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jie Yu > >
Re: Review Request 40559: Added a wait() function to Subprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/ --- (Updated Nov. 20, 2015, 9:06 p.m.) Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3035 https://issues.apache.org/jira/browse/MESOS-3035 Repository: mesos Description (updated) --- Added a wait() function to Subprocess. This is similar to `Popen.communicate(None)` in python. See the example code below: ``` Try s = subprocess(...); if (s.isError()) { ... } return s.get().wait() .then([](const Subprocess::Result& result) { if (result.status.isNone()) { ... } if (result.status.get() != 0) { ... } handle(result.out.get()); handle(result.err.get()); }); ``` Relevant review: https://reviews.apache.org/r/37336/ Diffs - 3rdparty/libprocess/include/process/subprocess.hpp f17816e813d5efce1d3bb1ff1e850eeda3ba 3rdparty/libprocess/src/subprocess.cpp e51f024e89594d84f1dfb7ee6f2e1d8fb33b4a08 3rdparty/libprocess/src/tests/subprocess_tests.cpp ac600a551fb1a7782ff33cce204b7819497ef54a Diff: https://reviews.apache.org/r/40559/diff/ Testing --- make check Thanks, Jie Yu
Review Request 40559: Added a wait() function to Subprocess.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40559/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-3035 https://issues.apache.org/jira/browse/MESOS-3035 Repository: mesos Description --- Added a wait() function to Subprocess. See the example code below: ``` Try s = subprocess(...); if (s.isError()) { ... } return s.get().wait() .then([](const Subprocess::Result& result) { if (result.status.isNone()) { ... } if (result.status.get() != 0) { ... } handle(result.out.get()); handle(result.err.get()); }); ``` Relevant review: https://reviews.apache.org/r/37336/ Diffs - 3rdparty/libprocess/include/process/subprocess.hpp f17816e813d5efce1d3bb1ff1e850eeda3ba 3rdparty/libprocess/src/subprocess.cpp e51f024e89594d84f1dfb7ee6f2e1d8fb33b4a08 3rdparty/libprocess/src/tests/subprocess_tests.cpp ac600a551fb1a7782ff33cce204b7819497ef54a Diff: https://reviews.apache.org/r/40559/diff/ Testing --- make check Thanks, Jie Yu