Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

2016-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/#review121553
---


Fix it, then Ship it!





src/CMakeLists.txt (line 248)


Alphabetize.


- Joris Van Remoortere


On March 1, 2016, 11:58 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40620/
> ---
> 
> (Updated March 1, 2016, 11:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added suppport for `slave/monitor.cpp`.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 
> 
> Diff: https://reviews.apache.org/r/40620/diff/
> 
> 
> Testing
> ---
> 
> OSX: make
> Windows: make
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

2016-03-01 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
---

(Updated March 1, 2016, 11:58 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Added suppport for `slave/monitor.cpp`.


Diffs (updated)
-

  src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
---

OSX: make
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp`.

2016-01-13 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
---

(Updated Jan. 14, 2016, 1:15 a.m.)


Review request for Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun.


Summary (updated)
-

Windows: Added suppport for `slave/monitor.cpp`.


Repository: mesos


Description
---

Windows: Added suppport for `slave/monitor.cpp`.


Diffs
-

  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
---

OSX: make
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2016-01-13 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
---

(Updated Jan. 14, 2016, 1:13 a.m.)


Review request for Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Added suppport for `slave/monitor.cpp'.


Diffs (updated)
-

  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
---

OSX: make
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2016-01-13 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
---

(Updated Jan. 14, 2016, 1:14 a.m.)


Review request for Alex Naparu, Alex Clemmer, M Lawindi, and Yi Sun.


Repository: mesos


Description (updated)
---

Windows: Added suppport for `slave/monitor.cpp`.


Diffs
-

  src/CMakeLists.txt 39a23df3227a4f524ea0d408dc894fa5bbab7d10 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
---

OSX: make
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2015-12-22 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
---

(Updated Dec. 23, 2015, 7:22 a.m.)


Review request for Alex Naparu and Alex Clemmer.


Repository: mesos


Description
---

Windows: Added suppport for `slave/monitor.cpp'.


Diffs (updated)
-

  src/CMakeLists.txt 0d46043dd06007f2cba56626c82e8edd251cb8fb 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
---

OSX: make
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2015-12-01 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
---

(Updated Dec. 1, 2015, 9:02 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

Windows: Added suppport for `slave/monitor.cpp'.


Diffs (updated)
-

  src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
---

OSX: make
Windows: make


Thanks,

Daniel Pravat

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2015-12-01 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/#review108593
---


Patch looks great!

Reviews applied: [40114, 40620]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 1, 2015, 9:02 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40620/
> ---
> 
> (Updated Dec. 1, 2015, 9:02 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Added suppport for `slave/monitor.cpp'.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 
> 
> Diff: https://reviews.apache.org/r/40620/diff/
> 
> 
> Testing
> ---
> 
> OSX: make
> Windows: make
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 40620: Windows: Added suppport for `slave/monitor.cpp'.

2015-11-27 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40620/
---

(Updated Nov. 28, 2015, 7:24 a.m.)


Review request for mesos and Alex Clemmer.


Changes
---

Fixed the patch to eliminate unecessary dependency.


Repository: mesos


Description
---

Windows: Added suppport for `slave/monitor.cpp'.


Diffs (updated)
-

  src/CMakeLists.txt 9a2c70d40031c80a304462107758802c08411a49 

Diff: https://reviews.apache.org/r/40620/diff/


Testing
---

OSX: make
Windows: make


Thanks,

Daniel Pravat