Re: Review Request 40964: Quota: Ensured resources in `QuotaInfo` do not have non-default role.

2015-12-04 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40964/#review109008
---

Ship it!


Fixed in-line


src/master/quota_handler.cpp (line 97)


Let's not restrict this function to only `Quota request`s


- Joris Van Remoortere


On Dec. 4, 2015, 11:53 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40964/
> ---
> 
> (Updated Dec. 4, 2015, 11:53 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3965
> https://issues.apache.org/jira/browse/MESOS-3965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 5529ab1aa27c15f7047916644a2dd4a90b2e73cb 
>   src/master/quota.cpp e75abfc5bd39438483f5d65a2e62b57e7e8c8cf5 
>   src/master/quota_handler.cpp 76de7c44c2cbd16c5f76b1dc0a94f567e037bffe 
>   src/tests/master_quota_tests.cpp 7aa116fcf459fb05e832a22bbcd5d576529317c1 
> 
> Diff: https://reviews.apache.org/r/40964/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Re: Review Request 40964: Quota: Ensured resources in `QuotaInfo` do not have non-default role.

2015-12-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40964/#review108978
---


Patch looks great!

Reviews applied: [40964]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 4, 2015, 11:53 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40964/
> ---
> 
> (Updated Dec. 4, 2015, 11:53 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3965
> https://issues.apache.org/jira/browse/MESOS-3965
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   include/mesos/quota/quota.proto 5529ab1aa27c15f7047916644a2dd4a90b2e73cb 
>   src/master/quota.cpp e75abfc5bd39438483f5d65a2e62b57e7e8c8cf5 
>   src/master/quota_handler.cpp 76de7c44c2cbd16c5f76b1dc0a94f567e037bffe 
>   src/tests/master_quota_tests.cpp 7aa116fcf459fb05e832a22bbcd5d576529317c1 
> 
> Diff: https://reviews.apache.org/r/40964/diff/
> 
> 
> Testing
> ---
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Review Request 40964: Quota: Ensured resources in `QuotaInfo` do not have non-default role.

2015-12-04 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40964/
---

Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
Joseph Wu, and Qian Zhang.


Bugs: MESOS-3965
https://issues.apache.org/jira/browse/MESOS-3965


Repository: mesos


Description
---

See summary.


Diffs
-

  include/mesos/quota/quota.proto 5529ab1aa27c15f7047916644a2dd4a90b2e73cb 
  src/master/quota.cpp e75abfc5bd39438483f5d65a2e62b57e7e8c8cf5 
  src/master/quota_handler.cpp 76de7c44c2cbd16c5f76b1dc0a94f567e037bffe 
  src/tests/master_quota_tests.cpp 7aa116fcf459fb05e832a22bbcd5d576529317c1 

Diff: https://reviews.apache.org/r/40964/diff/


Testing
---

make check (Mac OS X 10.10.4)


Thanks,

Alexander Rukletsov