Re: Review Request 40987: Fix apply-reviews.py to work for first-time contributors.

2015-12-04 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40987/#review109046
---

Ship it!


Ship It!

- Vinod Kone


On Dec. 4, 2015, 9:30 p.m., Joseph Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40987/
> ---
> 
> (Updated Dec. 4, 2015, 9:30 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Vinod 
> Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> `apply-reviews.py` does `git commit --author 'NAME'`.  This only works for 
> contributors that have contributed before.
> 
> `apply-review.sh` does `git commit --author 'NAME '` which works for 
> first-time contributors too.
> 
> 
> Diffs
> -
> 
>   support/apply-reviews.py f6c05be77bcf963c5aa6036a4660296d390bd475 
> 
> Diff: https://reviews.apache.org/r/40987/diff/
> 
> 
> Testing
> ---
> 
> `support/apply-reviews.py -n -r 40951`
> 
> ^ Should not complain with:
> ```
> fatal: --author 'Diana Arroyo' is not 'Name ' and matches no existing 
> author
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>



Review Request 40987: Fix apply-reviews.py to work for first-time contributors.

2015-12-04 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40987/
---

Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Vinod 
Kone.


Repository: mesos


Description
---

`apply-reviews.py` does `git commit --author 'NAME'`.  This only works for 
contributors that have contributed before.

`apply-review.sh` does `git commit --author 'NAME '` which works for 
first-time contributors too.


Diffs
-

  support/apply-reviews.py f6c05be77bcf963c5aa6036a4660296d390bd475 

Diff: https://reviews.apache.org/r/40987/diff/


Testing
---

`support/apply-reviews.py -n -r 40951`

^ Should not complain with:
```
fatal: --author 'Diana Arroyo' is not 'Name ' and matches no existing 
author
```


Thanks,

Joseph Wu