Re: Review Request 41347: Added a TODO to remove a `friend class` declaration.

2015-12-22 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41347/#review111604
---

Ship it!


Ship It!

- Bernd Mathiske


On Dec. 14, 2015, 6:28 a.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41347/
> ---
> 
> (Updated Dec. 14, 2015, 6:28 a.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 
> 
> Diff: https://reviews.apache.org/r/41347/diff/
> 
> 
> Testing
> ---
> 
> Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41347: Added a TODO to remove a `friend class` declaration.

2015-12-21 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41347/#review111493
---

Ship it!


Ship It!

- Joris Van Remoortere


On Dec. 14, 2015, 2:28 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41347/
> ---
> 
> (Updated Dec. 14, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 
> 
> Diff: https://reviews.apache.org/r/41347/diff/
> 
> 
> Testing
> ---
> 
> Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Re: Review Request 41347: Added a TODO to remove a `friend class` declaration.

2015-12-14 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41347/#review110312
---


Patch looks great!

Reviews applied: [41347]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 14, 2015, 2:28 p.m., Alexander Rukletsov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41347/
> ---
> 
> (Updated Dec. 14, 2015, 2:28 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 
> 
> Diff: https://reviews.apache.org/r/41347/diff/
> 
> 
> Testing
> ---
> 
> Not a functional change.
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>



Review Request 41347: Added a TODO to remove a `friend class` declaration.

2015-12-14 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41347/
---

Review request for mesos, Joris Van Remoortere and Till Toenshoff.


Repository: mesos


Description
---

See summary.


Diffs
-

  src/master/master.hpp 9aa548aa6e159046c94e4ec96f631ea8b3bfd5d8 

Diff: https://reviews.apache.org/r/41347/diff/


Testing
---

Not a functional change.


Thanks,

Alexander Rukletsov