Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2016-01-15 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review114709
---



docs/fetcher.md (line 236)


s/in all/all in

I created a patch https://reviews.apache.org/r/42353/ here to fix this.


- Guangya Liu


On 十二月 24, 2015, 1:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated 十二月 24, 2015, 1:22 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2016-01-15 Thread Bernd Mathiske 


> On Jan. 13, 2016, 5:18 a.m., Joerg Schad wrote:
> > docs/fetcher.md, line 231
> > 
> >
> > does protocol here has the same limitation as below in line 241 
> > (socks4/socks5/http/https)?

Yes. I made that explicit now.


- Bernd


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review114194
---


On Dec. 24, 2015, 5:22 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 24, 2015, 5:22 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2016-01-13 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review114197
---



docs/fetcher.md (line 258)


s/check/check the


- Joerg Schad


On Dec. 24, 2015, 1:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 24, 2015, 1:22 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2016-01-13 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review114195
---

Ship it!


(after the issues in my previous review are fixed)


docs/fetcher.md (line 239)


s/is of the format/has the format:?


- Joerg Schad


On Dec. 24, 2015, 1:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 24, 2015, 1:22 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2016-01-13 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review114194
---



docs/fetcher.md (line 226)


s/mesos/Mesos (or otherwise consistent with the rest of the file)



docs/fetcher.md (line 231)


does protocol here has the same limitation as below in line 241 
(socks4/socks5/http/https)?



docs/fetcher.md (line 232)


s/uri/URI or consistent with the rest of the file...



docs/fetcher.md (line 260)


Any reason for two blank lines here?


- Joerg Schad


On Dec. 24, 2015, 1:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 24, 2015, 1:22 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-24 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review111858
---


Patch looks great!

Reviews applied: [41438]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 24, 2015, 1:22 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 24, 2015, 1:22 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-24 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/
---

(Updated Dec. 24, 2015, 1:22 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4130
https://issues.apache.org/jira/browse/MESOS-4130


Repository: mesos


Description
---

Added documentation on using network proxy for mesos fetcher


Diffs (updated)
-

  docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 

Diff: https://reviews.apache.org/r/41438/diff/


Testing
---

- Set `https_proxy=http://localhost:3128` (a local squid server) in 
`/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
with a `https://` uri, and through the following sysdig command I can see there 
is data exchanging between mesos-fetcher process and port 3128.

```
sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
```

- Stop the local squid server, try to restart the marathon task, the task would 
fail repeatly, from slave logs there are error messages that fetcher failed to 
fetch the uri.
```
Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 'b52179fd-8968-4
bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
```

- Restart the squid server, the task would start without a problem.


Thanks,

Shuai Lin

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-21 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review111467
---

Ship it!



docs/fetcher.md (line 243)


(s/goes/go/, but actually, I'd prefer:)

s/also goes over/with a proxy also make use of an/


- Bernd Mathiske


On Dec. 18, 2015, 5:45 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 18, 2015, 5:45 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec73722 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review111217
---


Patch looks great!

Reviews applied: [41438]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 18, 2015, 1:45 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 18, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec73722 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/
---

(Updated Dec. 18, 2015, 1:45 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4130
https://issues.apache.org/jira/browse/MESOS-4130


Repository: mesos


Description
---

Added documentation on using network proxy for mesos fetcher


Diffs (updated)
-

  docs/fetcher.md ec73722 

Diff: https://reviews.apache.org/r/41438/diff/


Testing
---

- Set `https_proxy=http://localhost:3128` (a local squid server) in 
`/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
with a `https://` uri, and through the following sysdig command I can see there 
is data exchanging between mesos-fetcher process and port 3128.

```
sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
```

- Stop the local squid server, try to restart the marathon task, the task would 
fail repeatly, from slave logs there are error messages that fetcher failed to 
fetch the uri.
```
Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 'b52179fd-8968-4
bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
```

- Restart the squid server, the task would start without a problem.


Thanks,

Shuai Lin

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Shuai Lin 


> On Dec. 17, 2015, 11:12 a.m., Bernd Mathiske wrote:
> > docs/fetcher.md, line 244
> > 
> >
> > Did you not have to write "export" in front?
> > I know of a case where nothing worked unless you did.

It works with or without the `export` on my machine. I'll add it in the doc 
since there is no harm.


- Shuai


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review110932
---


On Dec. 18, 2015, 1:43 p.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 18, 2015, 1:43 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec73722 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-18 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/
---

(Updated Dec. 18, 2015, 1:43 p.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4130
https://issues.apache.org/jira/browse/MESOS-4130


Repository: mesos


Description
---

Added documentation on using network proxy for mesos fetcher


Diffs (updated)
-

  docs/fetcher.md ec73722 

Diff: https://reviews.apache.org/r/41438/diff/


Testing
---

- Set `https_proxy=http://localhost:3128` (a local squid server) in 
`/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
with a `https://` uri, and through the following sysdig command I can see there 
is data exchanging between mesos-fetcher process and port 3128.

```
sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
```

- Stop the local squid server, try to restart the marathon task, the task would 
fail repeatly, from slave logs there are error messages that fetcher failed to 
fetch the uri.
```
Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 'b52179fd-8968-4
bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
```

- Restart the squid server, the task would start without a problem.


Thanks,

Shuai Lin

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-17 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review110732
---


Patch looks great!

Reviews applied: [41438]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 16, 2015, 8:27 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 16, 2015, 8:27 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-17 Thread Bernd Mathiske 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/#review110932
---



docs/fetcher.md (line 224)


s/a/an

How about this title?

"HTTP and SOCKS proxy settings"



docs/fetcher.md (lines 225 - 226)


s/it's/it is



docs/fetcher.md (line 229)


Since multiple protocols may be addressed, would plural read better here? 
"when certain environment variables are set."

(Otherwise, an "a" is missing before "certain".)



docs/fetcher.md (line 231)


s/The/The respective

This may make it even more clear that this is a variable per scheme



docs/fetcher.md (line 232)


s/uri/URI

BTW: You can end the sentence after this word and start a new one.



docs/fetcher.md (line 239)


We should point out that FTP/FTPS also go over HTTP/HTTPS proxies. Even 
though in general this  constrains the available FTP protocol operations, 
everything the fetcher uses is supported.



docs/fetcher.md (line 241)


Suggestion: "Your proxy settings can be placed in `...`. Here is an 
example:"



docs/fetcher.md (line 244)


Did you not have to write "export" in front?
I know of a case where nothing worked unless you did.



docs/fetcher.md (line 248)


Suggestion (less uncertain than "would" and less colloquial than "get"): 

The fetcher will pick up these environment variable settings since the 
utility program mesos-fetcher which it employs is a child of mesos-slave.


- Bernd Mathiske


On Dec. 16, 2015, 12:27 a.m., Shuai Lin wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41438/
> ---
> 
> (Updated Dec. 16, 2015, 12:27 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: MESOS-4130
> https://issues.apache.org/jira/browse/MESOS-4130
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added documentation on using network proxy for mesos fetcher
> 
> 
> Diffs
> -
> 
>   docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 
> 
> Diff: https://reviews.apache.org/r/41438/diff/
> 
> 
> Testing
> ---
> 
> - Set `https_proxy=http://localhost:3128` (a local squid server) in 
> `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
> with a `https://` uri, and through the following sysdig command I can see 
> there is data exchanging between mesos-fetcher process and port 3128.
> 
> ```
> sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
> ```
> 
> - Stop the local squid server, try to restart the marathon task, the task 
> would fail repeatly, from slave logs there are error messages that fetcher 
> failed to fetch the uri.
> ```
> Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
> slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
> 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 
> 'b52179fd-8968-4
> bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
> container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
> ```
> 
> - Restart the squid server, the task would start without a problem.
> 
> 
> Thanks,
> 
> Shuai Lin
> 
>

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-16 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/
---

(Updated Dec. 16, 2015, 8:27 a.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4130
https://issues.apache.org/jira/browse/MESOS-4130


Repository: mesos


Description
---

Added documentation on using network proxy for mesos fetcher


Diffs
-

  docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 

Diff: https://reviews.apache.org/r/41438/diff/


Testing (updated)
---

- Set `https_proxy=http://localhost:3128` (a local squid server) in 
`/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
with a `https://` uri, and through the following sysdig command I can see there 
is data exchanging between mesos-fetcher process and port 3128.

```
sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
```

- Stop the local squid server, try to restart the marathon task, the task would 
fail repeatly, from slave logs there are error messages that fetcher failed to 
fetch the uri.
```
Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 'b52179fd-8968-4
bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
```

- Restart the squid server, the task would start without a problem.


Thanks,

Shuai Lin

Re: Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-16 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/
---

(Updated Dec. 16, 2015, 8:25 a.m.)


Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4130
https://issues.apache.org/jira/browse/MESOS-4130


Repository: mesos


Description
---

Added documentation on using network proxy for mesos fetcher


Diffs
-

  docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 

Diff: https://reviews.apache.org/r/41438/diff/


Testing (updated)
---

- Set `https_proxy=http://localhost:3128` (a local squid server) in 
`/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task 
with a `https://` uri, and through the following sysdig command I can see there 
is data exchanging between mesos-fetcher process and port 3128.

```
sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128
```

- Stop the local squid server, try to restart the marathon task, the task would 
fail repeatly, from slave logs there are error messages that fetcher failed to 
fetch the uri.
```
Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 
slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor 
'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework 'b52179fd-8968-4
bf8-baf0-dddc8a38c903-' failed to start: Failed to fetch all URIs for 
container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2
```


Thanks,

Shuai Lin

Review Request 41438: Added documentation on using network proxy for mesos fetcher

2015-12-16 Thread Shuai Lin 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41438/
---

Review request for mesos and Bernd Mathiske.


Bugs: MESOS-4130
https://issues.apache.org/jira/browse/MESOS-4130


Repository: mesos


Description
---

Added documentation on using network proxy for mesos fetcher


Diffs
-

  docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 

Diff: https://reviews.apache.org/r/41438/diff/


Testing
---


Thanks,

Shuai Lin