Re: Review Request 41513: Cleaned up STL I/O includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/#review112536 --- Ship it! Ship It! - Michael Park On Dec. 22, 2015, 5:59 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41513/ > --- > > (Updated Dec. 22, 2015, 5:59 p.m.) > > > Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael > Park. > > > Bugs: MESOS-4183 > https://issues.apache.org/jira/browse/MESOS-4183 > > > Repository: mesos > > > Description > --- > > Move `operator<<` definitions to ".cpp" files and include `` > in ".hpp"s. > > > Diffs > - > > src/linux/perf.cpp 8ee9f381c3587bb2fa0f309a477035340bc44e15 > src/linux/routing/filter/ip.hpp 1a63dcca2badc041e73fe454a9994b82695117de > src/linux/routing/filter/ip.cpp 158bab6cb95fe10b8dc41b22934a946b21ff88ed > src/linux/routing/handle.hpp 5b03be5e70ad3910487a1867fa4fa0d8de25d11e > src/linux/routing/handle.cpp e88c6eb7336ac31683a6ff394a139f6777576a3e > src/messages/messages.hpp 350118399927a8d7185d87a6a8e3370b7158fe14 > src/messages/messages.cpp 30f55bb8ee5a57ff9517144ffc43d45df6b3de5b > > Diff: https://reviews.apache.org/r/41513/diff/ > > > Testing > --- > > make check on Mac OS 10.10.4. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 41513: Cleaned up STL I/O includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/#review111635 --- Patch looks great! Reviews applied: [41509, 41510, 41511, 41512, 41513] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 22, 2015, 5:59 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41513/ > --- > > (Updated Dec. 22, 2015, 5:59 p.m.) > > > Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael > Park. > > > Bugs: MESOS-4183 > https://issues.apache.org/jira/browse/MESOS-4183 > > > Repository: mesos > > > Description > --- > > Move `operator<<` definitions to ".cpp" files and include `` > in ".hpp"s. > > > Diffs > - > > src/linux/perf.cpp 8ee9f381c3587bb2fa0f309a477035340bc44e15 > src/linux/routing/filter/ip.hpp 1a63dcca2badc041e73fe454a9994b82695117de > src/linux/routing/filter/ip.cpp 158bab6cb95fe10b8dc41b22934a946b21ff88ed > src/linux/routing/handle.hpp 5b03be5e70ad3910487a1867fa4fa0d8de25d11e > src/linux/routing/handle.cpp e88c6eb7336ac31683a6ff394a139f6777576a3e > src/messages/messages.hpp 350118399927a8d7185d87a6a8e3370b7158fe14 > src/messages/messages.cpp 30f55bb8ee5a57ff9517144ffc43d45df6b3de5b > > Diff: https://reviews.apache.org/r/41513/diff/ > > > Testing > --- > > make check on Mac OS 10.10.4. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 41513: Cleaned up STL I/O includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/ --- (Updated Dec. 22, 2015, 5:59 p.m.) Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael Park. Changes --- Rebased & wrapped description. Bugs: MESOS-4183 https://issues.apache.org/jira/browse/MESOS-4183 Repository: mesos Description (updated) --- Move `operator<<` definitions to ".cpp" files and include `` in ".hpp"s. Diffs (updated) - src/linux/perf.cpp 8ee9f381c3587bb2fa0f309a477035340bc44e15 src/linux/routing/filter/ip.hpp 1a63dcca2badc041e73fe454a9994b82695117de src/linux/routing/filter/ip.cpp 158bab6cb95fe10b8dc41b22934a946b21ff88ed src/linux/routing/handle.hpp 5b03be5e70ad3910487a1867fa4fa0d8de25d11e src/linux/routing/handle.cpp e88c6eb7336ac31683a6ff394a139f6777576a3e src/messages/messages.hpp 350118399927a8d7185d87a6a8e3370b7158fe14 src/messages/messages.cpp 30f55bb8ee5a57ff9517144ffc43d45df6b3de5b Diff: https://reviews.apache.org/r/41513/diff/ Testing --- make check on Mac OS 10.10.4. Thanks, Alexander Rukletsov
Re: Review Request 41513: Cleaned up STL I/O includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/#review84 --- Ship it! - Benjamin Bannier On Dec. 17, 2015, 2:38 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41513/ > --- > > (Updated Dec. 17, 2015, 2:38 p.m.) > > > Review request for mesos, Benjamin Bannier, Joris Van Remoortere, and Michael > Park. > > > Bugs: MESOS-4183 > https://issues.apache.org/jira/browse/MESOS-4183 > > > Repository: mesos > > > Description > --- > > Move `operator<<` definitions to ".cpp" files and include `` in > ".hpp"s. > > > Diffs > - > > src/linux/perf.cpp 8ee9f381c3587bb2fa0f309a477035340bc44e15 > src/linux/routing/filter/ip.hpp 1a63dcca2badc041e73fe454a9994b82695117de > src/linux/routing/filter/ip.cpp 158bab6cb95fe10b8dc41b22934a946b21ff88ed > src/linux/routing/handle.hpp 5b03be5e70ad3910487a1867fa4fa0d8de25d11e > src/linux/routing/handle.cpp e88c6eb7336ac31683a6ff394a139f6777576a3e > src/messages/messages.hpp 350118399927a8d7185d87a6a8e3370b7158fe14 > src/messages/messages.cpp 30f55bb8ee5a57ff9517144ffc43d45df6b3de5b > > Diff: https://reviews.apache.org/r/41513/diff/ > > > Testing > --- > > make check on Mac OS 10.10.4. > > > Thanks, > > Alexander Rukletsov > >
Review Request 41513: Cleaned up STL I/O includes.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41513/ --- Review request for mesos. Bugs: MESOS-4183 https://issues.apache.org/jira/browse/MESOS-4183 Repository: mesos Description --- Move `operator<<` definitions to ".cpp" files and include `` in ".hpp"s. Diffs - src/linux/perf.cpp 8ee9f381c3587bb2fa0f309a477035340bc44e15 src/linux/routing/filter/ip.hpp 1a63dcca2badc041e73fe454a9994b82695117de src/linux/routing/filter/ip.cpp 158bab6cb95fe10b8dc41b22934a946b21ff88ed src/linux/routing/handle.hpp 5b03be5e70ad3910487a1867fa4fa0d8de25d11e src/linux/routing/handle.cpp e88c6eb7336ac31683a6ff394a139f6777576a3e src/messages/messages.hpp 350118399927a8d7185d87a6a8e3370b7158fe14 src/messages/messages.cpp 30f55bb8ee5a57ff9517144ffc43d45df6b3de5b Diff: https://reviews.apache.org/r/41513/diff/ Testing --- make check on Mac OS 10.10.4. Thanks, Alexander Rukletsov
