Re: Review Request 41604: CMake: Added missing protobuf files to CMake build.

2016-01-04 Thread Alex Naparu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41604/#review112623
---

Ship it!


Ship It!

- Alex Naparu


On Dec. 23, 2015, 6:52 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41604/
> ---
> 
> (Updated Dec. 23, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Diana Arroyo, Daniel Pravat, Artem 
> Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added missing protobuf files to CMake build.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt bdc45ae604c940dadc27ab6e8b8a3327bd00642b 
> 
> Diff: https://reviews.apache.org/r/41604/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 41604: CMake: Added missing protobuf files to CMake build.

2015-12-28 Thread Daniel Pravat

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41604/#review112019
---

Ship it!


Ship It!

- Daniel Pravat


On Dec. 23, 2015, 6:52 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41604/
> ---
> 
> (Updated Dec. 23, 2015, 6:52 a.m.)
> 
> 
> Review request for mesos, Alex Naparu, Diana Arroyo, Daniel Pravat, Artem 
> Harutyunyan, Joris Van Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added missing protobuf files to CMake build.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt bdc45ae604c940dadc27ab6e8b8a3327bd00642b 
> 
> Diff: https://reviews.apache.org/r/41604/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 41604: CMake: Added missing protobuf files to CMake build.

2015-12-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41604/#review111514
---


Patch looks great!

Reviews applied: [41604]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 21, 2015, 12:27 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41604/
> ---
> 
> (Updated Dec. 21, 2015, 12:27 p.m.)
> 
> 
> Review request for mesos, Diana Arroyo, Artem Harutyunyan, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Added missing protobuf files to CMake build.
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt bdc45ae604c940dadc27ab6e8b8a3327bd00642b 
> 
> Diff: https://reviews.apache.org/r/41604/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Review Request 41604: CMake: Added missing protobuf files to CMake build.

2015-12-21 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41604/
---

Review request for mesos, Diana Arroyo, Artem Harutyunyan, Joris Van 
Remoortere, and Joseph Wu.


Repository: mesos


Description
---

CMake: Added missing protobuf files to CMake build.


Diffs
-

  src/CMakeLists.txt bdc45ae604c940dadc27ab6e8b8a3327bd00642b 

Diff: https://reviews.apache.org/r/41604/diff/


Testing
---


Thanks,

Alex Clemmer