Re: Review Request 41616: Proto buf definition for GPUInfo. This is defined to introduce GPU as first class resource within Mesos.

2016-07-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41616/#review141514
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Dec. 21, 2015, 9:27 p.m., Vikrama Ditya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41616/
> ---
> 
> (Updated Dec. 21, 2015, 9:27 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-4232
> https://issues.apache.org/jira/browse/MESOS-4232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Proto buf definition for GPUInfo. This is defined to introduce GPU as first 
> class resource within Mesos.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
>   include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
> 
> Diff: https://reviews.apache.org/r/41616/diff/
> 
> 
> Testing
> ---
> 
> make and make check succceed.
> 
> 
> Thanks,
> 
> Vikrama Ditya
> 
>



Re: Review Request 41616: Proto buf definition for GPUInfo. This is defined to introduce GPU as first class resource within Mesos.

2015-12-21 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41616/#review111557
---


Patch looks great!

Reviews applied: [41616]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 21, 2015, 9:27 p.m., Vikrama Ditya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41616/
> ---
> 
> (Updated Dec. 21, 2015, 9:27 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4232
> https://issues.apache.org/jira/browse/MESOS-4232
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Proto buf definition for GPUInfo. This is defined to introduce GPU as first 
> class resource within Mesos.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
>   include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 
> 
> Diff: https://reviews.apache.org/r/41616/diff/
> 
> 
> Testing
> ---
> 
> make and make check succceed.
> 
> 
> Thanks,
> 
> Vikrama Ditya
> 
>



Review Request 41616: Proto buf definition for GPUInfo. This is defined to introduce GPU as first class resource within Mesos.

2015-12-21 Thread Vikrama Ditya

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41616/
---

Review request for mesos and Ben Mahler.


Bugs: MESOS-4232
https://issues.apache.org/jira/browse/MESOS-4232


Repository: mesos


Description
---

Proto buf definition for GPUInfo. This is defined to introduce GPU as first 
class resource within Mesos.


Diffs
-

  include/mesos/mesos.proto 2431fdd6b84625c6140a2b3913736bffada4e7f6 
  include/mesos/v1/mesos.proto 4aed0980b28dc1000aa2821f35303b736bc5bff8 

Diff: https://reviews.apache.org/r/41616/diff/


Testing
---

make and make check succceed.


Thanks,

Vikrama Ditya