Re: Review Request 42156: Refactored up the common image creation in appc tests.

2016-02-08 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42156/#review118296
---


Ship it!




Ship It!

- Jie Yu


On Feb. 6, 2016, 1:35 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42156/
> ---
> 
> (Updated Feb. 6, 2016, 1:35 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change will enable other tests to reuse the common test image creation
> logic.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> 012dba4e24b9a94dc8da0d329baf4bec2d33ffca 
> 
> Diff: https://reviews.apache.org/r/42156/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42156: Refactored up the common image creation in appc tests.

2016-02-05 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42156/#review118096
---




src/tests/containerizer/provisioner_appc_tests.cpp (line 55)


Can you add a TODO to move AppcSpecTest to a separate test file 
(appc_spec_tests.cpp) like we did for docker.



src/tests/containerizer/provisioner_appc_tests.cpp (line 127)


s/baseDirectory/storeDir/

s/prepareSimpleImageDirectory/createTestImage/

Please also add a comment about what this method is doing? What it is 
returning?



src/tests/containerizer/provisioner_appc_tests.cpp (line 129)


No need to do this check. os::mkdir will be a no-op if the directory 
already exists.



src/tests/containerizer/provisioner_appc_tests.cpp (line 177)


Could you please use paths::getImagePath here instead?



src/tests/containerizer/provisioner_appc_tests.cpp (lines 179 - 180)


THis is not 'Rootfs' dir, right?

Can you do the following:
1) create rootfs dir (spec::getImageRootfsPath)
2) create tmp under rootfs
3) create the test file



src/tests/containerizer/provisioner_appc_tests.cpp (lines 193 - 194)


Please use spec::getImageManifestPath


- Jie Yu


On Jan. 22, 2016, 6:47 a.m., Jojy Varghese wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42156/
> ---
> 
> (Updated Jan. 22, 2016, 6:47 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This change will enable other tests to reuse the common test image creation
> logic.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/provisioner_appc_tests.cpp 
> e3d08d9e49df93d5290099c8bfd917f60c93e51b 
> 
> Diff: https://reviews.apache.org/r/42156/diff/
> 
> 
> Testing
> ---
> 
> make check.
> 
> 
> Thanks,
> 
> Jojy Varghese
> 
>

Re: Review Request 42156: Refactored up the common image creation in appc tests.

2016-02-05 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42156/
---

(Updated Feb. 6, 2016, 1:35 a.m.)


Review request for mesos and Jie Yu.


Changes
---

review addressed.


Repository: mesos


Description
---

This change will enable other tests to reuse the common test image creation
logic.


Diffs (updated)
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
012dba4e24b9a94dc8da0d329baf4bec2d33ffca 

Diff: https://reviews.apache.org/r/42156/diff/


Testing
---

make check.


Thanks,

Jojy Varghese

Review Request 42156: Refactored up the common image creation in appc tests.

2016-01-11 Thread Jojy Varghese 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42156/
---

Review request for mesos and Jie Yu.


Repository: mesos


Description
---

This change will enable other tests to reuse the common test image creation
logic.


Diffs
-

  src/tests/containerizer/provisioner_appc_tests.cpp 
98d5a46149ef63cedcbf4915b5b6e9842ac67dbb 

Diff: https://reviews.apache.org/r/42156/diff/


Testing
---

make check.


Thanks,

Jojy Varghese