Review Request 42209: Updated getting started page to install Java on OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/ --- Review request for mesos, Ben Mahler and Kevin Klues. Repository: mesos Description --- Found this issue when following the getting started instructions on my new mac that came with el capitan. Diffs - docs/getting-started.md 0982d9038d87cec6eaa72b5584e0877fc2b9f04c Diff: https://reviews.apache.org/r/42209/diff/ Testing --- checked the markdown locally. Thanks, Vinod Kone
Re: Review Request 42209: Updated getting started page to install Java on OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114075 --- Can you veirfy that this doesn't break things for Yosemite? - Kevin Klues On Jan. 12, 2016, 9:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42209/ > --- > > (Updated Jan. 12, 2016, 9:38 p.m.) > > > Review request for mesos, Ben Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Found this issue when following the getting started instructions on my new > mac that came with el capitan. > > > Diffs > - > > docs/getting-started.md 0982d9038d87cec6eaa72b5584e0877fc2b9f04c > > Diff: https://reviews.apache.org/r/42209/diff/ > > > Testing > --- > > checked the markdown locally. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42209: Updated getting started page to install Java on OSX.
> On Jan. 12, 2016, 10:04 p.m., Kevin Klues wrote: > > Can you veirfy that this doesn't break things for Yosemite? I don't have yosemite handy to test it :) but from looking online it looks like cask and caskroom have existed for a while, pre-yosemite. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114075 --- On Jan. 12, 2016, 9:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42209/ > --- > > (Updated Jan. 12, 2016, 9:38 p.m.) > > > Review request for mesos, Ben Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Found this issue when following the getting started instructions on my new > mac that came with el capitan. > > > Diffs > - > > docs/getting-started.md 0982d9038d87cec6eaa72b5584e0877fc2b9f04c > > Diff: https://reviews.apache.org/r/42209/diff/ > > > Testing > --- > > checked the markdown locally. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42209: Updated getting started page to install Java on OSX.
> On Jan. 12, 2016, 2:04 p.m., Kevin Klues wrote: > > Can you veirfy that this doesn't break things for Yosemite? > > Vinod Kone wrote: > I don't have yosemite handy to test it :) but from looking online it > looks like cask and caskroom have existed for a while, pre-yosemite. Maybe just add a "NOTE: For El Capitan...". The command runs just fine on Yosemite though. - Joseph --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114075 --- On Jan. 12, 2016, 1:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42209/ > --- > > (Updated Jan. 12, 2016, 1:38 p.m.) > > > Review request for mesos, Ben Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Found this issue when following the getting started instructions on my new > mac that came with el capitan. > > > Diffs > - > > docs/getting-started.md 0982d9038d87cec6eaa72b5584e0877fc2b9f04c > > Diff: https://reviews.apache.org/r/42209/diff/ > > > Testing > --- > > checked the markdown locally. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42209: Updated getting started page to install Java on OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114142 --- Patch looks great! Reviews applied: [42209] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 12, 2016, 9:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42209/ > --- > > (Updated Jan. 12, 2016, 9:38 p.m.) > > > Review request for mesos, Ben Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Found this issue when following the getting started instructions on my new > mac that came with el capitan. > > > Diffs > - > > docs/getting-started.md 0982d9038d87cec6eaa72b5584e0877fc2b9f04c > > Diff: https://reviews.apache.org/r/42209/diff/ > > > Testing > --- > > checked the markdown locally. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42209: Updated getting started page to install Java on OSX.
> On Jan. 12, 2016, 10:04 p.m., Kevin Klues wrote: > > Can you veirfy that this doesn't break things for Yosemite? > > Vinod Kone wrote: > I don't have yosemite handy to test it :) but from looking online it > looks like cask and caskroom have existed for a while, pre-yosemite. > > Joseph Wu wrote: > Maybe just add a "NOTE: For El Capitan...". > The command runs just fine on Yosemite though. I think so long as it works for Yosemite then we should add it without a comment since it really is a hard dependency and Yosemite doesn't come preinstalled with java either. - Kevin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114075 --- On Jan. 12, 2016, 9:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42209/ > --- > > (Updated Jan. 12, 2016, 9:38 p.m.) > > > Review request for mesos, Ben Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Found this issue when following the getting started instructions on my new > mac that came with el capitan. > > > Diffs > - > > docs/getting-started.md 0982d9038d87cec6eaa72b5584e0877fc2b9f04c > > Diff: https://reviews.apache.org/r/42209/diff/ > > > Testing > --- > > checked the markdown locally. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42209: Updated getting started page to install Java on OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114183 --- Ship it! Ship It! - Kevin Klues On Jan. 12, 2016, 9:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42209/ > --- > > (Updated Jan. 12, 2016, 9:38 p.m.) > > > Review request for mesos, Ben Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Found this issue when following the getting started instructions on my new > mac that came with el capitan. > > > Diffs > - > > docs/getting-started.md 0982d9038d87cec6eaa72b5584e0877fc2b9f04c > > Diff: https://reviews.apache.org/r/42209/diff/ > > > Testing > --- > > checked the markdown locally. > > > Thanks, > > Vinod Kone > >
Re: Review Request 42209: Updated getting started page to install Java on OSX.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42209/#review114235 --- Ship it! Ship It! - Joseph Wu On Jan. 12, 2016, 1:38 p.m., Vinod Kone wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42209/ > --- > > (Updated Jan. 12, 2016, 1:38 p.m.) > > > Review request for mesos, Ben Mahler and Kevin Klues. > > > Repository: mesos > > > Description > --- > > Found this issue when following the getting started instructions on my new > mac that came with el capitan. > > > Diffs > - > > docs/getting-started.md 0982d9038d87cec6eaa72b5584e0877fc2b9f04c > > Diff: https://reviews.apache.org/r/42209/diff/ > > > Testing > --- > > checked the markdown locally. > > > Thanks, > > Vinod Kone > >
