Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-25 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review116274
---


Ship it!




Ship It!

- Guangya Liu


On 一月 26, 2016, 1:16 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> ---
> 
> (Updated 一月 26, 2016, 1:16 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
> https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker container REST API /monitor/statistics.json output have no timestamp 
> field, in docker.cpp function cgroupsStatistics add the timestamp value set.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp d2b77e3 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-25 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review116266
---



Patch looks great!

Reviews applied: [42288]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 1:16 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> ---
> 
> (Updated Jan. 26, 2016, 1:16 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
> https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker container REST API /monitor/statistics.json output have no timestamp 
> field, in docker.cpp function cgroupsStatistics add the timestamp value set.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp d2b77e3 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-25 Thread Andy Pang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/
---

(Updated 一月 26, 2016, 1:16 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Changes
---

remove the comment


Bugs: MESOS-4328
https://issues.apache.org/jira/browse/MESOS-4328


Repository: mesos


Description
---

Docker container REST API /monitor/statistics.json output have no timestamp 
field, in docker.cpp function cgroupsStatistics add the timestamp value set.


Diffs (updated)
-

  src/slave/containerizer/docker.cpp d2b77e3 

Diff: https://reviews.apache.org/r/42288/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-25 Thread Timothy Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review116139
---


Fix it, then Ship it!




Ship It!


src/slave/containerizer/docker.cpp (line 1370)


I don't think this comment means much here. Let's remove it


- Timothy Chen


On Jan. 21, 2016, 6:18 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> ---
> 
> (Updated Jan. 21, 2016, 6:18 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
> https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker container REST API /monitor/statistics.json output have no timestamp 
> field, in docker.cpp function cgroupsStatistics add the timestamp value set.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 40f6f0b 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-24 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review116039
---


Ship it!




Ship It!

- haosdent huang


On Jan. 21, 2016, 6:18 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> ---
> 
> (Updated Jan. 21, 2016, 6:18 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
> https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker container REST API /monitor/statistics.json output have no timestamp 
> field, in docker.cpp function cgroupsStatistics add the timestamp value set.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 40f6f0b 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-20 Thread Andy Pang 


> On 一月 21, 2016, 6:12 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [42288]
> > 
> > Failed command: ./support/apply-review.sh -n -r 42288
> > 
> > Error:
> >  2016-01-21 06:12:19 URL:https://reviews.apache.org/r/42288/diff/raw/ 
> > [612/612] -> "42288.patch" [1]
> > Total errors found: 0
> > Checking 1 files
> > Error: Commit message summary (the first line) must end in a period.

Thanks,I have fix it


- Andy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review115570
---


On 一月 21, 2016, 6:18 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> ---
> 
> (Updated 一月 21, 2016, 6:18 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
> https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker container REST API /monitor/statistics.json output have no timestamp 
> field, in docker.cpp function cgroupsStatistics add the timestamp value set.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 40f6f0b 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics.

2016-01-20 Thread Andy Pang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/
---

(Updated 一月 21, 2016, 6:18 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Summary (updated)
-

Add timestamp to DockerContainerizer's ResourceStatistics.


Bugs: MESOS-4328
https://issues.apache.org/jira/browse/MESOS-4328


Repository: mesos


Description (updated)
---

Docker container REST API /monitor/statistics.json output have no timestamp 
field, in docker.cpp function cgroupsStatistics add the timestamp value set.


Diffs
-

  src/slave/containerizer/docker.cpp 40f6f0b 

Diff: https://reviews.apache.org/r/42288/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

2016-01-20 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review115570
---


Bad patch!

Reviews applied: [42288]

Failed command: ./support/apply-review.sh -n -r 42288

Error:
 2016-01-21 06:12:19 URL:https://reviews.apache.org/r/42288/diff/raw/ [612/612] 
-> "42288.patch" [1]
Total errors found: 0
Checking 1 files
Error: Commit message summary (the first line) must end in a period.

- Mesos ReviewBot


On Jan. 21, 2016, 4:12 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> ---
> 
> (Updated Jan. 21, 2016, 4:12 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
> https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker container REST API /monitor/statistics.json output have no timestamp 
> field
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp 40f6f0b 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

2016-01-20 Thread Andy Pang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/
---

(Updated 一月 21, 2016, 4:12 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Changes
---

merge the newest git branch


Bugs: MESOS-4328
https://issues.apache.org/jira/browse/MESOS-4328


Repository: mesos


Description
---

Docker container REST API /monitor/statistics.json output have no timestamp 
field


Diffs (updated)
-

  src/slave/containerizer/docker.cpp 40f6f0b 

Diff: https://reviews.apache.org/r/42288/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

2016-01-20 Thread Andy Pang 


> On 一月 14, 2016, 9:19 a.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [42288]
> > 
> > Failed command: ./support/apply-review.sh -n -r 42288
> > 
> > Error:
> >  2016-01-14 09:19:38 URL:https://reviews.apache.org/r/42288/diff/raw/ 
> > [612/612] -> "42288.patch" [1]
> > Total errors found: 0
> > Checking 1 files
> > Error: Commit message summary (the first line) must not exceed 72 
> > characters.

Thanks?I have fix it, modify the summary as "Add timestamp to 
DockerContainerizer's ResourceStatistics"


- Andy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/#review114443
---


On 一月 21, 2016, 3:46 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42288/
> ---
> 
> (Updated 一月 21, 2016, 3:46 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Timothy Chen.
> 
> 
> Bugs: MESOS-4328
> https://issues.apache.org/jira/browse/MESOS-4328
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Docker container REST API /monitor/statistics.json output have no timestamp 
> field
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/docker.cpp da19975 
> 
> Diff: https://reviews.apache.org/r/42288/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 42288: Add timestamp to DockerContainerizer's ResourceStatistics

2016-01-20 Thread Andy Pang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42288/
---

(Updated 一月 21, 2016, 3:46 a.m.)


Review request for mesos, Jie Yu and Timothy Chen.


Changes
---

modify the summary,length less than 72 chars


Summary (updated)
-

Add timestamp to DockerContainerizer's ResourceStatistics


Bugs: MESOS-4328
https://issues.apache.org/jira/browse/MESOS-4328


Repository: mesos


Description
---

Docker container REST API /monitor/statistics.json output have no timestamp 
field


Diffs
-

  src/slave/containerizer/docker.cpp da19975 

Diff: https://reviews.apache.org/r/42288/diff/


Testing
---

make check


Thanks,

Andy Pang