Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/#review117256 --- Bad patch! Reviews applied: [42615] Failed command: ./support/apply-review.sh -n -r 42615 Error: 2016-02-01 20:27:18 URL:https://reviews.apache.org/r/42615/diff/raw/ [46356/46356] -> "42615.patch" [1] Total errors found: 0 Checking 58 files Error: Commit message summary (the first line) must start with a capital letter. Full log: https://builds.apache.org/job/mesos-reviewbot/11180/console - Mesos ReviewBot On Feb. 1, 2016, 7:40 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42617/ > --- > > (Updated Feb. 1, 2016, 7:40 p.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > --- > > For example, avoid using `std::string` in a .cpp file that already does > `using std::string`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > 5a10f59f3698a6ad85b7c2386def9686af8a23a6 > 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp > 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp > 01e4b2fff7cc05a47d7919d702543a38bf6c339d > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 4b7d1347f93261df7a7d512721146edca2703b34 > 3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp > c0be974ea2dc74c63ec3561403b3f4d3722a8df3 > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp > 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55 > > Diff: https://reviews.apache.org/r/42617/diff/ > > > Testing > --- > > "make check" on OSX and Arch Linux. > > > Thanks, > > Neil Conway > >
Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/ --- (Updated Feb. 1, 2016, 7:40 p.m.) Review request for mesos and Michael Park. Changes --- Rebase. Repository: mesos Description --- For example, avoid using `std::string` in a .cpp file that already does `using std::string`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 5a10f59f3698a6ad85b7c2386def9686af8a23a6 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp 01e4b2fff7cc05a47d7919d702543a38bf6c339d 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4b7d1347f93261df7a7d512721146edca2703b34 3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp c0be974ea2dc74c63ec3561403b3f4d3722a8df3 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55 Diff: https://reviews.apache.org/r/42617/diff/ Testing --- "make check" on OSX and Arch Linux. Thanks, Neil Conway
Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/#review116719 --- Bad patch! Reviews applied: [42615] Failed command: ./support/apply-review.sh -n -r 42615 Error: .. 2016-01-28 05:53:38 URL:https://reviews.apache.org/r/42615/diff/raw/ [40106/40106] -> "42615.patch" [1] Total errors found: 0 Checking 54 files Error: Commit message summary (the first line) must start with a capital letter. Full log: https://builds.apache.org/job/mesos-reviewbot/11086/console - Mesos ReviewBot On Jan. 28, 2016, 12:56 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42617/ > --- > > (Updated Jan. 28, 2016, 12:56 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > --- > > For example, avoid using `std::string` in a .cpp file that already does > `using std::string`. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp > 5a10f59f3698a6ad85b7c2386def9686af8a23a6 > 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp > 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b > 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp > c5ffd017f83149a58a2dee8c87461cd06bb43bed > 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp > 4b7d1347f93261df7a7d512721146edca2703b34 > 3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp > c0be974ea2dc74c63ec3561403b3f4d3722a8df3 > 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp > 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55 > > Diff: https://reviews.apache.org/r/42617/diff/ > > > Testing > --- > > "make check" on OSX and Arch Linux. > > > Thanks, > > Neil Conway > >
Re: Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/ --- (Updated Jan. 28, 2016, 12:56 a.m.) Review request for mesos and Michael Park. Changes --- Rebase. Repository: mesos Description --- For example, avoid using `std::string` in a .cpp file that already does `using std::string`. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 5a10f59f3698a6ad85b7c2386def9686af8a23a6 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp c5ffd017f83149a58a2dee8c87461cd06bb43bed 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp 4b7d1347f93261df7a7d512721146edca2703b34 3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp c0be974ea2dc74c63ec3561403b3f4d3722a8df3 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55 Diff: https://reviews.apache.org/r/42617/diff/ Testing --- "make check" on OSX and Arch Linux. Thanks, Neil Conway
Review Request 42617: stout: Cleaned up usage of namespace-qualified identifiers.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42617/ --- Review request for mesos. Repository: mesos Description --- For example, avoid using `std::string` in a .cpp file that already does `using std::string`. Diffs - 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp 5a10f59f3698a6ad85b7c2386def9686af8a23a6 3rdparty/libprocess/3rdparty/stout/tests/linkedhashmap_tests.cpp 21a98b85277d946b887cb23c4ebb4d32cfcb0c6b 3rdparty/libprocess/3rdparty/stout/tests/os/filesystem_tests.cpp c5ffd017f83149a58a2dee8c87461cd06bb43bed 3rdparty/libprocess/3rdparty/stout/tests/os_tests.cpp dc8cf74f1bc90f6234a00d8cbca9c93a350cffa0 3rdparty/libprocess/3rdparty/stout/tests/some_tests.cpp c0be974ea2dc74c63ec3561403b3f4d3722a8df3 3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7715fa4baa150f370bdd0fd5c2f98dc4c6f5fc55 Diff: https://reviews.apache.org/r/42617/diff/ Testing --- "make check" on OSX and Arch Linux. Thanks, Neil Conway
