Re: Review Request 42797: Fix expire CERN GPG key link.

2016-02-01 Thread Joseph Wu


> On Feb. 1, 2016, 8:12 a.m., Benjamin Bannier wrote:
> > docs/getting-started.md, lines 87-90
> > 
> >
> > While this appears to work, it seems weird to import the repo from 
> > `linuxsoft.cern.ch`, and the key from `ftp.scientificlinux.org`. Any reason 
> > this cannot be consistent? I am mostly worried about it running out of sync 
> > again.
> 
> haosdent huang wrote:
> Yes, you concern is reasonable. But this is the best link I could find by 
> google except we give up cern repo.

If we're worried about the key moving, it may be appropriate to copy the key to 
a Gist here: https://github.com/3rdparty


- Joseph


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42797/#review117221
---


On Jan. 26, 2016, 6:13 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42797/
> ---
> 
> (Updated Jan. 26, 2016, 6:13 a.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-4511
> https://issues.apache.org/jira/browse/MESOS-4511
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix expire CERN GPG key link.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
> 
> Diff: https://reviews.apache.org/r/42797/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 42797: Fix expire CERN GPG key link.

2016-02-01 Thread haosdent huang


> On Feb. 1, 2016, 4:12 p.m., Benjamin Bannier wrote:
> > docs/getting-started.md, lines 87-90
> > 
> >
> > While this appears to work, it seems weird to import the repo from 
> > `linuxsoft.cern.ch`, and the key from `ftp.scientificlinux.org`. Any reason 
> > this cannot be consistent? I am mostly worried about it running out of sync 
> > again.

Yes, you concern is reasonable. But this is the best link I could find by 
google except we give up cern repo.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42797/#review117221
---


On Jan. 26, 2016, 2:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42797/
> ---
> 
> (Updated Jan. 26, 2016, 2:13 p.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-4511
> https://issues.apache.org/jira/browse/MESOS-4511
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix expire CERN GPG key link.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
> 
> Diff: https://reviews.apache.org/r/42797/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 42797: Fix expire CERN GPG key link.

2016-02-01 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42797/#review117221
---




docs/getting-started.md (lines 87 - 90)


While this appears to work, it seems weird to import the repo from 
`linuxsoft.cern.ch`, and the key from `ftp.scientificlinux.org`. Any reason 
this cannot be consistent? I am mostly worried about it running out of sync 
again.


- Benjamin Bannier


On Jan. 26, 2016, 3:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42797/
> ---
> 
> (Updated Jan. 26, 2016, 3:13 p.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-4511
> https://issues.apache.org/jira/browse/MESOS-4511
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix expire CERN GPG key link.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
> 
> Diff: https://reviews.apache.org/r/42797/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 42797: Fix expire CERN GPG key link.

2016-01-26 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42797/#review116377
---



Patch looks great!

Reviews applied: [42797]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export 
COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Jan. 26, 2016, 2:13 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42797/
> ---
> 
> (Updated Jan. 26, 2016, 2:13 p.m.)
> 
> 
> Review request for mesos, Adam B and Timothy Chen.
> 
> 
> Bugs: MESOS-4511
> https://issues.apache.org/jira/browse/MESOS-4511
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fix expire CERN GPG key link.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 
> 
> Diff: https://reviews.apache.org/r/42797/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Review Request 42797: Fix expire CERN GPG key link.

2016-01-26 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42797/
---

Review request for mesos, Adam B and Timothy Chen.


Bugs: MESOS-4511
https://issues.apache.org/jira/browse/MESOS-4511


Repository: mesos


Description
---

Fix expire CERN GPG key link.


Diffs
-

  docs/getting-started.md 7177f9d5ae33dbabf0ed1bb1b9870873906e1a56 

Diff: https://reviews.apache.org/r/42797/diff/


Testing
---


Thanks,

haosdent huang