Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-08 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/#review118262
---




src/slave/containerizer/mesos/containerizer.cpp (line 1317)


s/aggregate/result/



src/slave/containerizer/mesos/containerizer.cpp (line 1330)


Please remove this. we need to be very careful of adding INFO level logging.



src/slave/containerizer/mesos/containerizer.cpp (line 1341)


s/Unable to get status for//



src/slave/containerizer/mesos/containerizer.cpp (lines 1352 - 1355)


```
return await(futures).then(
lambda::bind(_status, containerId, lambda::_1));
```


- Jie Yu


On Feb. 8, 2016, 6:43 a.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42983/
> ---
> 
> (Updated Feb. 8, 2016, 6:43 a.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4487
> https://issues.apache.org/jira/browse/MESOS-4487
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Implemented the `status` method in `MesosContainerizer`.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> 811ab7937279c4a55da450c136f9fcb1303ea0d5 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 1e362d2756690368fde46a3a516c258d9ead2154 
> 
> Diff: https://reviews.apache.org/r/42983/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-08 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/
---

(Updated Feb. 8, 2016, 8:17 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Implemented the `status` method in `MesosContainerizer`.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
1e362d2756690368fde46a3a516c258d9ead2154 

Diff: https://reviews.apache.org/r/42983/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-07 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/
---

(Updated Feb. 8, 2016, 6:43 a.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Implemented the `status` method in `MesosContainerizer`.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
1e362d2756690368fde46a3a516c258d9ead2154 

Diff: https://reviews.apache.org/r/42983/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-05 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/
---

(Updated Feb. 5, 2016, 8 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Made logs more descipritive.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Implemented the `status` method in `MesosContainerizer`.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
ed8a54543cd2e51bd9967745ab2351f909b7cf35 

Diff: https://reviews.apache.org/r/42983/diff/


Testing
---

make


Thanks,

Avinash sridharan

Re: Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-04 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/
---

(Updated Feb. 4, 2016, 7:13 p.m.)


Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Implemented the `status` method in `MesosContainerizer`.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 

Diff: https://reviews.apache.org/r/42983/diff/


Testing
---

make


Thanks,

Avinash sridharan

Review Request 42983: Implemented the `status` method in `MesosContainerizer`.

2016-02-02 Thread Avinash sridharan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42983/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4487
https://issues.apache.org/jira/browse/MESOS-4487


Repository: mesos


Description
---

Implemented the `status` method in `MesosContainerizer`.


Diffs
-

  src/slave/containerizer/mesos/containerizer.hpp 
811ab7937279c4a55da450c136f9fcb1303ea0d5 
  src/slave/containerizer/mesos/containerizer.cpp 
4b504dbb58823ce7675f1d2048dcc7a27c05663d 

Diff: https://reviews.apache.org/r/42983/diff/


Testing
---

make


Thanks,

Avinash sridharan