Re: Review Request 42994: [3 of 7] Added a persistent volume test framework for shared volumes.

2016-02-01 Thread Anindya Sinha 


> On Jan. 30, 2016, 10:30 a.m., Guangya Liu wrote:
> > src/tests/persistent_shared_volume_framework_test.sh, line 1
> > 
> >
> > Seems this file does not have execute permssion

Seems like it does.
-rwxr-xr-x  1   x  726 Feb  1 13:57 
persistent_shared_volume_framework_test.sh


- Anindya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42994/#review117101
---


On Jan. 30, 2016, 12:26 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42994/
> ---
> 
> (Updated Jan. 30, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a persistent volume test framework for shared volumes.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
>   src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp a9b685b0290f23461f43b12f05f6071fa46412a6 
>   src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42994/diff/
> 
> 
> Testing
> ---
> 
> make check done.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Re: Review Request 42994: [3 of 7] Added a persistent volume test framework for shared volumes.

2016-01-30 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42994/#review117101
---




src/examples/persistent_shared_volume_framework.cpp (line 56)


Move this to 53



src/tests/persistent_shared_volume_framework_test.sh (line 1)


Seems this file does not have execute permssion


- Guangya Liu


On 一月 30, 2016, 12:26 a.m., Anindya Sinha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42994/
> ---
> 
> (Updated 一月 30, 2016, 12:26 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Bugs: MESOS-4431
> https://issues.apache.org/jira/browse/MESOS-4431
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a persistent volume test framework for shared volumes.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
>   src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
>   src/tests/examples_tests.cpp a9b685b0290f23461f43b12f05f6071fa46412a6 
>   src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42994/diff/
> 
> 
> Testing
> ---
> 
> make check done.
> 
> 
> Thanks,
> 
> Anindya Sinha
> 
>

Review Request 42994: [3 of 7] Added a persistent volume test framework for shared volumes.

2016-01-29 Thread Anindya Sinha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42994/
---

Review request for mesos and Adam B.


Bugs: MESOS-4431
https://issues.apache.org/jira/browse/MESOS-4431


Repository: mesos


Description
---

Added a persistent volume test framework for shared volumes.


Diffs
-

  src/Makefile.am fac17f4bac3b2ddda0384dec8b0ed6f960bd24d1 
  src/examples/persistent_shared_volume_framework.cpp PRE-CREATION 
  src/tests/examples_tests.cpp a9b685b0290f23461f43b12f05f6071fa46412a6 
  src/tests/persistent_shared_volume_framework_test.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/42994/diff/


Testing
---

make check done.


Thanks,

Anindya Sinha