Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-07-09 Thread Joris Van Remoortere

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43183/#review141541
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On Feb. 5, 2016, 1:13 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43183/
> ---
> 
> (Updated Feb. 5, 2016, 1:13 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-4577
> https://issues.apache.org/jira/browse/MESOS-4577
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support routing_tests run in aarch64 cpu.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/routing_tests.cpp 
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43183/diff/
> 
> 
> Testing
> ---
> 
> make test ok
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread Andy Pang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43183/
---

(Updated 二月 5, 2016, 1:13 a.m.)


Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Bugs: MESOS-4577
https://issues.apache.org/jira/browse/MESOS-4577


Repository: mesos


Description
---

Support routing_tests run in aarch64 cpu.


Diffs
-

  src/tests/containerizer/routing_tests.cpp 
4ebb01213ce20f954c2633df95e898cf66a2d9e9 

Diff: https://reviews.apache.org/r/43183/diff/


Testing
---

make test ok


Thanks,

Andy Pang



Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43183/#review117797
---



Patch looks great!

Reviews applied: [43182, 43183]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 4, 2016, 9:34 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43183/
> ---
> 
> (Updated Feb. 4, 2016, 9:34 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support routing_tests run in aarch64 cpu.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/routing_tests.cpp 
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43183/diff/
> 
> 
> Testing
> ---
> 
> make test ok
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Re: Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43183/#review117790
---


Ship it!




Please also fill the `Bug` field to `MESOS-4577` in this patch.

- haosdent huang


On Feb. 4, 2016, 9:34 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43183/
> ---
> 
> (Updated Feb. 4, 2016, 9:34 a.m.)
> 
> 
> Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Support routing_tests run in aarch64 cpu.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/routing_tests.cpp 
> 4ebb01213ce20f954c2633df95e898cf66a2d9e9 
> 
> Diff: https://reviews.apache.org/r/43183/diff/
> 
> 
> Testing
> ---
> 
> make test ok
> 
> 
> Thanks,
> 
> Andy Pang
> 
>



Review Request 43183: Support routing_tests run in aarch64 cpu.

2016-02-04 Thread Andy Pang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43183/
---

Review request for mesos, BenjaminVW BenjaminVW, Jie Yu, and Vinod Kone.


Repository: mesos


Description
---

Support routing_tests run in aarch64 cpu.


Diffs
-

  src/tests/containerizer/routing_tests.cpp 
4ebb01213ce20f954c2633df95e898cf66a2d9e9 

Diff: https://reviews.apache.org/r/43183/diff/


Testing
---

make test ok


Thanks,

Andy Pang