Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43286/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-3273
https://issues.apache.org/jira/browse/MESOS-3273


Repository: mesos


Description
---

See summary. The root cause is similar to r43285.


Diffs
-

  src/examples/event_call_framework.cpp 
8cfe1a0794b476bc099b067a9aeb79f099bbc18c 

Diff: https://reviews.apache.org/r/43286/diff/


Testing
---

make check + testing steps done in r43285


Thanks,

Anand Mazumdar

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43286/#review118150
---


Ship it!




Ship It!

- haosdent huang


On 二月 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43286/
> ---
> 
> (Updated 二月 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3273
> https://issues.apache.org/jira/browse/MESOS-3273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. The root cause is similar to r43285.
> 
> 
> Diffs
> -
> 
>   src/examples/event_call_framework.cpp 
> 8cfe1a0794b476bc099b067a9aeb79f099bbc18c 
> 
> Diff: https://reviews.apache.org/r/43286/diff/
> 
> 
> Testing
> ---
> 
> make check + testing steps done in r43285
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-08 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43286/#review118293
---


Fix it, then Ship it!





src/examples/event_call_framework.cpp (line 195)


ditto. add a comment please.


- Vinod Kone


On Feb. 6, 2016, 5:51 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43286/
> ---
> 
> (Updated Feb. 6, 2016, 5:51 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3273
> https://issues.apache.org/jira/browse/MESOS-3273
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary. The root cause is similar to r43285.
> 
> 
> Diffs
> -
> 
>   src/examples/event_call_framework.cpp 
> 8cfe1a0794b476bc099b067a9aeb79f099bbc18c 
> 
> Diff: https://reviews.apache.org/r/43286/diff/
> 
> 
> Testing
> ---
> 
> make check + testing steps done in r43285
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43286: Fixed flakiness in ExamplesTest.EventCallFramework.

2016-02-08 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43286/
---

(Updated Feb. 8, 2016, 10:05 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comments from Vinod


Bugs: MESOS-3273
https://issues.apache.org/jira/browse/MESOS-3273


Repository: mesos


Description
---

See summary. The root cause is similar to r43285.


Diffs (updated)
-

  src/examples/event_call_framework.cpp 
8cfe1a0794b476bc099b067a9aeb79f099bbc18c 

Diff: https://reviews.apache.org/r/43286/diff/


Testing
---

make check + testing steps done in r43285


Thanks,

Anand Mazumdar