Re: Review Request 43523: Speed up SlaveTest.MetricsSlaveLaunchErrors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43523/#review127784 --- Do we still need this patch? I believe Benjamin has fixed rate limiting for metrcis in tests altogether with https://reviews.apache.org/r/44073/. Correct? - Alexander Rukletsov On Feb. 12, 2016, 8:09 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43523/ > --- > > (Updated Feb. 12, 2016, 8:09 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4162 > https://issues.apache.org/jira/browse/MESOS-4162 > > > Repository: mesos > > > Description > --- > > Speed up SlaveTest.MetricsSlaveLaunchErrors. > > > Diffs > - > > src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a > > Diff: https://reviews.apache.org/r/43523/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 43523: Speed up SlaveTest.MetricsSlaveLaunchErrors.
> On April 8, 2016, 2:11 p.m., Alexander Rukletsov wrote: > > Do we still need this patch? I believe Benjamin has fixed rate limiting for > > metrcis in tests altogether with https://reviews.apache.org/r/44073/. > > Correct? Yes. Let me discard this. - haosdent --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43523/#review127784 --- On Feb. 12, 2016, 8:09 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43523/ > --- > > (Updated Feb. 12, 2016, 8:09 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4162 > https://issues.apache.org/jira/browse/MESOS-4162 > > > Repository: mesos > > > Description > --- > > Speed up SlaveTest.MetricsSlaveLaunchErrors. > > > Diffs > - > > src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a > > Diff: https://reviews.apache.org/r/43523/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Re: Review Request 43523: Speed up SlaveTest.MetricsSlaveLaunchErrors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43523/#review119003 --- Patch looks great! Reviews applied: [43523] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 12, 2016, 8:09 a.m., haosdent huang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43523/ > --- > > (Updated Feb. 12, 2016, 8:09 a.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4162 > https://issues.apache.org/jira/browse/MESOS-4162 > > > Repository: mesos > > > Description > --- > > Speed up SlaveTest.MetricsSlaveLaunchErrors. > > > Diffs > - > > src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a > > Diff: https://reviews.apache.org/r/43523/diff/ > > > Testing > --- > > > Thanks, > > haosdent huang > >
Review Request 43523: Speed up SlaveTest.MetricsSlaveLaunchErrors.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43523/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4162 https://issues.apache.org/jira/browse/MESOS-4162 Repository: mesos Description --- Speed up SlaveTest.MetricsSlaveLaunchErrors. Diffs - src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a Diff: https://reviews.apache.org/r/43523/diff/ Testing --- Thanks, haosdent huang