Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43565/#review119387
---


Ship it!




Ship It!

- Jie Yu


On Feb. 14, 2016, 4:31 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43565/
> ---
> 
> (Updated Feb. 14, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
> https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This method will be used by the agent to retrieve `ContainerStatus`
> from the `Containerizer`, that was responsible for launching the
> container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.cpp 
> f0a7bba4a56702872c9b73a12128b5292708d0e7 
> 
> Diff: https://reviews.apache.org/r/43565/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

[Avinash sridharan]

> On Feb. 15, 2016, 1:17 a.m., Guangya Liu wrote:
> > src/slave/containerizer/composing.cpp, line 230
> > 
> >
> > It is already 81 chars, it is better to split this to several lines.
> 
> Avinash sridharan wrote:
> On my VIM editor this shows up as exactly 80 characters?

Also, the git commit-hook would not allow a commit for any line > 80 characters.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43565/#review119201
---


On Feb. 14, 2016, 4:31 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43565/
> ---
> 
> (Updated Feb. 14, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
> https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This method will be used by the agent to retrieve `ContainerStatus`
> from the `Containerizer`, that was responsible for launching the
> container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.cpp 
> f0a7bba4a56702872c9b73a12128b5292708d0e7 
> 
> Diff: https://reviews.apache.org/r/43565/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

[Avinash sridharan]

> On Feb. 15, 2016, 1:17 a.m., Guangya Liu wrote:
> > src/slave/containerizer/composing.cpp, line 230
> > 
> >
> > It is already 81 chars, it is better to split this to several lines.

On my VIM editor this shows up as exactly 80 characters?


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43565/#review119201
---


On Feb. 14, 2016, 4:31 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43565/
> ---
> 
> (Updated Feb. 14, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
> https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This method will be used by the agent to retrieve `ContainerStatus`
> from the `Containerizer`, that was responsible for launching the
> container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.cpp 
> f0a7bba4a56702872c9b73a12128b5292708d0e7 
> 
> Diff: https://reviews.apache.org/r/43565/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

[Guangya Liu]

> On 二月 15, 2016, 1:17 a.m., Guangya Liu wrote:
> > src/slave/containerizer/composing.cpp, line 513
> > 
> >
> > I was that mesos containizers are using `return Failure("Unknown 
> > container: " + stringify(containerId));` , can you please update the 
> > message to keep consistent?

Mesos containizer using `"Unknown container: " + stringify(containerId)` while 
most of the compose containizer using `"Container " + containerId.value() + " 
not found"`, just ignore this if you do not want an update.


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43565/#review119201
---


On 二月 14, 2016, 4:31 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43565/
> ---
> 
> (Updated 二月 14, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
> https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This method will be used by the agent to retrieve `ContainerStatus`
> from the `Containerizer`, that was responsible for launching the
> container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.cpp 
> f0a7bba4a56702872c9b73a12128b5292708d0e7 
> 
> Diff: https://reviews.apache.org/r/43565/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Re: Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43565/#review119201
---




src/slave/containerizer/composing.cpp (line 230)


It is already 81 chars, it is better to split this to several lines.



src/slave/containerizer/composing.cpp (line 513)


I was that mesos containizers are using `return Failure("Unknown container: 
" + stringify(containerId));` , can you please update the message to keep 
consistent?


- Guangya Liu


On 二月 14, 2016, 4:31 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43565/
> ---
> 
> (Updated 二月 14, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
> https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This method will be used by the agent to retrieve `ContainerStatus`
> from the `Containerizer`, that was responsible for launching the
> container.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/composing.cpp 
> f0a7bba4a56702872c9b73a12128b5292708d0e7 
> 
> Diff: https://reviews.apache.org/r/43565/diff/
> 
> 
> Testing
> ---
> 
> make and make check.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>

Review Request 43565: Implemented `status` method in `ComposingContainerizer`.

[Avinash sridharan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43565/
---

Review request for mesos and Jie Yu.


Bugs: MESOS-4670
https://issues.apache.org/jira/browse/MESOS-4670


Repository: mesos


Description
---

This method will be used by the agent to retrieve `ContainerStatus`
from the `Containerizer`, that was responsible for launching the
container.


Diffs
-

  src/slave/containerizer/composing.cpp 
f0a7bba4a56702872c9b73a12128b5292708d0e7 

Diff: https://reviews.apache.org/r/43565/diff/


Testing
---

make and make check.


Thanks,

Avinash sridharan