Re: Review Request 43587: Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43587/#review120571 --- Ship it! Ship It! - Joris Van Remoortere On Feb. 15, 2016, 9:19 p.m., Michael Browning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43587/ > --- > > (Updated Feb. 15, 2016, 9:19 p.m.) > > > Review request for mesos, Joris Van Remoortere and Neil Conway. > > > Bugs: MESOS-3486 > https://issues.apache.org/jira/browse/MESOS-3486 > > > Repository: mesos > > > Description > --- > > Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents. > > Some usages of the DROP_MESSAGE, DROP_MESSAGES, and FUTURE_MESSAGE macros > from the libprocess tests perform logic already implemented in the > DROP_PROTOBUF, DROP_PROTOBUFS, and FUTURE_PROTOBUF macros defined in > tests/mesos.hpp. This diff moves those tests to use the latter versions where > appropriate. > > > Diffs > - > > src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 > src/tests/log_tests.cpp 923d71f48e743a77f2a3ba9e982aef4417c6c7fe > src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 > src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 > src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a > > Diff: https://reviews.apache.org/r/43587/diff/ > > > Testing > --- > > This change involves changing existing macro invocations in testing code, so > no additional testing was performed. > > > Thanks, > > Michael Browning > >
Re: Review Request 43587: Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43587/#review119254 --- Ship it! Ship It! - Klaus Ma On Feb. 16, 2016, 5:19 a.m., Michael Browning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43587/ > --- > > (Updated Feb. 16, 2016, 5:19 a.m.) > > > Review request for mesos, Joris Van Remoortere and Neil Conway. > > > Bugs: MESOS-3486 > https://issues.apache.org/jira/browse/MESOS-3486 > > > Repository: mesos > > > Description > --- > > Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents. > > Some usages of the DROP_MESSAGE, DROP_MESSAGES, and FUTURE_MESSAGE macros > from the libprocess tests perform logic already implemented in the > DROP_PROTOBUF, DROP_PROTOBUFS, and FUTURE_PROTOBUF macros defined in > tests/mesos.hpp. This diff moves those tests to use the latter versions where > appropriate. > > > Diffs > - > > src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 > src/tests/log_tests.cpp 923d71f48e743a77f2a3ba9e982aef4417c6c7fe > src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 > src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 > src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a > > Diff: https://reviews.apache.org/r/43587/diff/ > > > Testing > --- > > This change involves changing existing macro invocations in testing code, so > no additional testing was performed. > > > Thanks, > > Michael Browning > >
Re: Review Request 43587: Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43587/#review119253 --- Ship it! Thanks for the contribution, Michael! "make check" passed for me. - Neil Conway On Feb. 15, 2016, 9:19 p.m., Michael Browning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43587/ > --- > > (Updated Feb. 15, 2016, 9:19 p.m.) > > > Review request for mesos, Joris Van Remoortere and Neil Conway. > > > Bugs: MESOS-3486 > https://issues.apache.org/jira/browse/MESOS-3486 > > > Repository: mesos > > > Description > --- > > Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents. > > Some usages of the DROP_MESSAGE, DROP_MESSAGES, and FUTURE_MESSAGE macros > from the libprocess tests perform logic already implemented in the > DROP_PROTOBUF, DROP_PROTOBUFS, and FUTURE_PROTOBUF macros defined in > tests/mesos.hpp. This diff moves those tests to use the latter versions where > appropriate. > > > Diffs > - > > src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 > src/tests/log_tests.cpp 923d71f48e743a77f2a3ba9e982aef4417c6c7fe > src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 > src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 > src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a > > Diff: https://reviews.apache.org/r/43587/diff/ > > > Testing > --- > > This change involves changing existing macro invocations in testing code, so > no additional testing was performed. > > > Thanks, > > Michael Browning > >
Re: Review Request 43587: Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43587/#review119246 --- Patch looks great! Reviews applied: [43587] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Feb. 15, 2016, 9:19 p.m., Michael Browning wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43587/ > --- > > (Updated Feb. 15, 2016, 9:19 p.m.) > > > Review request for mesos, Joris Van Remoortere and Neil Conway. > > > Bugs: MESOS-3486 > https://issues.apache.org/jira/browse/MESOS-3486 > > > Repository: mesos > > > Description > --- > > Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents. > > Some usages of the DROP_MESSAGE, DROP_MESSAGES, and FUTURE_MESSAGE macros > from the libprocess tests perform logic already implemented in the > DROP_PROTOBUF, DROP_PROTOBUFS, and FUTURE_PROTOBUF macros defined in > tests/mesos.hpp. This diff moves those tests to use the latter versions where > appropriate. > > > Diffs > - > > src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 > src/tests/log_tests.cpp 923d71f48e743a77f2a3ba9e982aef4417c6c7fe > src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 > src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 > src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a > > Diff: https://reviews.apache.org/r/43587/diff/ > > > Testing > --- > > This change involves changing existing macro invocations in testing code, so > no additional testing was performed. > > > Thanks, > > Michael Browning > >
Review Request 43587: Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43587/ --- Review request for mesos, Joris Van Remoortere and Neil Conway. Bugs: MESOS-3486 https://issues.apache.org/jira/browse/MESOS-3486 Repository: mesos Description --- Replaced use of *_MESSAGE macros with *_PROTOBUF equivalents. Diffs - src/tests/hook_tests.cpp 59a00ea722a17bbc82b14c69bda826f68cbac6e9 src/tests/log_tests.cpp 923d71f48e743a77f2a3ba9e982aef4417c6c7fe src/tests/partition_tests.cpp c5badbe90e302793bfbf3f16373efe241decb7d5 src/tests/slave_recovery_tests.cpp e2a78a0f55b7657057ee351a747caff51024fd67 src/tests/slave_tests.cpp c7f5a701eff2c2f9aa3df5722583a131bf2c072a Diff: https://reviews.apache.org/r/43587/diff/ Testing --- This change involves changing existing macro invocations in testing code, so no additional testing was performed. Thanks, Michael Browning
