Re: Review Request 43838: Added note about not implemented requestResources call.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review122276
---




src/java/src/org/apache/mesos/SchedulerDriver.java (line 117)


Definitely ought to cover the python interface too. See 
`src/python/interface/src/mesos/interface/__init__.py:177:  def 
requestResources(self, requests):`


- Adam B


On Feb. 22, 2016, 8:54 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated Feb. 22, 2016, 8:54 a.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43838: Added note about not implemented requestResources call.

[Joerg Schad]

> On Feb. 23, 2016, 3 a.m., Klaus Ma wrote:
> > docs/app-framework-development-guide.md, line 172
> > 
> >
> > It seems scheduler did not send `ResourceRequestMessage` to the master; 
> > so other allocator also can not handle it. I'd like to say Master ignore 
> > this call.

What exectly are you referring to as Scheduler? The SchedulerDriver? I believe 
the java one might ignore it but not sure for all others. I will check.


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review120253
---


On Feb. 22, 2016, 4:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated Feb. 22, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43838: Added note about not implemented requestResources call.

[Klaus Ma]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review120253
---




docs/app-framework-development-guide.md (line 172)


It seems scheduler did not send `ResourceRequestMessage` to the master; so 
other allocator also can not handle it. I'd like to say Master ignore this call.


- Klaus Ma


On Feb. 23, 2016, 12:54 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated Feb. 23, 2016, 12:54 a.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43838: Added note about not implemented requestResources call.

[Guangya Liu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review120251
---



Seems you are losing python interface.

- Guangya Liu


On 二月 22, 2016, 4:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated 二月 22, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 43838: Added note about not implemented requestResources call.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/#review120188
---



Patch looks great!

Reviews applied: [43819, 43838]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 22, 2016, 4:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43838/
> ---
> 
> (Updated Feb. 22, 2016, 4:54 p.m.)
> 
> 
> Review request for mesos, Adam B and Guangya Liu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about not implemented requestResources call.
> 
> 
> Diffs
> -
> 
>   docs/app-framework-development-guide.md 
> e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
>   include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
>   src/java/src/org/apache/mesos/SchedulerDriver.java 
> bf866f5ebece2505eaa27bf39a1382cd1a2a069a 
> 
> Diff: https://reviews.apache.org/r/43838/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Review Request 43838: Added note about not implemented requestResources call.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43838/
---

Review request for mesos, Adam B and Guangya Liu.


Repository: mesos


Description
---

Added note about not implemented requestResources call.


Diffs
-

  docs/app-framework-development-guide.md 
e0f40adacf96bdf0c510b3400eb0ed0cd964ab9d 
  include/mesos/scheduler.hpp 14c7ff964aa7b94f439d16e605380661d2279d54 
  src/java/src/org/apache/mesos/SchedulerDriver.java 
bf866f5ebece2505eaa27bf39a1382cd1a2a069a 

Diff: https://reviews.apache.org/r/43838/diff/


Testing
---


Thanks,

Joerg Schad