Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-04-08 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/
---

(Updated April 9, 2016, 12:32 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Changed the calling parameters for Windows API.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/44090/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-04-08 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/#review127926
---


Fix it, then Ship it!





3rdparty/libprocess/src/poll_socket.cpp (line 81)


Let's use `reinterpret_cast(...)`.



3rdparty/libprocess/src/poll_socket.cpp (line 118)


Let's use `reinterpret_cast(...)`.



3rdparty/libprocess/src/poll_socket.cpp (lines 160 - 166)


We'll follow-up with patches to add the following functions and use them 
here:

```
Try network::send(...);
Try network::recv(...);
```


- Michael Park


On April 8, 2016, 9:38 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44090/
> ---
> 
> (Updated April 8, 2016, 9:38 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
> Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Changed the calling parameters for Windows API.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/src/libevent.cpp 
> c4a8da8a70b97dd575b1256179c4f43742131a1e 
>   3rdparty/libprocess/src/poll_socket.cpp 
> cb2878565a112017b190b4ff83dc65a876ea45f9 
> 
> Diff: https://reviews.apache.org/r/44090/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-04-08 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/
---

(Updated April 8, 2016, 9:38 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Changed the calling parameters for Windows API.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
  3rdparty/libprocess/src/poll_socket.cpp 
cb2878565a112017b190b4ff83dc65a876ea45f9 

Diff: https://reviews.apache.org/r/44090/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-03-21 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/
---

(Updated March 21, 2016, 10:54 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Changed the calling parameters for Windows API.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
  3rdparty/libprocess/src/poll_socket.cpp 
6e6634b4b352e3723096521843546cf56ec6dd8b 

Diff: https://reviews.apache.org/r/44090/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-03-19 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/
---

(Updated March 17, 2016, 6:53 p.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Alex 
Clemmer, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Windows: Changed the calling parameters for Windows API.


Diffs
-

  3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
  3rdparty/libprocess/src/poll_socket.cpp 
6e6634b4b352e3723096521843546cf56ec6dd8b 

Diff: https://reviews.apache.org/r/44090/diff/


Testing
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat

Re: Review Request 44090: Windows: Changed the calling parameters for Windows API.

2016-03-12 Thread Daniel Pravat 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44090/
---

(Updated March 13, 2016, 7:27 a.m.)


Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Summary (updated)
-

Windows: Changed the calling parameters for Windows API.


Repository: mesos


Description (updated)
---

Windows: Changed the calling parameters for Windows API.


Diffs (updated)
-

  3rdparty/libprocess/src/libevent.cpp c4a8da8a70b97dd575b1256179c4f43742131a1e 
  3rdparty/libprocess/src/poll_socket.cpp 
6e6634b4b352e3723096521843546cf56ec6dd8b 

Diff: https://reviews.apache.org/r/44090/diff/


Testing (updated)
---

OSX: make check
Windows: build/run


Thanks,

Daniel Pravat