Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121660
---


Ship it!




Thanks for fixing this -- so looking foward to see parallel tests in action.


src/tests/state_tests.cpp (line 406)


We need to assert here again as the baseclass Setup implementation may have 
returned with an empty sandbox container.


- Till Toenshoff


On Feb. 29, 2016, 11:37 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> ---
> 
> (Updated Feb. 29, 2016, 11:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
> https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; 
> with this patch the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; 
> with the patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121237
---



Patch looks great!

Reviews applied: [44163]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 11:37 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> ---
> 
> (Updated Feb. 29, 2016, 11:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
> https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; 
> with this patch the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; 
> with the patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121231
---


Ship it!




Ship It!

- Jan Schlicht


On Feb. 29, 2016, 12:37 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> ---
> 
> (Updated Feb. 29, 2016, 12:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
> https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; 
> with this patch the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; 
> with the patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/
---

(Updated Feb. 29, 2016, 12:37 p.m.)


Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.


Changes
---

Addressed comments from Jan.


Bugs: MESOS-4806
https://issues.apache.org/jira/browse/MESOS-4806


Repository: mesos


Description
---

Used temporary directory for fixture creating output files.


Diffs (updated)
-

  src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 

Diff: https://reviews.apache.org/r/44163/diff/


Testing
---

make check (OS X, not optimized)

* before this patch running the test from a non-writable directory fails; with 
this patch the test passes,
* before this patch running gtest-parallel with filter `LevelDBState*` fails; 
with the patch the test passes.


Thanks,

Benjamin Bannier

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/#review121224
---




src/tests/state_tests.cpp (line 404)


IMHO this comment is unnecessary.



src/tests/state_tests.cpp (line 409)


This is no longer needed, because `TemporaryDirectoryTest::TearDown` will 
remove the sandbox directory.



src/tests/state_tests.cpp (line 416)


Make this the last statement of the function, because `storage` and `state` 
rely on directories that will be deleted by this function.



src/tests/state_tests.cpp (line 420)


Same as above.


- Jan Schlicht


On Feb. 29, 2016, 11:53 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44163/
> ---
> 
> (Updated Feb. 29, 2016, 11:53 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4806
> https://issues.apache.org/jira/browse/MESOS-4806
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Used temporary directory for fixture creating output files.
> 
> 
> Diffs
> -
> 
>   src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 
> 
> Diff: https://reviews.apache.org/r/44163/diff/
> 
> 
> Testing
> ---
> 
> make check (OS X, not optimized)
> 
> * before this patch running the test from a non-writable directory fails; 
> with this patch the test passes,
> * before this patch running gtest-parallel with filter `LevelDBState*` fails; 
> with the patch the test passes.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Re: Review Request 44163: Used temporary directory for fixture creating output files.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/
---

(Updated Feb. 29, 2016, 11:53 a.m.)


Review request for mesos, Benjamin Hindman, Jan Schlicht, and Till Toenshoff.


Bugs: MESOS-4806
https://issues.apache.org/jira/browse/MESOS-4806


Repository: mesos


Description
---

Used temporary directory for fixture creating output files.


Diffs
-

  src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 

Diff: https://reviews.apache.org/r/44163/diff/


Testing (updated)
---

make check (OS X, not optimized)

* before this patch running the test from a non-writable directory fails; with 
this patch the test passes,
* before this patch running gtest-parallel with filter `LevelDBState*` fails; 
with the patch the test passes.


Thanks,

Benjamin Bannier

Review Request 44163: Used temporary directory for fixture creating output files.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44163/
---

Review request for mesos, Benjamin Hindman and Till Toenshoff.


Bugs: MESOS-4806
https://issues.apache.org/jira/browse/MESOS-4806


Repository: mesos


Description
---

Used temporary directory for fixture creating output files.


Diffs
-

  src/tests/state_tests.cpp 0b0bc9cb1c6e4906aa65c113207e5a2d8ebe61d9 

Diff: https://reviews.apache.org/r/44163/diff/


Testing
---


Thanks,

Benjamin Bannier