Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

2016-03-01 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44250/
---

Review request for mesos and Joris Van Remoortere.


Repository: mesos


Description
---

This returns a new `Resources` object that omits dynamic reservation
and persistent volume information. This is intended primarily for
situations in which code wants to efficiently compute aggregate
statistics about many `Resource` values for which reservation and
persistent volume information is not relevant.


Diffs
-

  include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
  include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
  src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2 
  src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
  src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc 

Diff: https://reviews.apache.org/r/44250/diff/


Testing
---

make check


Thanks,

Neil Conway

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

2016-03-01 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44250/#review121584
---


Ship it!




- Joris Van Remoortere


On March 2, 2016, 2:21 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44250/
> ---
> 
> (Updated March 2, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This returns a new `Resources` object that omits dynamic reservation
> and persistent volume information. This is intended primarily for
> situations in which code wants to efficiently compute aggregate
> statistics about many `Resource` values for which reservation and
> persistent volume information is not relevant.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
>   include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
>   src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2 
>   src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
>   src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc 
> 
> Diff: https://reviews.apache.org/r/44250/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

2016-03-02 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44250/#review121605
---




src/tests/resources_tests.cpp (line 2215)


s/stripped resource/stripped persistent volume resource



src/tests/resources_tests.cpp (line 2240)


s/stripped resource/stripped dynamic reserved resource


- Guangya Liu


On 三月 2, 2016, 2:21 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44250/
> ---
> 
> (Updated 三月 2, 2016, 2:21 a.m.)
> 
> 
> Review request for mesos and Joris Van Remoortere.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This returns a new `Resources` object that omits dynamic reservation
> and persistent volume information. This is intended primarily for
> situations in which code wants to efficiently compute aggregate
> statistics about many `Resource` values for which reservation and
> persistent volume information is not relevant.
> 
> 
> Diffs
> -
> 
>   include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
>   include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
>   src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2 
>   src/tests/resources_tests.cpp a545100522bf4b1f03e50656d461b3cda6b41e11 
>   src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc 
> 
> Diff: https://reviews.apache.org/r/44250/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44250: Added `Resources::createStrippedScalarQuantity()`.

2016-03-02 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44250/
---

(Updated March 2, 2016, 6:27 p.m.)


Review request for mesos and Joris Van Remoortere.


Changes
---

Tweak unit tests.


Repository: mesos


Description
---

This returns a new `Resources` object that omits dynamic reservation
and persistent volume information. This is intended primarily for
situations in which code wants to efficiently compute aggregate
statistics about many `Resource` values for which reservation and
persistent volume information is not relevant.


Diffs (updated)
-

  include/mesos/resources.hpp fe8a5745ea7d4943c47ac22c73db70488c6dfa9f 
  include/mesos/v1/resources.hpp c27927e4f0d7f45e69fe3312b2423afb64c5c51e 
  src/common/resources.cpp 4fa1e78606485d6657d3776e28b78a43cc6449d2 
  src/tests/resources_tests.cpp e7525a00957e903993f4dd4b73e05c86f84c5c29 
  src/v1/resources.cpp bca523159577994d5890f832e4f61101b5dbf3bc 

Diff: https://reviews.apache.org/r/44250/diff/


Testing
---

make check


Thanks,

Neil Conway