Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
> On March 21, 2016, 9:02 a.m., Joris Van Remoortere wrote: > > Can you consider the feedback frmo the `write` review and rebase this? Alright, for posterity the `write` review is #44747, and I've adopted those suggestions here, too. - Alex --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review124515 --- On March 22, 2016, 5:21 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44748/ > --- > > (Updated March 22, 2016, 5:21 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > --- > > Stout: Added implementation of `read` that works on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 7bd4bfbc2ec5922879dcefddc12137336b11be52 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d494cbf8a2a24c88b0569634cfcbf29de0784797 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44748/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- (Updated March 22, 2016, 5:21 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3641 https://issues.apache.org/jira/browse/MESOS-3641 Repository: mesos Description --- Stout: Added implementation of `read` that works on Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 7bd4bfbc2ec5922879dcefddc12137336b11be52 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp d494cbf8a2a24c88b0569634cfcbf29de0784797 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44748/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review124515 --- Can you consider the feedback frmo the `write` review and rebase this? - Joris Van Remoortere On March 17, 2016, 7:34 p.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44748/ > --- > > (Updated March 17, 2016, 7:34 p.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > --- > > Stout: Added implementation of `read` that works on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > 7bd4bfbc2ec5922879dcefddc12137336b11be52 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d494cbf8a2a24c88b0569634cfcbf29de0784797 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44748/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- (Updated March 17, 2016, 7:34 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3641 https://issues.apache.org/jira/browse/MESOS-3641 Repository: mesos Description --- Stout: Added implementation of `read` that works on Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 7bd4bfbc2ec5922879dcefddc12137336b11be52 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp d494cbf8a2a24c88b0569634cfcbf29de0784797 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44748/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- (Updated March 14, 2016, 4:27 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3641 https://issues.apache.org/jira/browse/MESOS-3641 Repository: mesos Description --- Stout: Added implementation of `read` that works on Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 7bd4bfbc2ec5922879dcefddc12137336b11be52 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp d494cbf8a2a24c88b0569634cfcbf29de0784797 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44748/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- (Updated March 12, 2016, 6:14 p.m.) Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3641 https://issues.apache.org/jira/browse/MESOS-3641 Repository: mesos Description --- Stout: Added implementation of `read` that works on Windows. Diffs (updated) - 3rdparty/libprocess/3rdparty/stout/include/Makefile.am 7bd4bfbc2ec5922879dcefddc12137336b11be52 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp d494cbf8a2a24c88b0569634cfcbf29de0784797 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44748/diff/ Testing --- Thanks, Alex Clemmer
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123268 --- Ship it! Ship It! - Daniel Pravat On March 12, 2016, 1:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44748/ > --- > > (Updated March 12, 2016, 1:28 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > --- > > Stout: Added implementation of `read` that works on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d494cbf8a2a24c88b0569634cfcbf29de0784797 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44748/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Re: Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/#review123251 --- Ship it! Ship It! - Yi Sun On March 12, 2016, 1:28 a.m., Alex Clemmer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44748/ > --- > > (Updated March 12, 2016, 1:28 a.m.) > > > Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, > Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. > > > Bugs: MESOS-3641 > https://issues.apache.org/jira/browse/MESOS-3641 > > > Repository: mesos > > > Description > --- > > Stout: Added implementation of `read` that works on Windows. > > > Diffs > - > > 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp > d494cbf8a2a24c88b0569634cfcbf29de0784797 > 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/44748/diff/ > > > Testing > --- > > > Thanks, > > Alex Clemmer > >
Review Request 44748: Stout: Added implementation of `read` that works on Windows.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44748/ --- Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun. Bugs: MESOS-3641 https://issues.apache.org/jira/browse/MESOS-3641 Repository: mesos Description --- Stout: Added implementation of `read` that works on Windows. Diffs - 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/read.hpp PRE-CREATION 3rdparty/libprocess/3rdparty/stout/include/stout/os/read.hpp d494cbf8a2a24c88b0569634cfcbf29de0784797 3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/read.hpp PRE-CREATION Diff: https://reviews.apache.org/r/44748/diff/ Testing --- Thanks, Alex Clemmer
