Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-24 Thread Yong Tang 


> On March 17, 2016, 8:34 p.m., Michael Park wrote:
> > support/clang-format, line 3
> > 
> >
> > Can we uncomment this? Our style by definition is
> > 
> > > The Mesos codebase follows the Google C++ Style Guide with some 
> > notable differences, as described below.
> > 
> > So basing off of Google and overriding the parts that don't match 
> > accurately defines our style guide.
> 
> Yong Tang wrote:
> Thanks Michael. Just updated the review request. Let me know if there are 
> other issues.

Hi Michael, if there is no additional issues, can this review request be merged?


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124090
---


On March 17, 2016, 9:08 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 17, 2016, 9:08 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Yong Tang 


> On March 17, 2016, 4:09 p.m., Michael Park wrote:
> > The patch looks good to me. Would you like to send an announcement email to 
> > the dev list about this upgrade? I can do it if you'd rather not.
> 
> Yong Tang wrote:
> Hi Michael, Thanks a lot for the help! I will send out the email to the 
> dev list shortly.

Hi Michael, just sent out the email. Let me know if there is any additional 
issues.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124038
---


On March 16, 2016, 1:37 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 16, 2016, 1:37 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Yong Tang 


> On March 17, 2016, 4:09 p.m., Michael Park wrote:
> > The patch looks good to me. Would you like to send an announcement email to 
> > the dev list about this upgrade? I can do it if you'd rather not.

Hi Michael, Thanks a lot for the help! I will send out the email to the dev 
list shortly.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124038
---


On March 16, 2016, 1:37 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 16, 2016, 1:37 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124090
---


Fix it, then Ship it!





support/clang-format (line 3)


Can we uncomment this? Our style by definition is

> The Mesos codebase follows the Google C++ Style Guide with some notable 
differences, as described below.

So basing off of Google and overriding the parts that don't match 
accurately defines our style guide.


- Michael Park


On March 16, 2016, 1:37 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 16, 2016, 1:37 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-19 Thread Yong Tang 


> On March 17, 2016, 8:34 p.m., Michael Park wrote:
> > support/clang-format, line 3
> > 
> >
> > Can we uncomment this? Our style by definition is
> > 
> > > The Mesos codebase follows the Google C++ Style Guide with some 
> > notable differences, as described below.
> > 
> > So basing off of Google and overriding the parts that don't match 
> > accurately defines our style guide.

Thanks Michael. Just updated the review request. Let me know if there are other 
issues.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124090
---


On March 17, 2016, 9:08 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 17, 2016, 9:08 p.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-18 Thread Yong Tang 


> On March 15, 2016, 9:24 p.m., Michael Park wrote:
> > support/clang-format, lines 101-107
> > 
> >
> > We can help out a little more here:
> > 
> > The following code orders the headers:
> > (1) C standard library headers
> > (2) C++ standard library headers
> > (3) Our public headers
> > (4) Our private headers
> > 
> > ```
> > IncludeCategories:
> >   - Regex:   '^<.*.h>'
> > Priority:1
> >   - Regex:   '^<.*.hpp>'
> > Priority:3
> >   - Regex:   '^<.*>'
> > Priority:2
> >   - Regex:   '.*'
> > Priority:4
> > ```
> > 
> > __NOTE__: 3 seems to need to appear before 2, probably because it's 
> > more specific.
> 
> Yong Tang wrote:
> Thanks for the help, Michael. Just updated the review request. Let me 
> know if there are any other issues.

Hi Michael, any additional suggestions or update on this clang-format-3.8 issue 
(MESOS-4906)? Feedbacks are appreciated.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review123734
---


On March 16, 2016, 1:37 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 16, 2016, 1:37 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-18 Thread Yong Tang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/
---

(Updated March 17, 2016, 9:08 p.m.)


Review request for mesos and Michael Park.


Changes
---

Uncomment "BasedOnStyle: Google" based on the feedback from Michael.


Bugs: MESOS-4906
https://issues.apache.org/jira/browse/MESOS-4906


Repository: mesos


Description
---

Upgrade to clang-format-3.8 (MESOS-4906).


Diffs (updated)
-

  docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
  support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 

Diff: https://reviews.apache.org/r/44758/diff/


Testing
---

make check


Thanks,

Yong Tang

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-18 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review124038
---


Ship it!




The patch looks good to me. Would you like to send an announcement email to the 
dev list about this upgrade? I can do it if you'd rather not.

- Michael Park


On March 16, 2016, 1:37 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 16, 2016, 1:37 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-15 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review123836
---



Patch looks great!

Reviews applied: [44758]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 16, 2016, 1:37 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 16, 2016, 1:37 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-15 Thread Yong Tang 


> On March 15, 2016, 9:24 p.m., Michael Park wrote:
> > support/clang-format, lines 101-107
> > 
> >
> > We can help out a little more here:
> > 
> > The following code orders the headers:
> > (1) C standard library headers
> > (2) C++ standard library headers
> > (3) Our public headers
> > (4) Our private headers
> > 
> > ```
> > IncludeCategories:
> >   - Regex:   '^<.*.h>'
> > Priority:1
> >   - Regex:   '^<.*.hpp>'
> > Priority:3
> >   - Regex:   '^<.*>'
> > Priority:2
> >   - Regex:   '.*'
> > Priority:4
> > ```
> > 
> > __NOTE__: 3 seems to need to appear before 2, probably because it's 
> > more specific.

Thanks for the help, Michael. Just updated the review request. Let me know if 
there are any other issues.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review123734
---


On March 16, 2016, 1:37 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 16, 2016, 1:37 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-15 Thread Yong Tang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/
---

(Updated March 16, 2016, 1:37 a.m.)


Review request for mesos and Michael Park.


Changes
---

Update based on Michael's suggestions.


Bugs: MESOS-4906
https://issues.apache.org/jira/browse/MESOS-4906


Repository: mesos


Description
---

Upgrade to clang-format-3.8 (MESOS-4906).


Diffs (updated)
-

  docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
  support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 

Diff: https://reviews.apache.org/r/44758/diff/


Testing
---

make check


Thanks,

Yong Tang

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-15 Thread Michael Park 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review123734
---


Fix it, then Ship it!





support/clang-format (lines 24 - 35)


These do nothing unless `BreakBeforeBraces` is set to `Custom`. Our style 
matches `Mozilla`, so let's remove these.



support/clang-format (line 37)


`s/Linux/Mozilla/`



support/clang-format (lines 50 - 56)


We can help out a little more here:

The following code orders the headers:
(1) C standard library headers
(2) C++ standard library headers
(3) Our public headers
(4) Our private headers

```
IncludeCategories:
  - Regex:   '^<.*.h>'
Priority:1
  - Regex:   '^<.*.hpp>'
Priority:3
  - Regex:   '^<.*>'
Priority:2
  - Regex:   '.*'
Priority:4
```

__NOTE__: 3 seems to need to appear before 2, probably because it's more 
specific.


- Michael Park


On March 14, 2016, 1:09 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 14, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-13 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review123349
---



Patch looks great!

Reviews applied: [44758]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 14, 2016, 1:09 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 14, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-13 Thread Yong Tang 


> On March 13, 2016, 6:47 p.m., Benjamin Bannier wrote:
> > support/clang-format, line 2
> > 
> >
> > It would be great if you could use this opportunity and explicitly 
> > expand the values of the `Google` style we do rely on. This avoids the 
> > problem of upstream changing their definition of `Google` style, and then 
> > users on our end using different styles, depending on their clang version. 
> > This was an issue in the past with clang-format from trunk.
> > 
> > You should use `clang-format -dump-config` with some 3.5 and 3.8 
> > versions and adjust values where needed. As a starting point, I am using 
> > this config with clang-format from trunk (but cannot vouch for its quality),
> > 
> >   https://gist.github.com/bbannier/6e47d32eec9e0093711a

Thanks for the feedback Benjamin. I updated the clang-format file based on the 
Google style value expansion in 3.8. Please let me know if there are any other 
issues.


- Yong


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review123323
---


On March 14, 2016, 1:09 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 14, 2016, 1:09 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-13 Thread Yong Tang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/
---

(Updated March 14, 2016, 1:09 a.m.)


Review request for mesos and Michael Park.


Changes
---

Update clang-format by explicitly expanding the values of the Google style.


Bugs: MESOS-4906
https://issues.apache.org/jira/browse/MESOS-4906


Repository: mesos


Description
---

Upgrade to clang-format-3.8 (MESOS-4906).


Diffs (updated)
-

  docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
  support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 

Diff: https://reviews.apache.org/r/44758/diff/


Testing
---

make check


Thanks,

Yong Tang

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-13 Thread Benjamin Bannier 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review123323
---




support/clang-format (line 2)


It would be great if you could use this opportunity and explicitly expand 
the values of the `Google` style we do rely on. This avoids the problem of 
upstream changing their definition of `Google` style, and then users on our end 
using different styles, depending on their clang version. This was an issue in 
the past with clang-format from trunk.

You should use `clang-format -dump-config` with some 3.5 and 3.8 versions 
and adjust values where needed. As a starting point, I am using this config 
with clang-format from trunk (but cannot vouch for its quality),

  https://gist.github.com/bbannier/6e47d32eec9e0093711a


- Benjamin Bannier


On March 13, 2016, 5:15 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 13, 2016, 5:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Re: Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/#review123296
---



Patch looks great!

Reviews applied: [44758]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 13, 2016, 4:15 a.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44758/
> ---
> 
> (Updated March 13, 2016, 4:15 a.m.)
> 
> 
> Review request for mesos and Michael Park.
> 
> 
> Bugs: MESOS-4906
> https://issues.apache.org/jira/browse/MESOS-4906
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Upgrade to clang-format-3.8 (MESOS-4906).
> 
> 
> Diffs
> -
> 
>   docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
>   support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 
> 
> Diff: https://reviews.apache.org/r/44758/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>

Review Request 44758: Upgrade to clang-format-3.8 (MESOS-4906).

2016-03-12 Thread Yong Tang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44758/
---

Review request for mesos and Michael Park.


Bugs: MESOS-4906
https://issues.apache.org/jira/browse/MESOS-4906


Repository: mesos


Description
---

Upgrade to clang-format-3.8 (MESOS-4906).


Diffs
-

  docs/clang-format.md 7f1c1dfd70e1fe9bfa186df1bdda7bdcf867db04 
  support/clang-format 499d0e749e14e50256ae649afa0ced2b04589a0e 

Diff: https://reviews.apache.org/r/44758/diff/


Testing
---

make check


Thanks,

Yong Tang