Re: Review Request 44911: Fix the issue related to --disable-optimize (MESOS-4621).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44911/#review141575 --- Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On March 16, 2016, 5:44 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44911/ > --- > > (Updated March 16, 2016, 5:44 p.m.) > > > Review request for mesos, Benjamin Mahler, Neil Conway, and Till Toenshoff. > > > Bugs: MESOS-4621 > https://issues.apache.org/jira/browse/MESOS-4621 > > > Repository: mesos > > > Description > --- > > This fix tries to address MESOS-4621 where --disable-optimize is > not properly handled by configure.ac. > > > Diffs > - > > configure.ac 8e4f03593df4a8ba13f00292963e351acc3f71c1 > > Diff: https://reviews.apache.org/r/44911/diff/ > > > Testing > --- > > make check > > Also tested with configure --disable-optimize manually. > > > Thanks, > > Yong Tang > >
Review Request 44911: Fix the issue related to --disable-optimize (MESOS-4621).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44911/ --- Review request for mesos and Till Toenshoff. Bugs: MESOS-4621 https://issues.apache.org/jira/browse/MESOS-4621 Repository: mesos Description --- This fix tries to address MESOS-4621 where --disable-optimize is not properly handled by configure.ac. Diffs - configure.ac 8e4f03593df4a8ba13f00292963e351acc3f71c1 Diff: https://reviews.apache.org/r/44911/diff/ Testing --- make check Also tested with configure --disable-optimize manually. Thanks, Yong Tang
Re: Review Request 44911: Fix the issue related to --disable-optimize (MESOS-4621).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44911/#review123889 --- Patch looks great! Reviews applied: [44911] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 16, 2016, 3:02 p.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44911/ > --- > > (Updated March 16, 2016, 3:02 p.m.) > > > Review request for mesos and Till Toenshoff. > > > Bugs: MESOS-4621 > https://issues.apache.org/jira/browse/MESOS-4621 > > > Repository: mesos > > > Description > --- > > This fix tries to address MESOS-4621 where --disable-optimize is > not properly handled by configure.ac. > > > Diffs > - > > configure.ac 8e4f03593df4a8ba13f00292963e351acc3f71c1 > > Diff: https://reviews.apache.org/r/44911/diff/ > > > Testing > --- > > make check > > Also tested with configure --disable-optimize manually. > > > Thanks, > > Yong Tang > >
