Re: Review Request 44944: Handled chunked responses in docker URI fetcher.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/#review124027 --- Ship it! Ship It! - James Peach On March 17, 2016, 1:50 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44944/ > --- > > (Updated March 17, 2016, 1:50 a.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, James Peach, and > Timothy Chen. > > > Bugs: MESOS-4964 > https://issues.apache.org/jira/browse/MESOS-4964 > > > Repository: mesos > > > Description > --- > > Handled chunked responses in docker URI fetcher. > > This is because if the response is chunked, curl will output the dechunked > version. That will confuse the http response decoder because the header shows > that it is chunked. > > > Diffs > - > > src/uri/fetchers/docker.cpp 2ceee199c6b1bf92c5eca80c8d3344e97e394a09 > > Diff: https://reviews.apache.org/r/44944/diff/ > > > Testing > --- > > sudo make check > > > Thanks, > > Jie Yu > >
Re: Review Request 44944: Handled chunked responses in docker URI fetcher.
> On March 17, 2016, 3:44 p.m., James Peach wrote: > > Ship It! Verified that this patch fixes the chunked response parsing. - James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/#review124027 --- On March 17, 2016, 1:50 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44944/ > --- > > (Updated March 17, 2016, 1:50 a.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, James Peach, and > Timothy Chen. > > > Bugs: MESOS-4964 > https://issues.apache.org/jira/browse/MESOS-4964 > > > Repository: mesos > > > Description > --- > > Handled chunked responses in docker URI fetcher. > > This is because if the response is chunked, curl will output the dechunked > version. That will confuse the http response decoder because the header shows > that it is chunked. > > > Diffs > - > > src/uri/fetchers/docker.cpp 2ceee199c6b1bf92c5eca80c8d3344e97e394a09 > > Diff: https://reviews.apache.org/r/44944/diff/ > > > Testing > --- > > sudo make check > > > Thanks, > > Jie Yu > >
Re: Review Request 44944: Handled chunked responses in docker URI fetcher.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/ --- (Updated March 17, 2016, 1:50 a.m.) Review request for mesos, Gilbert Song, Jojy Varghese, James Peach, and Timothy Chen. Bugs: MESOS-4964 https://issues.apache.org/jira/browse/MESOS-4964 Repository: mesos Description (updated) --- Handled chunked responses in docker URI fetcher. This is because if the response is chunked, curl will output the dechunked version. That will confuse the http response decoder because the header shows that it is chunked. Diffs - src/uri/fetchers/docker.cpp 2ceee199c6b1bf92c5eca80c8d3344e97e394a09 Diff: https://reviews.apache.org/r/44944/diff/ Testing --- sudo make check Thanks, Jie Yu
Review Request 44944: Handled chunked responses in docker URI fetcher.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/ --- Review request for mesos, Gilbert Song, Jojy Varghese, James Peach, and Timothy Chen. Bugs: MESOS-4964 https://issues.apache.org/jira/browse/MESOS-4964 Repository: mesos Description --- Handled chunked responses in docker URI fetcher. Diffs - src/uri/fetchers/docker.cpp 2ceee199c6b1bf92c5eca80c8d3344e97e394a09 Diff: https://reviews.apache.org/r/44944/diff/ Testing --- sudo make check Thanks, Jie Yu
Re: Review Request 44944: Handled chunked responses in docker URI fetcher.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44944/#review123979 --- Ship it! Ship It! - Timothy Chen On March 17, 2016, 1:50 a.m., Jie Yu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44944/ > --- > > (Updated March 17, 2016, 1:50 a.m.) > > > Review request for mesos, Gilbert Song, Jojy Varghese, James Peach, and > Timothy Chen. > > > Bugs: MESOS-4964 > https://issues.apache.org/jira/browse/MESOS-4964 > > > Repository: mesos > > > Description > --- > > Handled chunked responses in docker URI fetcher. > > This is because if the response is chunked, curl will output the dechunked > version. That will confuse the http response decoder because the header shows > that it is chunked. > > > Diffs > - > > src/uri/fetchers/docker.cpp 2ceee199c6b1bf92c5eca80c8d3344e97e394a09 > > Diff: https://reviews.apache.org/r/44944/diff/ > > > Testing > --- > > sudo make check > > > Thanks, > > Jie Yu > >
