Re: Review Request 44993: Updated `TestContainerizer` to support default actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 24, 2016, 5:30 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- We use `ON_CALL` and `WillByDefault` here to specify the default actions. This allows the tests to leverage the `DoDefault` action. However, `ON_CALL` results in a "Uninteresting mock function call" warning unless each test puts expectations in place. As a result, we also use `EXPECT_CALL` and `WillRepeatedly` to get the best of both worlds: the ability to use `DoDefault` and no warnings when expectations are not explicit. Diffs - src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 Diff: https://reviews.apache.org/r/44993/diff/ Testing --- On Mac OS 10.10.4: `make check` `GTEST_FILTER="SlaveTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov
Re: Review Request 44993: Updated `TestContainerizer` to support default actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 22, 2016, 10:28 a.m.) Review request for mesos and Ben Mahler. Repository: mesos Description (updated) --- We use `ON_CALL` and `WillByDefault` here to specify the default actions. This allows the tests to leverage the `DoDefault` action. However, `ON_CALL` results in a "Uninteresting mock function call" warning unless each test puts expectations in place. As a result, we also use `EXPECT_CALL` and `WillRepeatedly` to get the best of both worlds: the ability to use `DoDefault` and no warnings when expectations are not explicit. Diffs - src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 Diff: https://reviews.apache.org/r/44993/diff/ Testing --- On Mac OS 10.10.4: `make check` `GTEST_FILTER="SlaveTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov
Re: Review Request 44993: Updated `TestContainerizer` to support default actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 21, 2016, 9:23 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- See summary. Diffs (updated) - src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 Diff: https://reviews.apache.org/r/44993/diff/ Testing --- On Mac OS 10.10.4: `make check` `GTEST_FILTER="SlaveTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov
Re: Review Request 44993: Updated `TestContainerizer` to support default actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- (Updated March 21, 2016, 3:12 p.m.) Review request for mesos and Ben Mahler. Repository: mesos Description --- See summary. Diffs - src/tests/containerizer.hpp 67fbe7fedbe170c3f22a2dcbb5aebf4195a5aabc src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 Diff: https://reviews.apache.org/r/44993/diff/ Testing (updated) --- On Mac OS 10.10.4: `make check` `GTEST_FILTER="SlaveTest.*" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov
Review Request 44993: Updated `TestContainerizer` to support default actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --- See summary. Diffs - src/tests/containerizer.hpp 67fbe7fedbe170c3f22a2dcbb5aebf4195a5aabc src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 Diff: https://reviews.apache.org/r/44993/diff/ Testing --- The complete chain was tested. See https://reviews.apache.org/r/44662/. Thanks, Alexander Rukletsov
Re: Review Request 44993: Updated `TestContainerizer` to support default actions.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44993/#review124305 --- I don't have enough context on why you had to make this change, can you please provide context? - Ben Mahler On March 17, 2016, 11:47 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44993/ > --- > > (Updated March 17, 2016, 11:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/tests/containerizer.hpp 67fbe7fedbe170c3f22a2dcbb5aebf4195a5aabc > src/tests/containerizer.cpp c6772ce5908edaab6c3189a65e8446217d1c7c27 > > Diff: https://reviews.apache.org/r/44993/diff/ > > > Testing > --- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
