Re: Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.
> On March 20, 2016, 5:51 p.m., Vinod Kone wrote: > > Looks like you created a new review instead of updating the existing review > > (https://reviews.apache.org/r/45000/) ? Can you discard this and update the > > old one instead. That way the review/comment history is not lost. You can > > use support/post-reviews.py to make this easy (see: > > http://mesos.apache.org/documentation/latest/submitting-a-patch/). ok will do. - Ashwin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45078/#review124455 --- On March 19, 2016, 9:57 p.m., Ashwin Murthy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45078/ > --- > > (Updated March 19, 2016, 9:57 p.m.) > > > Review request for mesos, Ben Whitehead, Joris Van Remoortere, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > MESOS-3902: Fix location header in redirect from non-leader. Adding the path > of the original request into the redirect URL. > > > Diffs > - > > src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f > > Diff: https://reviews.apache.org/r/45078/diff/ > > > Testing > --- > > Manual testing to be done. Testing framework does not support multi-master > tests as yet. > > > Thanks, > > Ashwin Murthy > >
Re: Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45078/#review124455 --- Looks like you created a new review instead of updating the existing review (https://reviews.apache.org/r/45000/) ? Can you discard this and update the old one instead. That way the review/comment history is not lost. You can use support/post-reviews.py to make this easy (see: http://mesos.apache.org/documentation/latest/submitting-a-patch/). - Vinod Kone On March 19, 2016, 9:57 p.m., Ashwin Murthy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45078/ > --- > > (Updated March 19, 2016, 9:57 p.m.) > > > Review request for mesos, Ben Whitehead, Joris Van Remoortere, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > MESOS-3902: Fix location header in redirect from non-leader. Adding the path > of the original request into the redirect URL. > > > Diffs > - > > src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f > > Diff: https://reviews.apache.org/r/45078/diff/ > > > Testing > --- > > Manual testing to be done. Testing framework does not support multi-master > tests as yet. > > > Thanks, > > Ashwin Murthy > >
Re: Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45078/#review124435 --- Patch looks great! Reviews applied: [45078] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On March 19, 2016, 9:57 p.m., Ashwin Murthy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45078/ > --- > > (Updated March 19, 2016, 9:57 p.m.) > > > Review request for mesos, Ben Whitehead, Joris Van Remoortere, and Vinod Kone. > > > Repository: mesos > > > Description > --- > > MESOS-3902: Fix location header in redirect from non-leader. Adding the path > of the original request into the redirect URL. > > > Diffs > - > > src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f > > Diff: https://reviews.apache.org/r/45078/diff/ > > > Testing > --- > > Manual testing to be done. Testing framework does not support multi-master > tests as yet. > > > Thanks, > > Ashwin Murthy > >
Review Request 45078: MESOS-3902: Fix location header in redirect from non-leader.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45078/ --- Review request for mesos, Ben Whitehead, Joris Van Remoortere, and Vinod Kone. Repository: mesos Description --- MESOS-3902: Fix location header in redirect from non-leader. Adding the path of the original request into the redirect URL. Diffs - src/master/http.cpp bfea8fa811c24d37b2d7a8109728e1f40217e02f Diff: https://reviews.apache.org/r/45078/diff/ Testing --- Manual testing to be done. Testing framework does not support multi-master tests as yet. Thanks, Ashwin Murthy
