Re: Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Daniel Pravat 


> On March 25, 2016, 6:48 p.m., Yi Sun wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp, line 87
> > 
> >
> > nit: getpagesize() is irrelevant now.

Alex is working on replacing getpagesize() calls.


- Daniel


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45299/#review125452
---


On March 25, 2016, 6:12 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45299/
> ---
> 
> (Updated March 25, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
> 6b81bf1ea3d571e8f5fb170076b85223b02efe2c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> 182ac9cfbacd4535fb355aac6ec38559d786e63a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
> 692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 6a391ff198ab724f689bcef79d4e2e05a786cbc2 
> 
> Diff: https://reviews.apache.org/r/45299/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Re: Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Yi Sun 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45299/#review125452
---


Fix it, then Ship it!




Ship It!


3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp (line 87)


nit: getpagesize() is irrelevant now.


- Yi Sun


On March 25, 2016, 6:12 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45299/
> ---
> 
> (Updated March 25, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout:[1/2] transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
> 7bd4bfbc2ec5922879dcefddc12137336b11be52 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
> 6b81bf1ea3d571e8f5fb170076b85223b02efe2c 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
> 182ac9cfbacd4535fb355aac6ec38559d786e63a 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
> 692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp 
> PRE-CREATION 
>   3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
> 9ee233b988c08d953e70345c55bcdd5c2f7c101b 
>   3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
> 6a391ff198ab724f689bcef79d4e2e05a786cbc2 
> 
> Diff: https://reviews.apache.org/r/45299/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 45299: Stout:[1/2] transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45299/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Stout:[1/2] transitioned codebase to use `os::pagesize`.


Diffs
-

  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 
7bd4bfbc2ec5922879dcefddc12137336b11be52 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/freebsd.hpp 
6b81bf1ea3d571e8f5fb170076b85223b02efe2c 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/linux.hpp 
182ac9cfbacd4535fb355aac6ec38559d786e63a 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/osx.hpp 
692fa483ee8a75dedae5ad0e7d2a4aa70dafa8a3 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/pagesize.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/pagesize.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/os/windows/pagesize.hpp 
PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp 
9ee233b988c08d953e70345c55bcdd5c2f7c101b 
  3rdparty/libprocess/3rdparty/stout/include/stout/windows/os.hpp 
6a391ff198ab724f689bcef79d4e2e05a786cbc2 

Diff: https://reviews.apache.org/r/45299/diff/


Testing
---

make check


Thanks,

Alex Clemmer