Re: Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45300/#review125473
---



Bad patch!

Reviews applied: [45300, 45299, 44084, 44978, 44082, 44081, 44808]

Failed command: ./support/apply-review.sh -n -r 44081

Error:
2016-03-25 21:13:49 URL:https://reviews.apache.org/r/44081/diff/raw/ 
[4367/4367] -> "44081.patch" [1]
error: patch failed: 
3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp:464
error: 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp: patch 
does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12143/console

- Mesos ReviewBot


On March 25, 2016, 6:12 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45300/
> ---
> 
> (Updated March 25, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
>   src/tests/containerizer/memory_test_helper.cpp 
> 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 
> 
> Diff: https://reviews.apache.org/r/45300/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Re: Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Yi Sun

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45300/#review125453
---


Ship it!




Ship It!

- Yi Sun


On March 25, 2016, 6:12 p.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45300/
> ---
> 
> (Updated March 25, 2016, 6:12 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.
> 
> 
> Diffs
> -
> 
>   src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
>   src/tests/containerizer/cgroups_tests.cpp 
> acaed9b3f8a04964092cef413133834d0cf5a145 
>   src/tests/containerizer/memory_test_helper.cpp 
> 92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 
> 
> Diff: https://reviews.apache.org/r/45300/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>



Review Request 45300: Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.

2016-03-25 Thread Alex Clemmer

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45300/
---

Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, Joris 
Van Remoortere, Michael Park, M Lawindi, and Yi Sun.


Repository: mesos


Description
---

Containerizer:[2/2] Transitioned codebase to use `os::pagesize`.


Diffs
-

  src/examples/balloon_executor.cpp 399218478a596387814d123290eeeb33102fad7a 
  src/tests/containerizer/cgroups_tests.cpp 
acaed9b3f8a04964092cef413133834d0cf5a145 
  src/tests/containerizer/memory_test_helper.cpp 
92579a28336b3c15ba7fdbb4a9f769ac7182aeb6 

Diff: https://reviews.apache.org/r/45300/diff/


Testing
---

make check


Thanks,

Alex Clemmer