Re: Review Request 45606: Added default class to htb qdisc.

2016-05-16 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45606/#review133398
---




src/linux/routing/queueing/htb.cpp (line 49)


I think the style prefer

```
Config()
  : rate(0),
defaultClass(Handle(TC_H_UNSPEC)) {}


- haosdent huang


On April 1, 2016, 9:51 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45606/
> ---
> 
> (Updated April 1, 2016, 9:51 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Bugs: mesos-4749
> https://issues.apache.org/jira/browse/mesos-4749
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added default class to htb::create().
> 
> 
> Diffs
> -
> 
>   src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 
>   src/linux/routing/queueing/htb.cpp faadf32bd48cc6bf968b1229789903c0d01fd75c 
> 
> Diff: https://reviews.apache.org/r/45606/diff/
> 
> 
> Testing
> ---
> 
> make && make check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Review Request 45606: Added default class to htb qdisc.

2016-04-01 Thread Cong Wang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45606/
---

Review request for mesos, Ian Downes and Jie Yu.


Bugs: mesos-4749
https://issues.apache.org/jira/browse/mesos-4749


Repository: mesos


Description
---

Added default class to htb::create().


Diffs
-

  src/linux/routing/queueing/htb.hpp 857646190d21387f98832f5094128505a52a0776 
  src/linux/routing/queueing/htb.cpp faadf32bd48cc6bf968b1229789903c0d01fd75c 

Diff: https://reviews.apache.org/r/45606/diff/


Testing
---

make && make check


Thanks,

Cong Wang