Re: Review Request 45798: Move long lived executor to use the v1 API.

2016-04-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45798/#review127526
---



Patch looks great!

Reviews applied: [45795, 45796, 45797, 45798]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 6, 2016, 10:37 p.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45798/
> ---
> 
> (Updated April 6, 2016, 10:37 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_executor.cpp 
> f0ba8966e198a496349e685b9e9ea296b8ed807e 
> 
> Diff: https://reviews.apache.org/r/45798/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45798: Move long lived executor to use the v1 API.

2016-04-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45798/
---

(Updated April 6, 2016, 10:37 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Review comment from Vinod


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/examples/long_lived_executor.cpp f0ba8966e198a496349e685b9e9ea296b8ed807e 

Diff: https://reviews.apache.org/r/45798/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45798: Move long lived executor to use the v1 API.

2016-04-06 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45798/
---

(Updated April 6, 2016, 10:09 p.m.)


Review request for mesos and Vinod Kone.


Changes
---

Change to log `SHUTDOWN` event. My bad had forgotten to publish.


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

See summary.


Diffs (updated)
-

  src/examples/long_lived_executor.cpp f0ba8966e198a496349e685b9e9ea296b8ed807e 

Diff: https://reviews.apache.org/r/45798/diff/


Testing
---

make check


Thanks,

Anand Mazumdar

Re: Review Request 45798: Move long lived executor to use the v1 API.

2016-04-06 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45798/#review127425
---


Fix it, then Ship it!





src/examples/long_lived_executor.cpp (line 98)


LOG the received event.


- Vinod Kone


On April 6, 2016, 3:43 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45798/
> ---
> 
> (Updated April 6, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_executor.cpp 
> f0ba8966e198a496349e685b9e9ea296b8ed807e 
> 
> Diff: https://reviews.apache.org/r/45798/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 45798: Move long lived executor to use the v1 API.

2016-04-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45798/#review127294
---



Patch looks great!

Reviews applied: [45795, 45796, 45797, 45798]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 6, 2016, 3:43 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45798/
> ---
> 
> (Updated April 6, 2016, 3:43 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4982
> https://issues.apache.org/jira/browse/MESOS-4982
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> See summary.
> 
> 
> Diffs
> -
> 
>   src/examples/long_lived_executor.cpp 
> f0ba8966e198a496349e685b9e9ea296b8ed807e 
> 
> Diff: https://reviews.apache.org/r/45798/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Review Request 45798: Move long lived executor to use the v1 API.

2016-04-05 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45798/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-4982
https://issues.apache.org/jira/browse/MESOS-4982


Repository: mesos


Description
---

See summary.


Diffs
-

  src/examples/long_lived_executor.cpp f0ba8966e198a496349e685b9e9ea296b8ed807e 

Diff: https://reviews.apache.org/r/45798/diff/


Testing
---

make check


Thanks,

Anand Mazumdar