Re: Review Request 46550: Fixed slave to initialize libprocess before modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/#review130186 --- Ship it! Ship It! - Vinod Kone On April 22, 2016, 1:41 a.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46550/ > --- > > (Updated April 22, 2016, 1:41 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and > Vinod Kone. > > > Repository: mesos > > > Description > --- > > This is important because otherwise a module might call > libprocess `initialize()` before slave calls `initialize(id)`. > If this happens the HTTP request process "delegate" will be wrong, > > > Diffs > - > > src/slave/main.cpp 38bd005 > > Diff: https://reviews.apache.org/r/46550/diff/ > > > Testing > --- > > make check > > > Thanks, > > Andy Pang > >
Re: Review Request 46550: Fixed slave to initialize libprocess before modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/#review130160 --- Ship it! Ship It! - Joseph Wu On April 21, 2016, 6:41 p.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46550/ > --- > > (Updated April 21, 2016, 6:41 p.m.) > > > Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and > Vinod Kone. > > > Repository: mesos > > > Description > --- > > This is important because otherwise a module might call > libprocess `initialize()` before slave calls `initialize(id)`. > If this happens the HTTP request process "delegate" will be wrong, > > > Diffs > - > > src/slave/main.cpp 38bd005 > > Diff: https://reviews.apache.org/r/46550/diff/ > > > Testing > --- > > make check > > > Thanks, > > Andy Pang > >
Re: Review Request 46550: Fixed slave to initialize libprocess before modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/#review130025 --- Patch looks great! Reviews applied: [46550] Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On April 22, 2016, 1:41 a.m., Andy Pang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46550/ > --- > > (Updated April 22, 2016, 1:41 a.m.) > > > Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and > Vinod Kone. > > > Repository: mesos > > > Description > --- > > This is important because otherwise a module might call > libprocess `initialize()` before slave calls `initialize(id)`. > If this happens the HTTP request process "delegate" will be wrong, > > > Diffs > - > > src/slave/main.cpp 38bd005 > > Diff: https://reviews.apache.org/r/46550/diff/ > > > Testing > --- > > make check > > > Thanks, > > Andy Pang > >
Review Request 46550: Fixed slave to initialize libprocess before modules.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46550/ --- Review request for mesos, Adam B, Kapil Arya, Joseph Wu, Niklas Nielsen, and Vinod Kone. Repository: mesos Description --- This is important because otherwise a module might call libprocess `initialize()` before slave calls `initialize(id)`. If this happens the HTTP request process "delegate" will be wrong, Diffs - src/slave/main.cpp 38bd005 Diff: https://reviews.apache.org/r/46550/diff/ Testing --- make check Thanks, Andy Pang
