Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-12 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review132894
---



Patch looks great!

Reviews applied: [46958]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 12, 2016, 5:05 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 12, 2016, 5:05 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-11 Thread Zhiwei Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/
---

(Updated May 12, 2016, 1:05 p.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5321
https://issues.apache.org/jira/browse/MESOS-5321


Repository: mesos


Description
---

Added Ubuntu 16.04 LTS to getting started document.


Diffs (updated)
-

  docs/getting-started.md 546b04cfa3aced67477cda6da18754fcd76324ba 

Diff: https://reviews.apache.org/r/46958/diff/


Testing
---

./configure --enable-ssl --enable-libevent && make


Thanks,

Zhiwei Chen

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-06 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review132065
---


Ship it!




Ship It!

- haosdent huang


On May 6, 2016, 3:18 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 6, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-06 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131991
---



Patch looks great!

Reviews applied: [46958]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 6, 2016, 3:18 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 6, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-05 Thread Zhiwei Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/
---

(Updated May 6, 2016, 11:18 a.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Changes
---

Remove python-boto since it is not required anymore, see: 
https://issues.apache.org/jira/browse/MESOS-5287


Bugs: MESOS-5321
https://issues.apache.org/jira/browse/MESOS-5321


Repository: mesos


Description
---

Added Ubuntu 16.04 LTS to getting started document.


Diffs (updated)
-

  docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 

Diff: https://reviews.apache.org/r/46958/diff/


Testing
---

./configure --enable-ssl --enable-libevent && make


Thanks,

Zhiwei Chen

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131647
---



Patch looks great!

Reviews applied: [46958]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 4, 2016, 9:03 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 9:03 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-04 Thread Zhiwei Chen 


> On May 4, 2016, 4:57 p.m., Neil Conway wrote:
> > docs/getting-started.md, line 47
> > 
> >
> > This should end in a period. Also, I'd say "(Only necessary if SSL and 
> > libevent are enabled)."

Thank you very much, I missed this.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131642
---


On May 4, 2016, 5:03 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 5:03 p.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-04 Thread Zhiwei Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/
---

(Updated May 4, 2016, 5:03 p.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5321
https://issues.apache.org/jira/browse/MESOS-5321


Repository: mesos


Description
---

Added Ubuntu 16.04 LTS to getting started document.


Diffs (updated)
-

  docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 

Diff: https://reviews.apache.org/r/46958/diff/


Testing
---

./configure --enable-ssl --enable-libevent && make


Thanks,

Zhiwei Chen

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-04 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131642
---


Fix it, then Ship it!





docs/getting-started.md (line 47)


This should end in a period. Also, I'd say "(Only necessary if SSL and 
libevent are enabled)."



docs/getting-started.md (line 69)


Same as above.


- Neil Conway


On May 4, 2016, 8:31 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 8:31 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-04 Thread Zhiwei Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/
---

(Updated May 4, 2016, 4:31 p.m.)


Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5321
https://issues.apache.org/jira/browse/MESOS-5321


Repository: mesos


Description
---

Added Ubuntu 16.04 LTS to getting started document.


Diffs (updated)
-

  docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 

Diff: https://reviews.apache.org/r/46958/diff/


Testing
---

./configure --enable-ssl --enable-libevent && make


Thanks,

Zhiwei Chen

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-04 Thread Zhiwei Chen 


> On May 4, 2016, 3:48 p.m., Neil Conway wrote:
> > docs/getting-started.md, line 64
> > 
> >
> > Is automake also required for 14.04?

my falt, it will be automatically installed. Will remove it in next patch.


> On May 4, 2016, 3:48 p.m., Neil Conway wrote:
> > docs/getting-started.md, line 66
> > 
> >
> > Can we synchronize this with the instructions for Ubuntu 14.04? i.e., 
> > either mention installing the SSL dependencies for both versions or neither.

OK, I will also update the Ubuntu 14.04 section.


> On May 4, 2016, 3:48 p.m., Neil Conway wrote:
> > docs/getting-started.md, line 70
> > 
> >
> > Is zlib1g-dev also required for 14.04?

Yes, it is required for 14.04, but it will be automatically installed when 
install libcurl4-nss-dev. In Ubuntu 16.04, it will no be installed when install 
libcurl4-nss-dev.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131637
---


On May 4, 2016, 10:50 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 10:50 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-04 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131637
---




docs/getting-started.md (line 64)


Is automake also required for 14.04?



docs/getting-started.md (line 66)


Can we synchronize this with the instructions for Ubuntu 14.04? i.e., 
either mention installing the SSL dependencies for both versions or neither.



docs/getting-started.md (line 70)


Is zlib1g-dev also required for 14.04?


- Neil Conway


On May 4, 2016, 2:50 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 2:50 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/#review131625
---



Patch looks great!

Reviews applied: [46958]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 4, 2016, 2:50 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46958/
> ---
> 
> (Updated May 4, 2016, 2:50 a.m.)
> 
> 
> Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.
> 
> 
> Bugs: MESOS-5321
> https://issues.apache.org/jira/browse/MESOS-5321
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added Ubuntu 16.04 LTS to getting started document.
> 
> 
> Diffs
> -
> 
>   docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 
> 
> Diff: https://reviews.apache.org/r/46958/diff/
> 
> 
> Testing
> ---
> 
> ./configure --enable-ssl --enable-libevent && make
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Review Request 46958: Added Ubuntu 16.04 LTS to getting started document.

2016-05-03 Thread Zhiwei Chen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46958/
---

Review request for mesos, Adam B, haosdent huang, Kapil Arya, and Joseph Wu.


Bugs: MESOS-5321
https://issues.apache.org/jira/browse/MESOS-5321


Repository: mesos


Description
---

Added Ubuntu 16.04 LTS to getting started document.


Diffs
-

  docs/getting-started.md e6be2818f6e1fa9bfbea5dc977ca0aa978532e8e 

Diff: https://reviews.apache.org/r/46958/diff/


Testing
---

./configure --enable-ssl --enable-libevent && make


Thanks,

Zhiwei Chen