Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-16 Thread Abhishek Dasgupta


> On May 13, 2016, 8:15 p.m., Alexander Rukletsov wrote:
> > Could you please squash this with https://reviews.apache.org/r/47061/ to 
> > minimize the churn?

done. Please re-check.


- Abhishek


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47340/#review133188
---


On May 13, 2016, 2:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47340/
> ---
> 
> (Updated May 13, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: Mesos-5316
> https://issues.apache.org/jira/browse/Mesos-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies marked down file for generating doc for endpoint
> '/containers' to include authentication requirement.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/containers.md ae6559b4fa360a012aab2cc5f00e4ba626a59256 
> 
> Diff: https://reviews.apache.org/r/47340/diff/
> 
> 
> Testing
> ---
> 
> Viewed the marked down file in the mesos documentation website generated 
> locally.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>



Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47340/#review133188
---



Could you please squash this with https://reviews.apache.org/r/47061/ to 
minimize the churn?

- Alexander Rukletsov


On May 13, 2016, 2:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47340/
> ---
> 
> (Updated May 13, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: Mesos-5316
> https://issues.apache.org/jira/browse/Mesos-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies marked down file for generating doc for endpoint
> '/containers' to include authentication requirement.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/containers.md ae6559b4fa360a012aab2cc5f00e4ba626a59256 
> 
> Diff: https://reviews.apache.org/r/47340/diff/
> 
> 
> Testing
> ---
> 
> Viewed the marked down file in the mesos documentation website generated 
> locally.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>



Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Till Toenshoff

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47340/#review133182
---


Ship it!




Ship It!

- Till Toenshoff


On May 13, 2016, 2:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47340/
> ---
> 
> (Updated May 13, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: Mesos-5316
> https://issues.apache.org/jira/browse/Mesos-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies marked down file for generating doc for endpoint
> '/containers' to include authentication requirement.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/containers.md ae6559b4fa360a012aab2cc5f00e4ba626a59256 
> 
> Diff: https://reviews.apache.org/r/47340/diff/
> 
> 
> Testing
> ---
> 
> Viewed the marked down file in the mesos documentation website generated 
> locally.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>



Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47340/#review133115
---


Ship it!




Ship It!

- Alexander Rukletsov


On May 13, 2016, 2:23 p.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47340/
> ---
> 
> (Updated May 13, 2016, 2:23 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: Mesos-5316
> https://issues.apache.org/jira/browse/Mesos-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies marked down file for generating doc for endpoint
> '/containers' to include authentication requirement.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/containers.md ae6559b4fa360a012aab2cc5f00e4ba626a59256 
> 
> Diff: https://reviews.apache.org/r/47340/diff/
> 
> 
> Testing
> ---
> 
> Viewed the marked down file in the mesos documentation website generated 
> locally.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>



Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Abhishek Dasgupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47340/
---

(Updated May 13, 2016, 2:23 p.m.)


Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till 
Toenshoff.


Bugs: Mesos-5316
https://issues.apache.org/jira/browse/Mesos-5316


Repository: mesos


Description (updated)
---

This patch modifies marked down file for generating doc for endpoint
'/containers' to include authentication requirement.


Diffs
-

  docs/endpoints/slave/containers.md ae6559b4fa360a012aab2cc5f00e4ba626a59256 

Diff: https://reviews.apache.org/r/47340/diff/


Testing
---

Viewed the marked down file in the mesos documentation website generated 
locally.


Thanks,

Abhishek Dasgupta



Re: Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47340/#review133103
---



Bad patch!

Reviews applied: [47340, 47062, 47061]

Failed command: ./support/apply-review.sh -n -r 47062

Error:
2016-05-13 13:52:46 URL:https://reviews.apache.org/r/47062/diff/raw/ 
[1646/1646] -> "47062.patch" [1]
Total errors found: 0
Checking 1 files
Error: No line in the commit message summary may exceed 72 characters.

Full log: https://builds.apache.org/job/mesos-reviewbot/13046/console

- Mesos ReviewBot


On May 13, 2016, 9:46 a.m., Abhishek Dasgupta wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47340/
> ---
> 
> (Updated May 13, 2016, 9:46 a.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till 
> Toenshoff.
> 
> 
> Bugs: Mesos-5316
> https://issues.apache.org/jira/browse/Mesos-5316
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch modifies marked down file for generating doc for endpoint 
> '/containers' to include authentication requirement.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/containers.md ae6559b4fa360a012aab2cc5f00e4ba626a59256 
> 
> Diff: https://reviews.apache.org/r/47340/diff/
> 
> 
> Testing
> ---
> 
> Viewed the marked down file in the mesos documentation website generated 
> locally.
> 
> 
> Thanks,
> 
> Abhishek Dasgupta
> 
>



Review Request 47340: Modified doc file for '/containers'.

2016-05-13 Thread Abhishek Dasgupta

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47340/
---

Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Till 
Toenshoff.


Bugs: Mesos-5316
https://issues.apache.org/jira/browse/Mesos-5316


Repository: mesos


Description
---

This patch modifies marked down file for generating doc for endpoint 
'/containers' to include authentication requirement.


Diffs
-

  docs/endpoints/slave/containers.md ae6559b4fa360a012aab2cc5f00e4ba626a59256 

Diff: https://reviews.apache.org/r/47340/diff/


Testing
---

Viewed the marked down file in the mesos documentation website generated 
locally.


Thanks,

Abhishek Dasgupta