Re: Review Request 47387: Stout: Implemented `fsync.hpp` for Windows.

2016-05-23 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47387/
---

(Updated May 23, 2016, 12:39 p.m.)


Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5382
https://issues.apache.org/jira/browse/MESOS-5382


Repository: mesos


Description
---

Stout: Implemented `fsync.hpp` for Windows.


Diffs (updated)
-

  3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
  3rdparty/stout/include/stout/os/fsync.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/fsync.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/fsync.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47387/diff/


Testing
---


Thanks,

Alex Clemmer

Re: Review Request 47387: Stout: Implemented `fsync.hpp` for Windows.

2016-05-16 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47387/#review133419
---


Fix it, then Ship it!





3rdparty/stout/include/stout/os/windows/fsync.hpp (line 36)


indentation


- Joris Van Remoortere


On May 14, 2016, 11:58 a.m., Alex Clemmer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47387/
> ---
> 
> (Updated May 14, 2016, 11:58 a.m.)
> 
> 
> Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
> Remoortere, and Michael Park.
> 
> 
> Bugs: MESOS-5382
> https://issues.apache.org/jira/browse/MESOS-5382
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Stout: Implemented `fsync.hpp` for Windows.
> 
> 
> Diffs
> -
> 
>   3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
>   3rdparty/stout/include/stout/os/fsync.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/posix/fsync.hpp PRE-CREATION 
>   3rdparty/stout/include/stout/os/windows/fsync.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47387/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Alex Clemmer
> 
>

Review Request 47387: Stout: Implemented `fsync.hpp` for Windows.

2016-05-14 Thread Alex Clemmer 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47387/
---

Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van 
Remoortere, and Michael Park.


Bugs: MESOS-5382
https://issues.apache.org/jira/browse/MESOS-5382


Repository: mesos


Description
---

Stout: Implemented `fsync.hpp` for Windows.


Diffs
-

  3rdparty/stout/include/Makefile.am 9b39ce32c0269479066cf7991afaeed65d8ab547 
  3rdparty/stout/include/stout/os/fsync.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/posix/fsync.hpp PRE-CREATION 
  3rdparty/stout/include/stout/os/windows/fsync.hpp PRE-CREATION 

Diff: https://reviews.apache.org/r/47387/diff/


Testing
---


Thanks,

Alex Clemmer