Re: Review Request 47489: Windows: Symplified `os::exists`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/#review135571 --- Ship it! Ship It! - Joris Van Remoortere On May 23, 2016, 9:36 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47489/ > --- > > (Updated May 23, 2016, 9:36 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris > Van Remoortere, and Michael Park. > > > Bugs: MESOS-5420 > https://issues.apache.org/jira/browse/MESOS-5420 > > > Repository: mesos > > > Description > --- > > os::exists determines if the process identified by the `pid` parameter > is present in the system. `OpenProcess` succeeds when the process object > exists and the caller has `PROCESS_QUERY_LIMITED_INFORMATION' right. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/exists.hpp > 423e4a81b4d34460f7f9f073577e11dfa2d2a520 > > Diff: https://reviews.apache.org/r/47489/diff/ > > > Testing > --- > > Windows build/run > > > Thanks, > > Daniel Pravat > >
Re: Review Request 47489: Windows: Symplified `os::exists`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/ --- (Updated May 23, 2016, 9:36 p.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Bugs: MESOS-5420 https://issues.apache.org/jira/browse/MESOS-5420 Repository: mesos Description (updated) --- os::exists determines if the process identified by the `pid` parameter is present in the system. `OpenProcess` succeeds when the process object exists and the caller has `PROCESS_QUERY_LIMITED_INFORMATION' right. Diffs (updated) - 3rdparty/stout/include/stout/os/windows/exists.hpp 423e4a81b4d34460f7f9f073577e11dfa2d2a520 Diff: https://reviews.apache.org/r/47489/diff/ Testing --- Windows build/run Thanks, Daniel Pravat
Re: Review Request 47489: Windows: Symplified `os::exists`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/ --- (Updated May 20, 2016, 1:47 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Bugs: MESOS-5420 https://issues.apache.org/jira/browse/MESOS-5420 Repository: mesos Description --- Windows: Symplified `os::exists`. Diffs (updated) - 3rdparty/stout/include/stout/os/windows/exists.hpp 423e4a81b4d34460f7f9f073577e11dfa2d2a520 Diff: https://reviews.apache.org/r/47489/diff/ Testing --- Windows build/run Thanks, Daniel Pravat
Re: Review Request 47489: Windows: Symplified `os::exists`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/ --- (Updated May 20, 2016, 12:17 a.m.) Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Bugs: MESOS-5420 https://issues.apache.org/jira/browse/MESOS-5420 Repository: mesos Description --- Windows: Symplified `os::exists`. Diffs (updated) - 3rdparty/stout/include/stout/os/windows/exists.hpp 423e4a81b4d34460f7f9f073577e11dfa2d2a520 Diff: https://reviews.apache.org/r/47489/diff/ Testing (updated) --- Windows build/run Thanks, Daniel Pravat
Re: Review Request 47489: Windows: Symplified `os::exists`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/#review133652 --- Bad patch! Reviews applied: [47489, 42945] Failed command: ./support/apply-review.sh -n -r 42945 Error: 2016-05-17 22:41:39 URL:https://reviews.apache.org/r/42945/diff/raw/ [13298/13298] -> "42945.patch" [1] error: patch failed: configure.ac:116 error: configure.ac: patch does not apply error: patch failed: src/Makefile.am:138 error: src/Makefile.am: patch does not apply error: patch failed: src/master/master.cpp:416 error: src/master/master.cpp: patch does not apply error: patch failed: src/slave/slave.cpp:805 error: src/slave/slave.cpp: patch does not apply error: patch failed: src/tests/fault_tolerance_tests.cpp:135 error: src/tests/fault_tolerance_tests.cpp: patch does not apply error: patch failed: src/tests/mesos.cpp:96 error: src/tests/mesos.cpp: patch does not apply error: patch failed: src/tests/script.cpp:109 error: src/tests/script.cpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/13132/console - Mesos ReviewBot On May 17, 2016, 7:55 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47489/ > --- > > (Updated May 17, 2016, 7:55 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris > Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > --- > > Windows: Symplified `os::exists`. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/exists.hpp > 423e4a81b4d34460f7f9f073577e11dfa2d2a520 > > Diff: https://reviews.apache.org/r/47489/diff/ > > > Testing > --- > > > Thanks, > > Daniel Pravat > >
Re: Review Request 47489: Windows: Symplified `os::exists`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/#review133614 --- Ship it! Ship It! - Alex Naparu On May 17, 2016, 7:55 p.m., Daniel Pravat wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47489/ > --- > > (Updated May 17, 2016, 7:55 p.m.) > > > Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris > Van Remoortere, and Michael Park. > > > Repository: mesos > > > Description > --- > > Windows: Symplified `os::exists`. > > > Diffs > - > > 3rdparty/stout/include/stout/os/windows/exists.hpp > 423e4a81b4d34460f7f9f073577e11dfa2d2a520 > > Diff: https://reviews.apache.org/r/47489/diff/ > > > Testing > --- > > > Thanks, > > Daniel Pravat > >
Review Request 47489: Windows: Symplified `os::exists`.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47489/ --- Review request for mesos, Alex Naparu, Artem Harutyunyan, Alex Clemmer, Joris Van Remoortere, and Michael Park. Repository: mesos Description --- Windows: Symplified `os::exists`. Diffs - 3rdparty/stout/include/stout/os/windows/exists.hpp 423e4a81b4d34460f7f9f073577e11dfa2d2a520 Diff: https://reviews.apache.org/r/47489/diff/ Testing --- Thanks, Daniel Pravat
