Re: Review Request 47499: Make Mesos site responsive.

2016-05-18 Thread Tomasz Janiszewski 


> On May 18, 2016, 3 a.m., haosdent huang wrote:
> > Hi, @janisz May you merge changes from 
> > https://reviews.apache.org/r/47510/diff/1#index_header . It looks better 
> > according my test.

I checked 47510 and indeed it looks better than this. I'll close this PR, in 
favour of 47510


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133684
---


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133723
---



Patch looks great!

Reviews applied: [47499]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133687
---




site/source/assets/css/main.css (line 125)


There is a responsive navbar in bootstrap 
http://getbootstrap.com/components/#navbar I think could adjust current code to 
use it.


- haosdent huang


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133686
---




site/source/assets/css/main.css 


Use `max-width` here seems better.


- haosdent huang


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133685
---




site/source/assets/css/main.css (line 14)


We could use max-width here directly to avoid use multiple medias.


- haosdent huang


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133684
---



Hi, @janisz May you merge changes from 
https://reviews.apache.org/r/47510/diff/1#index_header . It looks better 
according my test.

- haosdent huang


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133679
---


Ship it!




Ship It!

- Vinod Kone


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread Tim Anderegg 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133678
---



LGTM. We might want to consider causing the menu to split into 2 columns on 
mobile devices to maximize vertical space, but that's probably a separate 
commit.

- Tim Anderegg


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133666
---



LGTM. 

@Tim Does this look OK to you?

- Vinod Kone


On May 18, 2016, 12:24 a.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 18, 2016, 12:24 a.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> * PC
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
> ![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
> * iPad
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
> * iPhone
> ![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
> ![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread Tomasz Janiszewski 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/
---

(Updated May 18, 2016, 12:24 a.m.)


Review request for mesos, Tim Anderegg and Vinod Kone.


Bugs: MESOS-5402
https://issues.apache.org/jira/browse/MESOS-5402


Repository: mesos


Description
---

This patch wrap lines on small screens,
so the page is more friendly to view on
mobile.


Diffs (updated)
-

  site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
  site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 

Diff: https://reviews.apache.org/r/47499/diff/


Testing (updated)
---

Manually checked some random pages in different sizes.

* PC
![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/pT87vto4CHMMaG2/old_pc.png)
![PC](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/idXPLIM8t0LxRWA/new_pc.png)
* iPad
![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/Wt3g8bknstahXSC/old_iPad_landscape.png)
![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/TBTjlj1xT3YFrOf/new_iPad_landscape.png)
![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/sMct2b54lfCzrAu/old_iPad.png)
![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/qp2hj1UCNOfGLIX/new_iPad.png)
* iPhone
![iPhone](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/mCTMOx8FLFxANeo/old_iPhone.png)
![iPad](https://s3-eu-west-1.amazonaws.com/uploads-eu.hipchat.com/48981/330344/5hlKDsOKqdJaztw/new_iPhone.png)


Thanks,

Tomasz Janiszewski

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread Tomasz Janiszewski 


> On May 17, 2016, 11:18 p.m., Vinod Kone wrote:
> > Can you attach before and after screenshots to this review?
> > 
> > Also, I'm assuming these changes do not adversely affect the desktop 
> > version?

Posted in testing section. For the first sight diferrences could be hard to 
notice becouse only spacing has changed in PC version. In mobile changes are 
obvious. I have a problem with generating nice screenshot from page with 
vertical scrolls that why old version could be turncated.


> On May 17, 2016, 11:18 p.m., Vinod Kone wrote:
> > site/source/index.html.md, line 6
> > 
> >
> > i'm assuming killing this safe to do?

It'll add padding


- Tomasz


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133656
---


On May 17, 2016, 10:48 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 17, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Re: Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/#review133656
---



Can you attach before and after screenshots to this review?

Also, I'm assuming these changes do not adversely affect the desktop version?


site/source/index.html.md 


i'm assuming killing this safe to do?


- Vinod Kone


On May 17, 2016, 10:48 p.m., Tomasz Janiszewski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47499/
> ---
> 
> (Updated May 17, 2016, 10:48 p.m.)
> 
> 
> Review request for mesos, Tim Anderegg and Vinod Kone.
> 
> 
> Bugs: MESOS-5402
> https://issues.apache.org/jira/browse/MESOS-5402
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch wrap lines on small screens,
> so the page is more friendly to view on
> mobile.
> 
> 
> Diffs
> -
> 
>   site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
>   site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 
> 
> Diff: https://reviews.apache.org/r/47499/diff/
> 
> 
> Testing
> ---
> 
> Manually checked some random pages in different sizes.
> 
> 
> Thanks,
> 
> Tomasz Janiszewski
> 
>

Review Request 47499: Make Mesos site responsive.

2016-05-17 Thread Tomasz Janiszewski 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47499/
---

Review request for mesos and Vinod Kone.


Bugs: MESOS-5402
https://issues.apache.org/jira/browse/MESOS-5402


Repository: mesos


Description
---

This patch wrap lines on small screens,
so the page is more friendly to view on
mobile.


Diffs
-

  site/source/assets/css/main.css 73ca8946091a638a359b1d769961879a283fa099 
  site/source/index.html.md 7b4bdaee61687f487423c1d90a674c78fdf002a4 

Diff: https://reviews.apache.org/r/47499/diff/


Testing
---

Manually checked some random pages in different sizes.


Thanks,

Tomasz Janiszewski